René's URL Explorer Experiment


Title: Support for Promises/A+ by jimlloyd · Pull Request #187 · joeferner/node-java · GitHub

Open Graph Title: Support for Promises/A+ by jimlloyd · Pull Request #187 · joeferner/node-java

X Title: Support for Promises/A+ by jimlloyd · Pull Request #187 · joeferner/node-java

Description: @joeferner Joe, this PR replaces PR #181, and is now ready for merging subject to your review. The one thing we might want to do is declare this an 'experimental' feature in the README. In fact, I want to do more experimentation, but I think this is a useful checkpoint.

Open Graph Description: @joeferner Joe, this PR replaces PR #181, and is now ready for merging subject to your review. The one thing we might want to do is declare this an 'experimental' feature in the README. In ...

X Description: @joeferner Joe, this PR replaces PR #181, and is now ready for merging subject to your review. The one thing we might want to do is declare this an 'experimental' feature in the REA...

Opengraph URL: https://github.com/joeferner/node-java/pull/187

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:264518d7-c93e-9e68-b141-f3a4c52f4004
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8FC:1A7B13:40BAB:5B290:6AFD483B
html-safe-nonce122e96c73e97817ad958a9427ede9926fd769ca19372dab812bfe07b16cd0ad8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEZDOjFBN0IxMzo0MEJBQjo1QjI5MDo2QUZENDgzQiIsInZpc2l0b3JfaWQiOiI4OTc4MjEzMDY3NzE2MTE4NTg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb2dd5eb0854b011fb9b8e22cd798cc33fa0c0e625a44916e3375596455426695
hovercard-subject-tagpull_request:27374373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/187/files
twitter:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
og:image:alt@joeferner Joe, this PR replaces PR #181, and is now ready for merging subject to your review. The one thing we might want to do is declare this an 'experimental' feature in the README. In ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/joeferner/node-java git https://github.com/joeferner/node-java.git
octolytics-dimension-user_id808857
octolytics-dimension-user_loginjoeferner
octolytics-dimension-repository_id3228734
octolytics-dimension-repository_nwojoeferner/node-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3228734
octolytics-dimension-repository_network_root_nwojoeferner/node-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/joeferner/node-java/pull/187/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F187%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F187%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java
Reloadhttps://github.com/joeferner/node-java/pull/187/files
Reloadhttps://github.com/joeferner/node-java/pull/187/files
Reloadhttps://github.com/joeferner/node-java/pull/187/files
joefernerhttps://github.com/joeferner
node-javahttps://github.com/joeferner/node-java
Codehttps://github.com/joeferner/node-java
Issues208 (208)https://github.com/joeferner/node-java/issues
Pull requests2 (2)https://github.com/joeferner/node-java/pulls
Actionshttps://github.com/joeferner/node-java/actions
Projectshttps://github.com/joeferner/node-java/projects
Wikihttps://github.com/joeferner/node-java/wiki
Security and qualityhttps://github.com/joeferner/node-java/security
Insightshttps://github.com/joeferner/node-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
joefernerhttps://github.com/joeferner
joeferner:masterhttps://github.com/joeferner/node-java/tree/master
jimlloyd:feature/promises.r2https://github.com/jimlloyd/node-java/tree/feature/promises.r2
Conversation 1 https://github.com/joeferner/node-java/pull/187
Commits 11 https://github.com/joeferner/node-java/pull/187/commits
Checks 0 https://github.com/joeferner/node-java/pull/187/checks
Files changed https://github.com/joeferner/node-java/pull/187/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/187/files
Support for Promises/A+ https://github.com/joeferner/node-java/pull/187/files#top
Show all changes 11 commits https://github.com/joeferner/node-java/pull/187/files
e79e0a3 First rough draft of adding support for promises. jimlloyd Jan 6, 2015 https://github.com/joeferner/node-java/pull/187/commits/e79e0a3a2c68172c673be3e0cfbba11a637814fc
7a688ec Fix build on node 0.11. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/187/commits/7a688ec0a6f059f1dbc4e956d78649c42410aa27
63be4ce Use when instead of bluebird for compatiblity with node 0.8. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/187/commits/63be4cea80e83a1baaf2748ff46e13b3a0de4f2b
d9c25b0 Promisify java class static methods on import. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/187/commits/d9c25b07463212120363545ebe85596bffd2748e
1a10c0a SetAccessor to prohibit overwriting of asyncOptions, and some other r… jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/187/commits/1a10c0a1d292d1a947c8fe5ff19ca3929b22f83c
80f543f Assert if promisfy doesn't return a function. Use 'promiseSuffix' ins… jimlloyd Jan 8, 2015 https://github.com/joeferner/node-java/pull/187/commits/80f543f747ee95eaa32b496261f0a50248a83821
d6aef41 Promisify three async methods of Java module. jimlloyd Jan 8, 2015 https://github.com/joeferner/node-java/pull/187/commits/d6aef41226ed2e4fbec0734d50d993e80ff5422e
cf1a538 Document promises in the README.md. jimlloyd Jan 9, 2015 https://github.com/joeferner/node-java/pull/187/commits/cf1a538eba326ff5f59a3cba11c22f54b8922973
57bbcb8 Document in testHelpers.js the tested promises implementations. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/187/commits/57bbcb8cbc6d4431d6bee117e5e547df51870d98
319c9a1 Add promises test with many chained .then() calls. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/187/commits/319c9a1672401b053d01343c6ace950f63955ff9
bff8a38 Disable one test at runtime if running OpenJDK6. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/187/commits/bff8a38dfa90a84d58289da705950bab3b30dd59
Clear filters https://github.com/joeferner/node-java/pull/187/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/187/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/187/files
README.md https://github.com/joeferner/node-java/pull/187/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
nodeJavaBridge.js https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
package.json https://github.com/joeferner/node-java/pull/187/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
java.cpp https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
java.h https://github.com/joeferner/node-java/pull/187/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
javaObject.cpp https://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
promises-test.js https://github.com/joeferner/node-java/pull/187/files#diff-e8b6b9cb875655c9638548e1c0da5ff116dce07e8e3d8e4ed7015af164715ee3
testHelpers.js https://github.com/joeferner/node-java/pull/187/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
README.mdhttps://github.com/joeferner/node-java/pull/187/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/joeferner/node-java/pull/187/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
lib/nodeJavaBridge.jshttps://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/lib/nodeJavaBridge.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/187/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
package.jsonhttps://github.com/joeferner/node-java/pull/187/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/joeferner/node-java/pull/187/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/java.cpphttps://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/src/java.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/187/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
src/java.hhttps://github.com/joeferner/node-java/pull/187/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/src/java.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
src/javaObject.cpphttps://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/src/javaObject.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/187/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
test/promises-test.jshttps://github.com/joeferner/node-java/pull/187/files#diff-e8b6b9cb875655c9638548e1c0da5ff116dce07e8e3d8e4ed7015af164715ee3
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/test/promises-test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
testHelpers.jshttps://github.com/joeferner/node-java/pull/187/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
View file https://github.com/jimlloyd/node-java/blob/bff8a38dfa90a84d58289da705950bab3b30dd59/testHelpers.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/187/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/187/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.