| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6cc49b94-c52f-37d3-985f-14c2ae9c9b05 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80C0:73228:23D039:302D3A:6AFD4599 |
| html-safe-nonce | 7c2778e0730c75fb25e7aa5e38ae1bb971e80c02500da88fe8f85764998d169e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEMwOjczMjI4OjIzRDAzOTozMDJEM0E6NkFGRDQ1OTkiLCJ2aXNpdG9yX2lkIjoiOTE5ODk2ODMxNzk0MTcyODY2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a1ee32f9824b35301ac66a50d8dbb76b76d6164bf80d3617719a91e0517d96ce |
| hovercard-subject-tag | pull_request:27374373 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/joeferner/node-java/187/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fae2e95df7249872ee7d635cbf584a331fa990193e370c2158557d641e1d3d82/joeferner/node-java/pull/187 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fae2e95df7249872ee7d635cbf584a331fa990193e370c2158557d641e1d3d82/joeferner/node-java/pull/187 |
| og:image:alt | @joeferner
Joe, this PR replaces PR #181, and is now ready for merging subject to your review.
The one thing we might want to do is declare this an 'experimental' feature in the README.
In ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jimlloyd |
| hostname | github.com |
| expected-hostname | github.com |
| None | bdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474 |
| turbo-cache-control | no-cache |
| go-import | github.com/joeferner/node-java git https://github.com/joeferner/node-java.git |
| octolytics-dimension-user_id | 808857 |
| octolytics-dimension-user_login | joeferner |
| octolytics-dimension-repository_id | 3228734 |
| octolytics-dimension-repository_nwo | joeferner/node-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3228734 |
| octolytics-dimension-repository_network_root_nwo | joeferner/node-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 556dd37bb0aceffb25724e151b5d858b3265b40b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/joeferner/node-java/pull/187#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F187 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F187 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=joeferner%2Fnode-java |
| Reload | https://github.com/joeferner/node-java/pull/187 |
| Reload | https://github.com/joeferner/node-java/pull/187 |
| Reload | https://github.com/joeferner/node-java/pull/187 |
| joeferner | https://github.com/joeferner |
| node-java | https://github.com/joeferner/node-java |
| Code | https://github.com/joeferner/node-java |
| Issues208 (208) | https://github.com/joeferner/node-java/issues |
| Pull requests2 (2) | https://github.com/joeferner/node-java/pulls |
| Actions | https://github.com/joeferner/node-java/actions |
| Projects | https://github.com/joeferner/node-java/projects |
| Wiki | https://github.com/joeferner/node-java/wiki |
| Security and quality | https://github.com/joeferner/node-java/security |
| Insights | https://github.com/joeferner/node-java/pulse |
| https://github.com/joeferner/node-java |
| joeferner | https://github.com/joeferner |
| joeferner:master | https://github.com/joeferner/node-java/tree/master |
| jimlloyd:feature/promises.r2 | https://github.com/jimlloyd/node-java/tree/feature/promises.r2 |
| Conversation | https://github.com/joeferner/node-java/pull/187 |
| Commits11 (11) | https://github.com/joeferner/node-java/pull/187/commits |
| Checks | https://github.com/joeferner/node-java/pull/187/checks |
| Files changed | https://github.com/joeferner/node-java/pull/187/files |
| Support for Promises/A+ | https://github.com/joeferner/node-java/pull/187#top |
| joeferner | https://github.com/joeferner |
| joeferner:master | https://github.com/joeferner/node-java/tree/master |
| jimlloyd:feature/promises.r2 | https://github.com/jimlloyd/node-java/tree/feature/promises.r2 |
|
| https://github.com/jimlloyd |
| jimlloyd | https://github.com/jimlloyd |
| Jan 14, 2015 | https://github.com/joeferner/node-java/pull/187#issue-54362296 |
| @joeferner | https://github.com/joeferner |
| #181 | https://github.com/joeferner/node-java/pull/181 |
| Please reload this page | https://github.com/joeferner/node-java/pull/187 |
| jimlloyd | https://github.com/jimlloyd |
| January 14, 2015 10:46 | https://github.com/joeferner/node-java/pull/187#commits-pushed-e79e0a3 |
|
| https://github.com/jimlloyd |
| First rough draft of adding support for promises. | https://github.com/joeferner/node-java/pull/187/commits/e79e0a3a2c68172c673be3e0cfbba11a637814fc |
| e79e0a3 | https://github.com/joeferner/node-java/pull/187/commits/e79e0a3a2c68172c673be3e0cfbba11a637814fc |
|
| https://github.com/jimlloyd |
| Fix build on node 0.11. | https://github.com/joeferner/node-java/pull/187/commits/7a688ec0a6f059f1dbc4e956d78649c42410aa27 |
| 7a688ec | https://github.com/joeferner/node-java/pull/187/commits/7a688ec0a6f059f1dbc4e956d78649c42410aa27 |
|
| https://github.com/jimlloyd |
| Use when instead of bluebird for compatiblity with node 0.8. | https://github.com/joeferner/node-java/pull/187/commits/63be4cea80e83a1baaf2748ff46e13b3a0de4f2b |
| 63be4ce | https://github.com/joeferner/node-java/pull/187/commits/63be4cea80e83a1baaf2748ff46e13b3a0de4f2b |
|
| https://github.com/jimlloyd |
| Promisify java class static methods on import. | https://github.com/joeferner/node-java/pull/187/commits/d9c25b07463212120363545ebe85596bffd2748e |
| d9c25b0 | https://github.com/joeferner/node-java/pull/187/commits/d9c25b07463212120363545ebe85596bffd2748e |
|
| https://github.com/jimlloyd |
| SetAccessor to prohibit overwriting of asyncOptions, and some other r… | https://github.com/joeferner/node-java/pull/187/commits/1a10c0a1d292d1a947c8fe5ff19ca3929b22f83c |
| 1a10c0a | https://github.com/joeferner/node-java/pull/187/commits/1a10c0a1d292d1a947c8fe5ff19ca3929b22f83c |
|
| https://github.com/jimlloyd |
| Assert if promisfy doesn't return a function. Use 'promiseSuffix' ins… | https://github.com/joeferner/node-java/pull/187/commits/80f543f747ee95eaa32b496261f0a50248a83821 |
| 80f543f | https://github.com/joeferner/node-java/pull/187/commits/80f543f747ee95eaa32b496261f0a50248a83821 |
|
| https://github.com/jimlloyd |
| Promisify three async methods of Java module. | https://github.com/joeferner/node-java/pull/187/commits/d6aef41226ed2e4fbec0734d50d993e80ff5422e |
| d6aef41 | https://github.com/joeferner/node-java/pull/187/commits/d6aef41226ed2e4fbec0734d50d993e80ff5422e |
|
| https://github.com/jimlloyd |
| Document promises in the README.md. | https://github.com/joeferner/node-java/pull/187/commits/cf1a538eba326ff5f59a3cba11c22f54b8922973 |
| cf1a538 | https://github.com/joeferner/node-java/pull/187/commits/cf1a538eba326ff5f59a3cba11c22f54b8922973 |
|
| https://github.com/jimlloyd |
| Document in testHelpers.js the tested promises implementations. | https://github.com/joeferner/node-java/pull/187/commits/57bbcb8cbc6d4431d6bee117e5e547df51870d98 |
| 57bbcb8 | https://github.com/joeferner/node-java/pull/187/commits/57bbcb8cbc6d4431d6bee117e5e547df51870d98 |
|
| https://github.com/jimlloyd |
| Add promises test with many chained .then() calls. | https://github.com/joeferner/node-java/pull/187/commits/319c9a1672401b053d01343c6ace950f63955ff9 |
| 319c9a1 | https://github.com/joeferner/node-java/pull/187/commits/319c9a1672401b053d01343c6ace950f63955ff9 |
|
| https://github.com/jimlloyd |
| Disable one test at runtime if running OpenJDK6. | https://github.com/joeferner/node-java/pull/187/commits/bff8a38dfa90a84d58289da705950bab3b30dd59 |
| bff8a38 | https://github.com/joeferner/node-java/pull/187/commits/bff8a38dfa90a84d58289da705950bab3b30dd59 |
| joeferner#186 | https://github.com/joeferner/node-java/issues/186 |
| https://github.com/jimlloyd |
| jimlloyd | https://github.com/jimlloyd |
|
Jan 14, 2015
| https://github.com/joeferner/node-java/pull/187#ref-pullrequest-53576993 |
|
First rough draft of adding support for promises.
#181
| https://github.com/joeferner/node-java/pull/181 |
| joeferner | https://github.com/joeferner |
|
Jan 14, 2015
| https://github.com/joeferner/node-java/pull/187#ref-commit-0da4938 |
|
| https://github.com/joeferner |
| Merge pull request | https://github.com/joeferner/node-java/commit/0da493815b743c54d528fdcf2957a4d3c8302e58 |
| #187 | https://github.com/joeferner/node-java/pull/187 |
| from jimlloyd/feature/promises.r2 | https://github.com/joeferner/node-java/commit/0da493815b743c54d528fdcf2957a4d3c8302e58 |
| 0da4938 | https://github.com/joeferner/node-java/commit/0da493815b743c54d528fdcf2957a4d3c8302e58 |
| https://github.com/joeferner |
| joeferner | https://github.com/joeferner |
| 0da4938 | https://github.com/joeferner/node-java/commit/0da493815b743c54d528fdcf2957a4d3c8302e58 |
| Jan 14, 2015 | https://github.com/joeferner/node-java/pull/187#event-218993374 |
| https://github.com/joeferner |
| joeferner | https://github.com/joeferner |
| Jan 14, 2015 | https://github.com/joeferner/node-java/pull/187#issuecomment-69982227 |
| Please reload this page | https://github.com/joeferner/node-java/pull/187 |
| https://github.com/jimlloyd |
| jimlloyd | https://github.com/jimlloyd |
| January 14, 2015 21:08 | https://github.com/joeferner/node-java/pull/187#event-219030763 |
| https://github.com/jimlloyd |
| jimlloyd | https://github.com/jimlloyd |
|
Mar 13, 2015
| https://github.com/joeferner/node-java/pull/187#ref-pullrequest-61244303 |
|
Feature/enhance node java async options 90115432
#198
| https://github.com/joeferner/node-java/pull/198 |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F187 |
| Please reload this page | https://github.com/joeferner/node-java/pull/187 |
| Please reload this page | https://github.com/joeferner/node-java/pull/187 |
|
| https://github.com/jimlloyd |
|
| https://github.com/joeferner |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |