René's URL Explorer Experiment


Title: First rough draft of adding support for promises. by jimlloyd · Pull Request #181 · joeferner/node-java · GitHub

Open Graph Title: First rough draft of adding support for promises. by jimlloyd · Pull Request #181 · joeferner/node-java

X Title: First rough draft of adding support for promises. by jimlloyd · Pull Request #181 · joeferner/node-java

Description: @joeferner: Hi Joe, I managed to get something working for Issue #180. This only promisifies the instance methods of the imported java classes, but adding support for static methods and promisifying the Java module itself is probably trivial in comparison. Please review the changes in java.cpp and javaObject.cpp carefully. This implementation was almost blind trial and error without really trying to understand v8 and NAN. In particular I haven't tried to study how to properly handle garbage collection so I may have made mistakes there. TODO: More tests. Promisify static methods of Java classes. Promisify the various async methods of the Java module (newInstance, callMethod, callStaticMethod, etc.)

Open Graph Description: @joeferner: Hi Joe, I managed to get something working for Issue #180. This only promisifies the instance methods of the imported java classes, but adding support for static methods and promisifyin...

X Description: @joeferner: Hi Joe, I managed to get something working for Issue #180. This only promisifies the instance methods of the imported java classes, but adding support for static methods and promisifyin...

Opengraph URL: https://github.com/joeferner/node-java/pull/181

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7479cd71-0a2a-2ac0-4c7e-764d528bc4bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DA6:1C6B09:C7AF3:111CCB:6AFD4AAA
html-safe-noncec267c1106e71bc3c256c8278e59d9953711d756af4955b993b253e801318458e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REE2OjFDNkIwOTpDN0FGMzoxMTFDQ0I6NkFGRDRBQUEiLCJ2aXNpdG9yX2lkIjoiMTk1ODAzNTQyMTIxMjI2NTEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacea8df64c24f3e5248bb14ddfed95c154ae1d392f28e849a658ebdfe1eefae686
hovercard-subject-tagpull_request:26926474
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/181/files
twitter:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
og:image:alt@joeferner: Hi Joe, I managed to get something working for Issue #180. This only promisifies the instance methods of the imported java classes, but adding support for static methods and promisifyin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/joeferner/node-java git https://github.com/joeferner/node-java.git
octolytics-dimension-user_id808857
octolytics-dimension-user_loginjoeferner
octolytics-dimension-repository_id3228734
octolytics-dimension-repository_nwojoeferner/node-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3228734
octolytics-dimension-repository_network_root_nwojoeferner/node-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/joeferner/node-java/pull/181/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F181%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F181%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java
Reloadhttps://github.com/joeferner/node-java/pull/181/files
Reloadhttps://github.com/joeferner/node-java/pull/181/files
Reloadhttps://github.com/joeferner/node-java/pull/181/files
joefernerhttps://github.com/joeferner
node-javahttps://github.com/joeferner/node-java
Codehttps://github.com/joeferner/node-java
Issues208 (208)https://github.com/joeferner/node-java/issues
Pull requests2 (2)https://github.com/joeferner/node-java/pulls
Actionshttps://github.com/joeferner/node-java/actions
Projectshttps://github.com/joeferner/node-java/projects
Wikihttps://github.com/joeferner/node-java/wiki
Security and qualityhttps://github.com/joeferner/node-java/security
Insightshttps://github.com/joeferner/node-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
jimlloydhttps://github.com/jimlloyd
joeferner:masterhttps://github.com/joeferner/node-java/tree/master
jimlloyd:feature/promiseshttps://github.com/jimlloyd/node-java/tree/feature/promises
Conversation 13 https://github.com/joeferner/node-java/pull/181
Commits 12 https://github.com/joeferner/node-java/pull/181/commits
Checks 0 https://github.com/joeferner/node-java/pull/181/checks
Files changed https://github.com/joeferner/node-java/pull/181/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/181/files
First rough draft of adding support for promises. https://github.com/joeferner/node-java/pull/181/files#top
Show all changes 12 commits https://github.com/joeferner/node-java/pull/181/files
6a6aa25 First rough draft of adding support for promises. jimlloyd Jan 6, 2015 https://github.com/joeferner/node-java/pull/181/commits/6a6aa255f9b590e09f7167c03f325a16bf7b7f25
35556d8 Fix build on node 0.11. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/181/commits/35556d876a12bceb0d0f888aa8c01d3bfde79f43
02a66a7 Use when instead of bluebird for compatiblity with node 0.8. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/181/commits/02a66a7209d3e3e5a8995ebe01569de0ad0b6fe8
2d50f13 Promisify java class static methods on import. jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/181/commits/2d50f13b871e22e8dfcf9c080c8ca36d48c4cd63
0c24d61 SetAccessor to prohibit overwriting of asyncOptions, and some other r… jimlloyd Jan 7, 2015 https://github.com/joeferner/node-java/pull/181/commits/0c24d6102c5e0d65b524ad30e8c5128760354c27
ec21cc8 Assert if promisfy doesn't return a function. Use 'promiseSuffix' ins… jimlloyd Jan 8, 2015 https://github.com/joeferner/node-java/pull/181/commits/ec21cc80cdaeeae4ff6f01b60eee198593d9190f
8ed3b12 Promisify three async methods of Java module. jimlloyd Jan 8, 2015 https://github.com/joeferner/node-java/pull/181/commits/8ed3b12a2115dd13721a8f2977ce8cce2417222a
812c665 Document promises in the README.md. jimlloyd Jan 9, 2015 https://github.com/joeferner/node-java/pull/181/commits/812c6651631b9986a3dda20041de98a32a6f9e63
79a6b2f Document in testHelpers.js the tested promises implementations. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/181/commits/79a6b2f3529fdf3aa9b15cce4523565624ec2227
6b4e403 Add promises test with many chained .then() calls. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/181/commits/6b4e403ddef5dab59fdb0b7f8dcf50abe1f54e38
eb27f78 Add promises test using when's ability to pass promises to function a… jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/181/commits/eb27f78c416338b48fa2953fbd4c0e5030e8c4f7
15084ca Try alternate test in attempt to pass with java 6. jimlloyd Jan 13, 2015 https://github.com/joeferner/node-java/pull/181/commits/15084ca101a7c75b449d6b7e23fbab1d9d8a007f
Clear filters https://github.com/joeferner/node-java/pull/181/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/181/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/181/files
README.md https://github.com/joeferner/node-java/pull/181/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
nodeJavaBridge.js https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
package.json https://github.com/joeferner/node-java/pull/181/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
java.cpp https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
java.h https://github.com/joeferner/node-java/pull/181/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
javaObject.cpp https://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
promises-test.js https://github.com/joeferner/node-java/pull/181/files#diff-e8b6b9cb875655c9638548e1c0da5ff116dce07e8e3d8e4ed7015af164715ee3
testHelpers.js https://github.com/joeferner/node-java/pull/181/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
README.mdhttps://github.com/joeferner/node-java/pull/181/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/joeferner/node-java/pull/181/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
lib/nodeJavaBridge.jshttps://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/lib/nodeJavaBridge.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
https://github.com/joeferner/node-java/pull/181/files#diff-e1a279534c5ab26f37647444def8a8d1e8ed82bbe5b79001567c4fde9b0ef3df
package.jsonhttps://github.com/joeferner/node-java/pull/181/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/joeferner/node-java/pull/181/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/java.cpphttps://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/src/java.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/181/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
src/java.hhttps://github.com/joeferner/node-java/pull/181/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/src/java.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
src/javaObject.cpphttps://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
View file https://github.com/jimlloyd/node-java/blob/15084ca101a7c75b449d6b7e23fbab1d9d8a007f/src/javaObject.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/181/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
https://github.com/joeferner/node-java/pull/181/files#diff-0460d77bc2930741487ed0ba3d16c5e5d3fd304d7c7d09e5370c96652e45d7de
Please reload this pagehttps://github.com/joeferner/node-java/pull/181/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.