René's URL Explorer Experiment


Title: Experimental hacks to use JDK8. Not backward compatible with JDK6. by jimlloyd · Pull Request #164 · joeferner/node-java · GitHub

Open Graph Title: Experimental hacks to use JDK8. Not backward compatible with JDK6. by jimlloyd · Pull Request #164 · joeferner/node-java

X Title: Experimental hacks to use JDK8. Not backward compatible with JDK6. by jimlloyd · Pull Request #164 · joeferner/node-java

Description: FOR REVIEW ONLY. DO NOT MERGE TO MASTER. These changes seem to be sufficient to make JDK8 work. This module's unit tests pass, and I have evidence that gremlin-node now accepts references to classes that were compiled for Java 8. We now have to figure out how to maintain backward compatibility for JDK6. Perhaps we can simply detect which JDK is installed in JAVA_HOME and compile for it? This is tested only on my Mac with OS 10.9.5, and with jdk1.8.0_25. The commit comment says "mac only", but the only iffy thing I did was change compile-java-code.sh to use ${JAVA_HOME} instead of /opt/jdk1.6.0_45, which I think should improve compatibility across platforms.

Open Graph Description: FOR REVIEW ONLY. DO NOT MERGE TO MASTER. These changes seem to be sufficient to make JDK8 work. This module's unit tests pass, and I have evidence that gremlin-node now accepts references to cl...

X Description: FOR REVIEW ONLY. DO NOT MERGE TO MASTER. These changes seem to be sufficient to make JDK8 work. This module's unit tests pass, and I have evidence that gremlin-node now accepts references t...

Opengraph URL: https://github.com/joeferner/node-java/pull/164

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:db665b76-7c55-00aa-ac63-9bfab5cf5924
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83A8:DF88E:14A6E0:1C2EAD:6AFD4D35
html-safe-noncebe7e077537e2ac86bb6c1de9bc5f76bf5eab8b250fa4948222a5fb4d65a73db4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0E4OkRGODhFOjE0QTZFMDoxQzJFQUQ6NkFGRDREMzUiLCJ2aXNpdG9yX2lkIjoiNTIwMjg4ODI2NzQ5MTc3MTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd1271d9cf0efd9f6c19729377254fda960a5458973d7b2a30feccf10d5a3d7ec
hovercard-subject-tagpull_request:22941422
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/164/files
twitter:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/18069?s=400&v=4
og:image:altFOR REVIEW ONLY. DO NOT MERGE TO MASTER. These changes seem to be sufficient to make JDK8 work. This module's unit tests pass, and I have evidence that gremlin-node now accepts references to cl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/joeferner/node-java git https://github.com/joeferner/node-java.git
octolytics-dimension-user_id808857
octolytics-dimension-user_loginjoeferner
octolytics-dimension-repository_id3228734
octolytics-dimension-repository_nwojoeferner/node-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3228734
octolytics-dimension-repository_network_root_nwojoeferner/node-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb6f01f7cb9f35f8c09949773241a3d49dd04b340
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/joeferner/node-java/pull/164/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F164%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F164%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java
Reloadhttps://github.com/joeferner/node-java/pull/164/files
Reloadhttps://github.com/joeferner/node-java/pull/164/files
Reloadhttps://github.com/joeferner/node-java/pull/164/files
joefernerhttps://github.com/joeferner
node-javahttps://github.com/joeferner/node-java
Codehttps://github.com/joeferner/node-java
Issues208 (208)https://github.com/joeferner/node-java/issues
Pull requests2 (2)https://github.com/joeferner/node-java/pulls
Actionshttps://github.com/joeferner/node-java/actions
Projectshttps://github.com/joeferner/node-java/projects
Wikihttps://github.com/joeferner/node-java/wiki
Security and qualityhttps://github.com/joeferner/node-java/security
Insightshttps://github.com/joeferner/node-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose
jimlloydhttps://github.com/jimlloyd
joeferner:masterhttps://github.com/joeferner/node-java/tree/master
jimlloyd:feature/jdk8-on-macosxhttps://github.com/jimlloyd/node-java/tree/feature/jdk8-on-macosx
Conversation 9 https://github.com/joeferner/node-java/pull/164
Commits 8 https://github.com/joeferner/node-java/pull/164/commits
Checks 0 https://github.com/joeferner/node-java/pull/164/checks
Files changed https://github.com/joeferner/node-java/pull/164/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/164/files
Experimental hacks to use JDK8. Not backward compatible with JDK6. https://github.com/joeferner/node-java/pull/164/files#top
Show all changes 8 commits https://github.com/joeferner/node-java/pull/164/files
398fe0d Experimental hacks to use JDK8. Mac only, no backward compatibity for… jimlloyd Oct 17, 2014 https://github.com/joeferner/node-java/pull/164/commits/398fe0dd06870bab4ad8877a3e1085443ab2f713
51f7548 Somewhat better way to support jdk1.8. jimlloyd Oct 17, 2014 https://github.com/joeferner/node-java/pull/164/commits/51f75482408dc74a99eaf3b479e184ec066eeaeb
9537d91 Try specifying jdk versions in .travis.yml jimlloyd Oct 17, 2014 https://github.com/joeferner/node-java/pull/164/commits/9537d9154dabeddc31b5a51dc1f883852ee72903
e367f4c Try specifing language:java in addition to language:node_js. jimlloyd Oct 17, 2014 https://github.com/joeferner/node-java/pull/164/commits/e367f4cc5c2b02cf9da784e296dd99d245ffe464
0ee560e Restore .travis.yml. No more experimentation with it on this branch. jimlloyd Oct 17, 2014 https://github.com/joeferner/node-java/pull/164/commits/0ee560ead42946df755d9f44aa9b31886abb859a
7fae226 Revert compile-java-code.sh back to version in master. jimlloyd Oct 20, 2014 https://github.com/joeferner/node-java/pull/164/commits/7fae226dcd3cc81f93e851e3e56a267089c9b09e
004b2fa Add compile-java8-code.sh and test for java8. jimlloyd Oct 20, 2014 https://github.com/joeferner/node-java/pull/164/commits/004b2fade5e4b00670dfcbdda4b20515a4819f53
a9584e0 Simplify Java8 test & handle Unsupported major.minor vers exception. jimlloyd Oct 20, 2014 https://github.com/joeferner/node-java/pull/164/commits/a9584e03269921ceff4cb33b897ecf0de245c527
Clear filters https://github.com/joeferner/node-java/pull/164/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/164/files
Please reload this pagehttps://github.com/joeferner/node-java/pull/164/files
compile-java8-code.sh https://github.com/joeferner/node-java/pull/164/files#diff-11727668b914a7a8962c66e9afbb394841a14aa4584f595879e08c68394b1cde
package.json https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
java.cpp https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
java.h https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
utils.cpp https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317
TestLambda$IntegerMath.class https://github.com/joeferner/node-java/pull/164/files#diff-2e5510e01fd5b0971c7a41c158388568ecaf46477142715703a8573dad4357ed
TestLambda.class https://github.com/joeferner/node-java/pull/164/files#diff-fbc4381d938b7223a8e9bb7b6cfc1d864905482b7957ee5f03414b70ae889151
TestLambda.java https://github.com/joeferner/node-java/pull/164/files#diff-69531502e44697205d7bf00c368c22b63fbbffb2a0bb46311ffd67a3ec801ba5
testLambda.js https://github.com/joeferner/node-java/pull/164/files#diff-71b585cc58b910e6e78f3e3465d6a0351f333d199aca2a11c021a05c8dbdb19a
testHelpers.js https://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
compile-java8-code.shhttps://github.com/joeferner/node-java/pull/164/files#diff-11727668b914a7a8962c66e9afbb394841a14aa4584f595879e08c68394b1cde
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/compile-java8-code.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
package.jsonhttps://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
src/java.cpphttps://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/java.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351
src/java.hhttps://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/java.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc
src/utils.cpphttps://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/utils.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317
https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317
test8/TestLambda$IntegerMath.classhttps://github.com/joeferner/node-java/pull/164/files#diff-2e5510e01fd5b0971c7a41c158388568ecaf46477142715703a8573dad4357ed
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda%24IntegerMath.class
Open in desktop https://desktop.github.com
test8/TestLambda.classhttps://github.com/joeferner/node-java/pull/164/files#diff-fbc4381d938b7223a8e9bb7b6cfc1d864905482b7957ee5f03414b70ae889151
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda.class
Open in desktop https://desktop.github.com
test8/TestLambda.javahttps://github.com/joeferner/node-java/pull/164/files#diff-69531502e44697205d7bf00c368c22b63fbbffb2a0bb46311ffd67a3ec801ba5
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
test8/testLambda.jshttps://github.com/joeferner/node-java/pull/164/files#diff-71b585cc58b910e6e78f3e3465d6a0351f333d199aca2a11c021a05c8dbdb19a
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/testLambda.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
testHelpers.jshttps://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
View file https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/testHelpers.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }}
https://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.