| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:db665b76-7c55-00aa-ac63-9bfab5cf5924 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 83A8:DF88E:14A6E0:1C2EAD:6AFD4D35 |
| html-safe-nonce | be7e077537e2ac86bb6c1de9bc5f76bf5eab8b250fa4948222a5fb4d65a73db4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0E4OkRGODhFOjE0QTZFMDoxQzJFQUQ6NkFGRDREMzUiLCJ2aXNpdG9yX2lkIjoiNTIwMjg4ODI2NzQ5MTc3MTQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d1271d9cf0efd9f6c19729377254fda960a5458973d7b2a30feccf10d5a3d7ec |
| hovercard-subject-tag | pull_request:22941422 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/joeferner/node-java/pull/164/files |
| twitter:image | https://avatars.githubusercontent.com/u/18069?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/18069?s=400&v=4 |
| og:image:alt | FOR REVIEW ONLY. DO NOT MERGE TO MASTER.
These changes seem to be sufficient to make JDK8 work.
This module's unit tests pass, and I have evidence that gremlin-node
now accepts references to cl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 66653c2e55a6fff2930be1bdf07ee4f8aa137e3956d056c822563be6f878755e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/joeferner/node-java git https://github.com/joeferner/node-java.git |
| octolytics-dimension-user_id | 808857 |
| octolytics-dimension-user_login | joeferner |
| octolytics-dimension-repository_id | 3228734 |
| octolytics-dimension-repository_nwo | joeferner/node-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3228734 |
| octolytics-dimension-repository_network_root_nwo | joeferner/node-java |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b6f01f7cb9f35f8c09949773241a3d49dd04b340 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/joeferner/node-java/pull/164/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F164%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjoeferner%2Fnode-java%2Fpull%2F164%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=joeferner%2Fnode-java |
| Reload | https://github.com/joeferner/node-java/pull/164/files |
| Reload | https://github.com/joeferner/node-java/pull/164/files |
| Reload | https://github.com/joeferner/node-java/pull/164/files |
| joeferner | https://github.com/joeferner |
| node-java | https://github.com/joeferner/node-java |
| Code | https://github.com/joeferner/node-java |
| Issues208 (208) | https://github.com/joeferner/node-java/issues |
| Pull requests2 (2) | https://github.com/joeferner/node-java/pulls |
| Actions | https://github.com/joeferner/node-java/actions |
| Projects | https://github.com/joeferner/node-java/projects |
| Wiki | https://github.com/joeferner/node-java/wiki |
| Security and quality | https://github.com/joeferner/node-java/security |
| Insights | https://github.com/joeferner/node-java/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fjoeferner%2Fnode-java%2Fissues%2Fnew%2Fchoose |
| jimlloyd | https://github.com/jimlloyd |
| joeferner:master | https://github.com/joeferner/node-java/tree/master |
| jimlloyd:feature/jdk8-on-macosx | https://github.com/jimlloyd/node-java/tree/feature/jdk8-on-macosx |
|
Conversation
9
| https://github.com/joeferner/node-java/pull/164 |
|
Commits
8
| https://github.com/joeferner/node-java/pull/164/commits |
|
Checks
0
| https://github.com/joeferner/node-java/pull/164/checks |
|
Files changed
| https://github.com/joeferner/node-java/pull/164/files |
| Please reload this page | https://github.com/joeferner/node-java/pull/164/files |
|
Experimental hacks to use JDK8. Not backward compatible with JDK6.
| https://github.com/joeferner/node-java/pull/164/files#top |
|
Show all changes
8 commits
| https://github.com/joeferner/node-java/pull/164/files |
|
398fe0d
Experimental hacks to use JDK8. Mac only, no backward compatibity for…
jimlloyd Oct 17, 2014
| https://github.com/joeferner/node-java/pull/164/commits/398fe0dd06870bab4ad8877a3e1085443ab2f713 |
|
51f7548
Somewhat better way to support jdk1.8.
jimlloyd Oct 17, 2014
| https://github.com/joeferner/node-java/pull/164/commits/51f75482408dc74a99eaf3b479e184ec066eeaeb |
|
9537d91
Try specifying jdk versions in .travis.yml
jimlloyd Oct 17, 2014
| https://github.com/joeferner/node-java/pull/164/commits/9537d9154dabeddc31b5a51dc1f883852ee72903 |
|
e367f4c
Try specifing language:java in addition to language:node_js.
jimlloyd Oct 17, 2014
| https://github.com/joeferner/node-java/pull/164/commits/e367f4cc5c2b02cf9da784e296dd99d245ffe464 |
|
0ee560e
Restore .travis.yml. No more experimentation with it on this branch.
jimlloyd Oct 17, 2014
| https://github.com/joeferner/node-java/pull/164/commits/0ee560ead42946df755d9f44aa9b31886abb859a |
|
7fae226
Revert compile-java-code.sh back to version in master.
jimlloyd Oct 20, 2014
| https://github.com/joeferner/node-java/pull/164/commits/7fae226dcd3cc81f93e851e3e56a267089c9b09e |
|
004b2fa
Add compile-java8-code.sh and test for java8.
jimlloyd Oct 20, 2014
| https://github.com/joeferner/node-java/pull/164/commits/004b2fade5e4b00670dfcbdda4b20515a4819f53 |
|
a9584e0
Simplify Java8 test & handle Unsupported major.minor vers exception.
jimlloyd Oct 20, 2014
| https://github.com/joeferner/node-java/pull/164/commits/a9584e03269921ceff4cb33b897ecf0de245c527 |
|
Clear filters
| https://github.com/joeferner/node-java/pull/164/files |
| Please reload this page | https://github.com/joeferner/node-java/pull/164/files |
| Please reload this page | https://github.com/joeferner/node-java/pull/164/files |
|
compile-java8-code.sh
| https://github.com/joeferner/node-java/pull/164/files#diff-11727668b914a7a8962c66e9afbb394841a14aa4584f595879e08c68394b1cde |
|
package.json
| https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
java.cpp
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
java.h
| https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc |
|
utils.cpp
| https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317 |
|
TestLambda$IntegerMath.class
| https://github.com/joeferner/node-java/pull/164/files#diff-2e5510e01fd5b0971c7a41c158388568ecaf46477142715703a8573dad4357ed |
|
TestLambda.class
| https://github.com/joeferner/node-java/pull/164/files#diff-fbc4381d938b7223a8e9bb7b6cfc1d864905482b7957ee5f03414b70ae889151 |
|
TestLambda.java
| https://github.com/joeferner/node-java/pull/164/files#diff-69531502e44697205d7bf00c368c22b63fbbffb2a0bb46311ffd67a3ec801ba5 |
|
testLambda.js
| https://github.com/joeferner/node-java/pull/164/files#diff-71b585cc58b910e6e78f3e3465d6a0351f333d199aca2a11c021a05c8dbdb19a |
|
testHelpers.js
| https://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a |
| compile-java8-code.sh | https://github.com/joeferner/node-java/pull/164/files#diff-11727668b914a7a8962c66e9afbb394841a14aa4584f595879e08c68394b1cde |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/compile-java8-code.sh |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
| package.json | https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/package.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| src/java.cpp | https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/java.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-f6b9ee79ea1d44dfe4843f5dbe4bb419c606ed6149363eba02a562aaf0285351 |
| src/java.h | https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/java.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-24168236c32bfa773830f939117602c559c065a4c958e4e31b6f608aa0dcf3bc |
| src/utils.cpp | https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317 |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/src/utils.cpp |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317 |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-e5786da510ae17c4e629faa5583e79a5f37636702844b066763fba287aa44317 |
| test8/TestLambda$IntegerMath.class | https://github.com/joeferner/node-java/pull/164/files#diff-2e5510e01fd5b0971c7a41c158388568ecaf46477142715703a8573dad4357ed |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda%24IntegerMath.class |
|
Open in desktop
| https://desktop.github.com |
| test8/TestLambda.class | https://github.com/joeferner/node-java/pull/164/files#diff-fbc4381d938b7223a8e9bb7b6cfc1d864905482b7957ee5f03414b70ae889151 |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda.class |
|
Open in desktop
| https://desktop.github.com |
| test8/TestLambda.java | https://github.com/joeferner/node-java/pull/164/files#diff-69531502e44697205d7bf00c368c22b63fbbffb2a0bb46311ffd67a3ec801ba5 |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/TestLambda.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
| test8/testLambda.js | https://github.com/joeferner/node-java/pull/164/files#diff-71b585cc58b910e6e78f3e3465d6a0351f333d199aca2a11c021a05c8dbdb19a |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/test8/testLambda.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
| testHelpers.js | https://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a |
|
View file
| https://github.com/jimlloyd/node-java/blob/a9584e03269921ceff4cb33b897ecf0de245c527/testHelpers.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/joeferner/node-java/pull/164/{{ revealButtonHref }} |
|
| https://github.com/joeferner/node-java/pull/164/files#diff-20384a99ceabcd949f3416e58b108d960c360ae55f4ba73f3f9897c2a187468a |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |