Title: Pull Requests/Merge to master · Issue #306 · javaee-samples/javaee7-samples · GitHub
Open Graph Title: Pull Requests/Merge to master · Issue #306 · javaee-samples/javaee7-samples
X Title: Pull Requests/Merge to master · Issue #306 · javaee-samples/javaee7-samples
Description: Hi guys, I understand we gave up on rebase approach and we do merge from GitHub. Fine with me. I'm just wondering why do we merge PR which leads to failing build? Such approach has a risk of introducing lots of issues to the whole projec...
Open Graph Description: Hi guys, I understand we gave up on rebase approach and we do merge from GitHub. Fine with me. I'm just wondering why do we merge PR which leads to failing build? Such approach has a risk of introd...
X Description: Hi guys, I understand we gave up on rebase approach and we do merge from GitHub. Fine with me. I'm just wondering why do we merge PR which leads to failing build? Such approach has a risk of in...
Mail addresses
notifications@github.com
notifications@github.com
Opengraph URL: https://github.com/javaee-samples/javaee7-samples/issues/306
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Pull Requests/Merge to master","articleBody":"Hi guys,\n\nI understand we gave up on rebase approach and we do `merge` from GitHub. Fine with me.\n\nI'm just wondering why do we merge PR which leads to failing build? Such approach has a risk of introducing lots of issues to the whole project because we are missing an opportunity to validate it.\n\nI assume a PR is at least executed on local env of the approver before hitting a magic button, isn't it?\n","author":{"url":"https://github.com/bartoszmajsak","@type":"Person","name":"bartoszmajsak"},"datePublished":"2015-05-26T14:58:46Z","url":"https://github.com/javaee-samples/javaee7-samples/issues/306"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:339a86d9-09b2-9476-39e7-cecce4fb9562 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9A4E:2F543F:122A98D:180CDA8:6B01E906 |
| html-safe-nonce | 74e80e0328ae315421da0bcc52805a875f5ea5490779dd57bf354ec0042e0d1b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTRFOjJGNTQzRjoxMjJBOThEOjE4MENEQTg6NkIwMUU5MDYiLCJ2aXNpdG9yX2lkIjoiODc0MTQwNjkwNjIzMDM2ODUxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b324bb3c7d28c1373e8d857bd787419c02d4fa15745eecdaeb09a0a1510a1d21 |
| hovercard-subject-tag | issue:81000633 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/javaee-samples/javaee7-samples/306/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3c4a8c64783a0503ce2d07889b8d95d7ecfa4068f799e1029f472fd9a2402233/javaee-samples/javaee7-samples/issues/306 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c4a8c64783a0503ce2d07889b8d95d7ecfa4068f799e1029f472fd9a2402233/javaee-samples/javaee7-samples/issues/306 |
| og:image:alt | Hi guys, I understand we gave up on rebase approach and we do merge from GitHub. Fine with me. I'm just wondering why do we merge PR which leads to failing build? Such approach has a risk of introd... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bartoszmajsak |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/javaee-samples/javaee7-samples git https://github.com/javaee-samples/javaee7-samples.git |
| octolytics-dimension-user_id | 6052086 |
| octolytics-dimension-user_login | javaee-samples |
| octolytics-dimension-repository_id | 12414592 |
| octolytics-dimension-repository_nwo | javaee-samples/javaee7-samples |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 12414592 |
| octolytics-dimension-repository_network_root_nwo | javaee-samples/javaee7-samples |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width