René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"UnifiedDiffReader.parseUnifiedDiff(): Using unified diff with no prefix in file names leads to cut file names in some cases.","articleBody":"**Describe the bug**\r\nWhen using an unified diff with no a/, b/ prefix in file names as input for UnifiedDiffReader.parseUnifiedDiff(), extracted file names are cut when they start with one of a, b, old new. This seems to be due to this piece of code:\r\n```\r\nreturn line.substring(4).replaceFirst(\"^(a|b|old|new)(\\\\/)?\", \"\")\r\n                .trim();\r\n```\r\nwhich is located at UnifiedDiffReader::356 in a method called `extractFileName`.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Example data: Use an unified diff that contains at least one file whose name starts with \"a\", \"b\", \"old\" or \"new\".\r\nFor example:\r\n```\r\n--- a.txt\r\n+++ a1.txt\r\n@@ -8,7 +8,7 @@\r\n     \u003cSetting\u003e\r\n         \u003cSetting a\u003e\r\n             \u003csetting b\u003e\r\n-                \u003cvalue\u003e23\u003c/value\u003e\r\n+                \u003cvalue\u003e24\u003c/value\u003e\r\n             \u003c/setting b\u003e\r\n             \u003csetting c\u003e\r\n                 \u003cvalue\u003e1\u003c/value\u003e\r\n```\r\n2. simple program snippet\r\n```\r\nval diff = \"\"\"\r\n        --- a.txt\r\n        +++ a1.txt\r\n        @@ -8,7 +8,7 @@\r\n             \u003cSetting\u003e\r\n                 \u003cSetting a\u003e\r\n                     \u003csetting b\u003e\r\n        -                \u003cvalue\u003e23\u003c/value\u003e\r\n        +                \u003cvalue\u003e24\u003c/value\u003e\r\n                     \u003c/setting b\u003e\r\n                     \u003csetting c\u003e\r\n                         \u003cvalue\u003e1\u003c/value\u003e\r\n    \"\"\".trimIndent()\r\nval unifiedDiff = UnifiedDiffReader.parseUnifiedDiff(diff.byteInputStream())\r\nunifiedDiff.files.forEach { unifiedDiffFile -\u003e\r\n                println(unifiedDiffFile.fromFile)\r\n                println(unifiedDiffFile.toFile)\r\n}\r\n```\r\n3. See error\r\n\r\nThis snipet prints:\r\n```\r\n.txt\r\n1.txt\r\n```\r\n**Expected behavior**\r\nThe snippet should print:\r\n```\r\na.txt\r\na1.txt\r\n```\r\n\r\n**System**\r\n - Java version 11\r\n - Version 4.11\r\n","author":{"url":"https://github.com/IgnacioGarcia198","@type":"Person","name":"IgnacioGarcia198"},"datePublished":"2022-01-11T09:09:38.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/141/java-diff-utils/issues/141"}