| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f110da48-c806-ed9b-0f67-2f39e78b452a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A1E6:87739:43412D:5F1906:696A15C7 |
| html-safe-nonce | eac41f892360e129e3a83d7b6a49bf2c86ff673d19149d77e7b07389972e66e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUU2Ojg3NzM5OjQzNDEyRDo1RjE5MDY6Njk2QTE1QzciLCJ2aXNpdG9yX2lkIjoiMTQxODk0Mzk4NTMyNDAwNDgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8b2d2a1c87a701c2e2673ba258e626317aa14c721338fa6f3c09aba0faa1d7ae |
| hovercard-subject-tag | pull_request:322643937 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/jasync-sql/jasync-sql/157/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/574448d5dbd5a3eb55ac23afbc2738654f4688cb4ddde47bce06157ee0026975/jasync-sql/jasync-sql/pull/157 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/574448d5dbd5a3eb55ac23afbc2738654f4688cb4ddde47bce06157ee0026975/jasync-sql/jasync-sql/pull/157 |
| og:image:alt | I don't want a dependency on JodaTime for my projects, so I decided to start fixing #131
TODO:
[x] Common library
[x] MySQL
[x] Fix TimestampEncoder
[ ] Fix MySQL tests
[] Postgres
[] Fix Postg... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bakatz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923 |
| turbo-cache-control | no-preview |
| go-import | github.com/jasync-sql/jasync-sql git https://github.com/jasync-sql/jasync-sql.git |
| octolytics-dimension-user_id | 42655245 |
| octolytics-dimension-user_login | jasync-sql |
| octolytics-dimension-repository_id | 145898133 |
| octolytics-dimension-repository_nwo | jasync-sql/jasync-sql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 145898133 |
| octolytics-dimension-repository_network_root_nwo | jasync-sql/jasync-sql |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e8bd37502700f365b18a4d39acf7cb7947e11b1a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/jasync-sql/jasync-sql/pull/157#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjasync-sql%2Fjasync-sql%2Fpull%2F157 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjasync-sql%2Fjasync-sql%2Fpull%2F157 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=jasync-sql%2Fjasync-sql |
| Reload | https://github.com/jasync-sql/jasync-sql/pull/157 |
| Reload | https://github.com/jasync-sql/jasync-sql/pull/157 |
| Reload | https://github.com/jasync-sql/jasync-sql/pull/157 |
|
jasync-sql
| https://github.com/jasync-sql |
| jasync-sql | https://github.com/jasync-sql/jasync-sql |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
|
Notifications
| https://github.com/login?return_to=%2Fjasync-sql%2Fjasync-sql |
|
Fork
139
| https://github.com/login?return_to=%2Fjasync-sql%2Fjasync-sql |
|
Star
1.7k
| https://github.com/login?return_to=%2Fjasync-sql%2Fjasync-sql |
|
Code
| https://github.com/jasync-sql/jasync-sql |
|
Issues
15
| https://github.com/jasync-sql/jasync-sql/issues |
|
Pull requests
2
| https://github.com/jasync-sql/jasync-sql/pulls |
|
Discussions
| https://github.com/jasync-sql/jasync-sql/discussions |
|
Actions
| https://github.com/jasync-sql/jasync-sql/actions |
|
Wiki
| https://github.com/jasync-sql/jasync-sql/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/jasync-sql/jasync-sql/security |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
|
Insights
| https://github.com/jasync-sql/jasync-sql/pulse |
|
Code
| https://github.com/jasync-sql/jasync-sql |
|
Issues
| https://github.com/jasync-sql/jasync-sql/issues |
|
Pull requests
| https://github.com/jasync-sql/jasync-sql/pulls |
|
Discussions
| https://github.com/jasync-sql/jasync-sql/discussions |
|
Actions
| https://github.com/jasync-sql/jasync-sql/actions |
|
Wiki
| https://github.com/jasync-sql/jasync-sql/wiki |
|
Security
| https://github.com/jasync-sql/jasync-sql/security |
|
Insights
| https://github.com/jasync-sql/jasync-sql/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fjasync-sql%2Fjasync-sql%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fjasync-sql%2Fjasync-sql%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/jasync-sql/jasync-sql/pull/157#issue-comment-box |
| bakatz | https://github.com/bakatz |
| jasync-sql:master | https://github.com/jasync-sql/jasync-sql/tree/master |
| bakatz:master | https://github.com/bakatz/jasync-sql/tree/master |
|
[WIP] Removes JodaTime
| https://github.com/jasync-sql/jasync-sql/pull/157#top |
| bakatz | https://github.com/bakatz |
| jasync-sql:master | https://github.com/jasync-sql/jasync-sql/tree/master |
| bakatz:master | https://github.com/bakatz/jasync-sql/tree/master |
|
Conversation
11
| https://github.com/jasync-sql/jasync-sql/pull/157 |
|
Commits
10
| https://github.com/jasync-sql/jasync-sql/pull/157/commits |
|
Checks
0
| https://github.com/jasync-sql/jasync-sql/pull/157/checks |
|
Files changed
| https://github.com/jasync-sql/jasync-sql/pull/157/files |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.co/hiddenchars |
| https://github.com/jasync-sql/jasync-sql/pull/{{ revealButtonHref }} |
|
| https://github.com/bakatz |
| bakatz | https://github.com/bakatz |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issue-500107896 |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| #131 | https://github.com/jasync-sql/jasync-sql/issues/131 |
| https://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html | https://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| bakatz | https://github.com/bakatz |
| September 29, 2019 23:29 | https://github.com/jasync-sql/jasync-sql/pull/157#commits-pushed-cbdd227 |
|
| https://github.com/bakatz |
| Removes all jodatime references in the common library, cleans up | https://github.com/jasync-sql/jasync-sql/pull/157/commits/cbdd227eb3cb9812bc41782cca52f1b8b4403705 |
| cbdd227 | https://github.com/jasync-sql/jasync-sql/pull/157/commits/cbdd227eb3cb9812bc41782cca52f1b8b4403705 |
|
| https://github.com/bakatz |
| Removes jodatime references from the mysql driver | https://github.com/jasync-sql/jasync-sql/pull/157/commits/4f667ab1459f33a801c71e3affabf5f7987c6581 |
| 4f667ab | https://github.com/jasync-sql/jasync-sql/pull/157/commits/4f667ab1459f33a801c71e3affabf5f7987c6581 |
|
| https://github.com/bakatz |
| Reverts build.gradle change | https://github.com/jasync-sql/jasync-sql/pull/157/commits/2cfe6d0a3eaa4dcdb7f5507fd70a5934eab5f4da |
| 2cfe6d0 | https://github.com/jasync-sql/jasync-sql/pull/157/commits/2cfe6d0a3eaa4dcdb7f5507fd70a5934eab5f4da |
|
| https://github.com/bakatz |
| Removes commented code | https://github.com/jasync-sql/jasync-sql/pull/157/commits/4669abe325a0e9e062b3379644ab6c642a1d5f5b |
| 4669abe | https://github.com/jasync-sql/jasync-sql/pull/157/commits/4669abe325a0e9e062b3379644ab6c642a1d5f5b |
|
| https://github.com/bakatz |
| Fixes millis conversion | https://github.com/jasync-sql/jasync-sql/pull/157/commits/3d49bc484fc1b22f3e824226cd27ccd5e2f027a0 |
| 3d49bc4 | https://github.com/jasync-sql/jasync-sql/pull/157/commits/3d49bc484fc1b22f3e824226cd27ccd5e2f027a0 |
|
| https://github.com/bakatz |
| Fixes more ns calculations | https://github.com/jasync-sql/jasync-sql/pull/157/commits/9e7abec44218b5be647565052bf2e3ec19b4fac1 |
| 9e7abec | https://github.com/jasync-sql/jasync-sql/pull/157/commits/9e7abec44218b5be647565052bf2e3ec19b4fac1 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-536458672 |
| #131 | https://github.com/jasync-sql/jasync-sql/issues/131 |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/bakatz |
| bakatz | https://github.com/bakatz |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-536697613 |
| @oshai | https://github.com/oshai |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/bakatz |
| bakatz | https://github.com/bakatz |
|
Sep 30, 2019
| https://github.com/jasync-sql/jasync-sql/pull/157#pullrequestreview-295220400 |
|
View reviewed changes
| https://github.com/jasync-sql/jasync-sql/pull/157/files/9e7abec44218b5be647565052bf2e3ec19b4fac1 |
| db-async-common/src/main/java/com/github/jasync/sql/db/column/InetAddressEncoderDecoder.kt | https://github.com/jasync-sql/jasync-sql/pull/157/files/9e7abec44218b5be647565052bf2e3ec19b4fac1#diff-e9aafd740251f19a2662ff3a00b9b49ca8fd99e0280ab71ccb7ec8d51f7105f3 |
| bakatz | https://github.com/bakatz |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#discussion_r329763103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| oshai | https://github.com/oshai |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#discussion_r329765828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| bakatz | https://github.com/bakatz |
| Sep 30, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#discussion_r329766413 |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| bakatz | https://github.com/bakatz |
| October 6, 2019 22:54 | https://github.com/jasync-sql/jasync-sql/pull/157#commits-pushed-9315653 |
|
| https://github.com/bakatz |
| Fixes TimestampEncoderDecoder to use ZonedDateTime to allow for the '… | https://github.com/jasync-sql/jasync-sql/pull/157/commits/9315653a5280e8a0af0b55873018d8ac1ad6ac3e |
| 9315653 | https://github.com/jasync-sql/jasync-sql/pull/157/commits/9315653a5280e8a0af0b55873018d8ac1ad6ac3e |
|
| https://github.com/bakatz |
| Corrects milliseconds value in test | https://github.com/jasync-sql/jasync-sql/pull/157/commits/84e583affed72d8f833a546595a4ba4151ed36ba |
| 84e583a | https://github.com/jasync-sql/jasync-sql/pull/157/commits/84e583affed72d8f833a546595a4ba4151ed36ba |
|
| https://github.com/bakatz |
| ~temp logging to try to debug why the test is failing | https://github.com/jasync-sql/jasync-sql/pull/157/commits/0fab1378dda0e16a3d6ca31db2356feb47dcd868 |
| 0fab137 | https://github.com/jasync-sql/jasync-sql/pull/157/commits/0fab1378dda0e16a3d6ca31db2356feb47dcd868 |
|
| https://github.com/bakatz |
| ~changes test log level to info to avoid log spam | https://github.com/jasync-sql/jasync-sql/pull/157/commits/e43ac6c0dd6133cda4d0ceaa0292188b43018394 |
| e43ac6c | https://github.com/jasync-sql/jasync-sql/pull/157/commits/e43ac6c0dd6133cda4d0ceaa0292188b43018394 |
| https://github.com/bakatz |
| bakatz | https://github.com/bakatz |
| Oct 8, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-539320993 |
| @oshai | https://github.com/oshai |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
| Oct 8, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-539347073 |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
| Dec 22, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-568239749 |
| @bakatz | https://github.com/bakatz |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/bakatz |
| bakatz | https://github.com/bakatz |
| Dec 22, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-568239812 |
| @oshai | https://github.com/oshai |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
| Dec 22, 2019 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-568240065 |
| @bakatz | https://github.com/bakatz |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 14, 2020 | https://github.com/jasync-sql/jasync-sql/pull/157#issuecomment-628308468 |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
no-pr-activity
| https://github.com/jasync-sql/jasync-sql/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| May 14, 2020 | https://github.com/jasync-sql/jasync-sql/pull/157#event-3334333713 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 21, 2020 | https://github.com/jasync-sql/jasync-sql/pull/157#event-3358754715 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
|
Sep 6, 2020
| https://github.com/jasync-sql/jasync-sql/pull/157#ref-issue-462372784 |
|
remove joda-time dependency
#131
| https://github.com/jasync-sql/jasync-sql/issues/131 |
| https://github.com/oshai |
| oshai | https://github.com/oshai |
|
May 30, 2021
| https://github.com/jasync-sql/jasync-sql/pull/157#ref-pullrequest-906137191 |
|
Switch to JSR 310 Date and Time API
#233
| https://github.com/jasync-sql/jasync-sql/pull/233 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fjasync-sql%2Fjasync-sql%2Fpull%2F157 |
|
| https://github.com/oshai |
|
oshai
| https://github.com/oshai |
|
| https://github.com/jasync-sql/jasync-sql/pull/157/files/9e7abec44218b5be647565052bf2e3ec19b4fac1 |
|
no-pr-activity
| https://github.com/jasync-sql/jasync-sql/issues?q=state%3Aopen%20label%3Ano-pr-activity |
| Please reload this page | https://github.com/jasync-sql/jasync-sql/pull/157 |
|
| https://github.com/bakatz |
|
| https://github.com/oshai |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |