René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"SSL Mode support for MySQL","articleBody":"Hello!\r\n\r\n**I would like to ask if there's a plan to support `sslMode` configuration for MySQL database?** According to FAQ, currently, only PostgreSQL is supported. I also noticed that `com.github.jasync.sql.db.SSLConfiguration` defaults to `sslMode=disabled` mode for MySQL which leads to problems when the MySQL Server is configured to enforce SSL connections.\r\n\r\nI had a look at the implementation details and found that this library integrates with R2DBC SPI (https://r2dbc.io/spec/0.8.1.RELEASE/spec/html/#overview.connection.discovery). The driver will be discovered by R2DBC SPI which will use `com.github.jasync.r2dbc.mysql.MysqlConnectionFactoryProvider#create` to create `io.r2dbc.spi.ConnectionFactory` object:\r\n```kotlin\r\n// from: com.github.jasync.r2dbc.mysql.MysqlConnectionFactoryProvider#create\r\n@Suppress(\"NULLABILITY_MISMATCH_BASED_ON_JAVA_ANNOTATIONS\")\r\noverride fun create(connectionFactoryOptions: ConnectionFactoryOptions): JasyncConnectionFactory {\r\n    val configuration = Configuration(\r\n        host = connectionFactoryOptions.getValue(HOST),\r\n        port = connectionFactoryOptions.getValue(PORT),\r\n        username = connectionFactoryOptions.getValue(USER),\r\n        password = connectionFactoryOptions.getValue(PASSWORD)?.toString(),\r\n        database = connectionFactoryOptions.getValue(DATABASE),\r\n        applicationName = connectionFactoryOptions.getValue(APPLICATION_NAME),\r\n        connectionTimeout = connectionFactoryOptions.getValue(CONNECT_TIMEOUT)?.toMillis()?.toInt() ?: 5000,\r\n        queryTimeout = connectionFactoryOptions.getValue(QUERY_TIMEOUT)\r\n    )\r\n    return JasyncConnectionFactory(MySQLConnectionFactory(configuration))\r\n}\r\n```\r\nThe above method does not configure `com.github.jasync.sql.db.SSLConfiguration` and thus, the default `sslMode` (`Mode.Disable`) will be used. Even though, the `connectionFactoryOptions` could have the option `ssl` set to `true` or any `sslMode` parameter specified.\r\n\r\nI suspect that changing this factory to interpret the `ssl` and `sslMode` parameter of `connectionFactoryOptions` would quickly resolve the issue. It seems that `com.github.jasync.sql.db.mysql.MySQLConnection#onHandshake` already supports SSL.\r\n\r\n**I would be happy to contribute and resolve this issue**. But first I would like to make sure:\r\n - Is my understanding of current implementation described above correct?\r\n - The ssl option in `connectionFactoryOptions` would return true in case the secure protocol (`r2dbcs`) is used. However how should it handle the combination of secure protocol and `sslMode=disabled`, for example through the following connection string:  `r2dbcs:mysql://example.com?sslMode=disabled`?\r\n - Should my contribution also support other MySQL parameters. If so, would anyone be able to specify which? I know there are legacy parameters like  'useSSL', 'requireSSL', and 'verifyServerCertificate' which are still accepted but translated into a value for 'sslMode' by MySQL Server. The `com.github.jasync.sql.db.SSLConfiguration` also accepts `sslrootcert`, `sslcert`, `sslkey`.\r\n\r\nThanks!\r\n\r\n","author":{"url":"https://github.com/tkurylek","@type":"Person","name":"tkurylek"},"datePublished":"2022-12-05T07:49:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/337/jasync-sql/issues/337"}