René's URL Explorer Experiment


Title: Exit terminal interface gracefully on signals by takluyver · Pull Request #10185 · ipython/ipython · GitHub

Open Graph Title: Exit terminal interface gracefully on signals by takluyver · Pull Request #10185 · ipython/ipython

X Title: Exit terminal interface gracefully on signals by takluyver · Pull Request #10185 · ipython/ipython

Description: Closes gh-9944 This sets signal handlers for SIGTERM and SIGHUP while the prompt_toolkit prompt is active, letting it clean up the terminal before the process exits. When the prompt is not active, we restore the previous signals. This can't work (as far as I know) if other code has set signal handlers at the C level. I don't think this is likely to come up often, but there's a new config option catch_signals=False which users can set to disable our manipulation of signal handlers.

Open Graph Description: Closes gh-9944 This sets signal handlers for SIGTERM and SIGHUP while the prompt_toolkit prompt is active, letting it clean up the terminal before the process exits. When the prompt is not active, ...

X Description: Closes gh-9944 This sets signal handlers for SIGTERM and SIGHUP while the prompt_toolkit prompt is active, letting it clean up the terminal before the process exits. When the prompt is not active, ...

Opengraph URL: https://github.com/ipython/ipython/pull/10185

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c89a814f-4f11-d4e6-1aea-6b7ebe45f272
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC644:20AD09:27D4AA8:3857020:6A4CED68
html-safe-nonce4f07dac4a1ff69b5aa118064d48cf4bf4da45757e52e7b766c7bf61bc9edd3e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjQ0OjIwQUQwOToyN0Q0QUE4OjM4NTcwMjA6NkE0Q0VENjgiLCJ2aXNpdG9yX2lkIjoiODU0MjMzNzMxOTUzMjU1NTYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac479e1e84c3a7422b42c98d4776f341f28ff5fe9f3645c1332b7c5aa27ee602ff
hovercard-subject-tagpull_request:102262719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/ipython/ipython/pull/10185/files
twitter:imagehttps://avatars.githubusercontent.com/u/327925?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/327925?s=400&v=4
og:image:altCloses gh-9944 This sets signal handlers for SIGTERM and SIGHUP while the prompt_toolkit prompt is active, letting it clean up the terminal before the process exits. When the prompt is not active, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/ipython/ipython git https://github.com/ipython/ipython.git
octolytics-dimension-user_id230453
octolytics-dimension-user_loginipython
octolytics-dimension-repository_id658518
octolytics-dimension-repository_nwoipython/ipython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id658518
octolytics-dimension-repository_network_root_nwoipython/ipython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseefec6750a5afcaeaf5dfcf629f404cf98c8371e3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ipython/ipython/pull/10185/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipython%2Fipython%2Fpull%2F10185%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipython%2Fipython%2Fpull%2F10185%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=ipython%2Fipython
Reloadhttps://github.com/ipython/ipython/pull/10185/files
Reloadhttps://github.com/ipython/ipython/pull/10185/files
Reloadhttps://github.com/ipython/ipython/pull/10185/files
Please reload this pagehttps://github.com/ipython/ipython/pull/10185/files
ipython https://github.com/ipython
ipythonhttps://github.com/ipython/ipython
Please reload this pagehttps://github.com/ipython/ipython/pull/10185/files
Notifications https://github.com/login?return_to=%2Fipython%2Fipython
Fork 4.5k https://github.com/login?return_to=%2Fipython%2Fipython
Star 16.7k https://github.com/login?return_to=%2Fipython%2Fipython
Code https://github.com/ipython/ipython
Issues 1.3k https://github.com/ipython/ipython/issues
Pull requests 31 https://github.com/ipython/ipython/pulls
Actions https://github.com/ipython/ipython/actions
Projects https://github.com/ipython/ipython/projects
Wiki https://github.com/ipython/ipython/wiki
Security and quality 2 https://github.com/ipython/ipython/security
Insights https://github.com/ipython/ipython/pulse
Code https://github.com/ipython/ipython
Issues https://github.com/ipython/ipython/issues
Pull requests https://github.com/ipython/ipython/pulls
Actions https://github.com/ipython/ipython/actions
Projects https://github.com/ipython/ipython/projects
Wiki https://github.com/ipython/ipython/wiki
Security and quality https://github.com/ipython/ipython/security
Insights https://github.com/ipython/ipython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fipython%2Fipython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fipython%2Fipython%2Fissues%2Fnew%2Fchoose
takluyverhttps://github.com/takluyver
ipython:masterhttps://github.com/ipython/ipython/tree/master
takluyver:signal-cleanuphttps://github.com/takluyver/ipython/tree/signal-cleanup
Conversation 17 https://github.com/ipython/ipython/pull/10185
Commits 3 https://github.com/ipython/ipython/pull/10185/commits
Checks 0 https://github.com/ipython/ipython/pull/10185/checks
Files changed 2 https://github.com/ipython/ipython/pull/10185/files
Exit terminal interface gracefully on signals https://github.com/ipython/ipython/pull/10185/files#top
Show all changes 3 commits https://github.com/ipython/ipython/pull/10185/files
49c20c5 Exit terminal interface gracefully on signals takluyver Jan 19, 2017 https://github.com/ipython/ipython/pull/10185/commits/49c20c59c4e3e22bf1f861460880c74cade98345
0328424 Only use signal names on POSIX takluyver Jan 19, 2017 https://github.com/ipython/ipython/pull/10185/commits/0328424089d27024af91707fda2e01a59c74d340
2be9a90 Add an entry in what's new Carreau Jan 27, 2017 https://github.com/ipython/ipython/pull/10185/commits/2be9a90baaa0943f81ae1a1a10fad899b48a59bb
Clear filters https://github.com/ipython/ipython/pull/10185/files
Please reload this pagehttps://github.com/ipython/ipython/pull/10185/files
Please reload this pagehttps://github.com/ipython/ipython/pull/10185/files
interactiveshell.py https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
version5.rst https://github.com/ipython/ipython/pull/10185/files#diff-a563769c556c9b0e77ebac2f164c1d37da4826e2742568c8cddd76ff5b659f00
IPython/terminal/interactiveshell.pyhttps://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
View file https://github.com/takluyver/ipython/blob/2be9a90baaa0943f81ae1a1a10fad899b48a59bb/IPython/terminal/interactiveshell.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipython/ipython/pull/10185/{{ revealButtonHref }}
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
https://github.com/ipython/ipython/pull/10185/files#diff-197d80c7c0926c7b340c4e36c857f9f1dbc5aa9c259dd912dd04424763752838
docs/source/whatsnew/version5.rsthttps://github.com/ipython/ipython/pull/10185/files#diff-a563769c556c9b0e77ebac2f164c1d37da4826e2742568c8cddd76ff5b659f00
View file https://github.com/takluyver/ipython/blob/2be9a90baaa0943f81ae1a1a10fad899b48a59bb/docs/source/whatsnew/version5.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipython/ipython/pull/10185/{{ revealButtonHref }}
https://github.com/ipython/ipython/pull/10185/files#diff-a563769c556c9b0e77ebac2f164c1d37da4826e2742568c8cddd76ff5b659f00
https://github.com/ipython/ipython/pull/10185/files#diff-a563769c556c9b0e77ebac2f164c1d37da4826e2742568c8cddd76ff5b659f00
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.