René's URL Explorer Experiment


Title: Fix issues found during the connection-reuse review by jonathan-kosgei · Pull Request #36 · ipdata/python · GitHub

Open Graph Title: Fix issues found during the connection-reuse review by jonathan-kosgei · Pull Request #36 · ipdata/python

X Title: Fix issues found during the connection-reuse review by jonathan-kosgei · Pull Request #36 · ipdata/python

Description: Summary Fixes the items recorded under "Noticed, not changed" in #35: bulk() given a set, DotDict dot access to a list of scalars, the CLI batch --exclude crash, missing threat columns in the batch CSV output, a wrong flag in the README batch example, two live tests that compared a value with itself, and the CI workflow's Node 20 actions and 2022 Python pin. No version number changes and no breaking changes to the public API. Changes bulk() accepts a set of resources: the resources are sent as a JSON list, so a set no longer fails with IPDataException("... Object of type set is not JSON serializable"). (ac32091) DotDict: dot access to a list of scalars (data.x when x == [1, 2, 3]) returns the list instead of raising TypeError; only dict elements are wrapped, so data.threat.blocklists[0].name works as before. (7ce7d14) CLI: ipdata batch -e works instead of raising UnboundLocalError; the remaining fields are requested in sorted order so that CSV columns are stable, and --format CSV --exclude is accepted (CSV output needs either --fields or --exclude). (017c61e) CLI: batch CSV output gains the threat_is_vpn and threat_scores columns, which were dropped from the rows before; the blocklist dates are part of each entry in the existing threat_blocklists column. (3504289) README: the batch CSV example uses --format CSV (the command has no --output-format option) and the text names --exclude as the alternative to --fields. (924985c) Live tests: test_bulk_v4 and test_bulk_v6 compare the returned IPs with the requested ones (case-insensitively for IPv6) instead of comparing each requested IP with itself. (9d42f29) CI: actions/checkout@v7 and actions/setup-python@v7 (Node 24) replace the Node 20 @v4 and @v5; Python 3.14 joins the test matrix and the classifiers; the publish job uses Python 3.13 instead of the pinned 3.10.4 and installs build without --user. Its steps, tag gate and runner image are otherwise unchanged. (07ec54d) Not changed Per-call timeout for lookup() / bulk(): a new feature rather than a defect; the constructor timeout applies to every request, bulk lookups included. The 100 hypothesis examples per live test: a cost/coverage trade-off on the live API quota for the maintainers to decide; the assertions themselves are fixed above. Verification python -m pytest -m "not api" (Python 3.13.18, package installed in editable mode, requests not installed): 94 passed, 4 deselected (87 passed, 4 deselected on master; the 7 new tests cover each behaviour change). The single warning is a DeprecationWarning raised by click_default_group when the CLI module is imported and predates this branch. The same command under Python 3.9.25 and 3.14.6 (virtualenvs built from requirements.txt, package not installed): 94 passed, 4 deselected each. python -m pytest -m api --collect-only: the four live tests still collect. They are not run here (they need IPDATA_API_KEY and run on pushes to master). ast.parse(source, feature_version=(3, 9)) on every changed module: OK. The workflow parses as YAML with the expected matrix, action versions and publish Python version. CI: run https://github.com/ipdata/python/actions/runs/41639769512 on 07ec54d (pull_request event): success. Test (Python 3.9), 3.10, 3.11, 3.12, 3.13 and 3.14 all passed python -m pytest -m "not api" on ubuntu-24.04 with actions/checkout@v7 and actions/setup-python@v7; Build and publish to PyPI was skipped on the pull request, as intended. 🤖 Generated with Claude Code

Open Graph Description: Summary Fixes the items recorded under "Noticed, not changed" in #35: bulk() given a set, DotDict dot access to a list of scalars, the CLI batch --exclude crash, missing threat columns in...

X Description: Summary Fixes the items recorded under "Noticed, not changed" in #35: bulk() given a set, DotDict dot access to a list of scalars, the CLI batch --exclude crash, missing threat co...

Opengraph URL: https://github.com/ipdata/python/pull/36

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eec5e8e8-4e9a-49af-7136-dfe8298952e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD6D0:3C21B:35FFAC5:450C9CF:6B01DBA4
html-safe-nonce006759854a19ecf13bfdaeff375eef19fc17b6804295f250f23d12bd92f8431e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkQwOjNDMjFCOjM1RkZBQzU6NDUwQzlDRjo2QjAxREJBNCIsInZpc2l0b3JfaWQiOiI0NDg4MTY3ODUwMzI1OTU3NTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacffcb0993374ba6f9e90aae4669adf424e374bdbdd5b70a8cac7d5f754f491c93
hovercard-subject-tagpull_request:5137578569
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/ipdata/python/pull/36/files
twitter:imagehttps://avatars.githubusercontent.com/u/6712914?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6712914?s=400&v=4
og:image:altSummary Fixes the items recorded under "Noticed, not changed" in #35: bulk() given a set, DotDict dot access to a list of scalars, the CLI batch --exclude crash, missing threat columns in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/ipdata/python git https://github.com/ipdata/python.git
octolytics-dimension-user_id33085067
octolytics-dimension-user_loginipdata
octolytics-dimension-repository_id108238848
octolytics-dimension-repository_nwoipdata/python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id108238848
octolytics-dimension-repository_network_root_nwoipdata/python
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ipdata/python/pull/36/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipdata%2Fpython%2Fpull%2F36%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fipdata%2Fpython%2Fpull%2F36%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=ipdata%2Fpython
Reloadhttps://github.com/ipdata/python/pull/36/files
Reloadhttps://github.com/ipdata/python/pull/36/files
Reloadhttps://github.com/ipdata/python/pull/36/files
ipdatahttps://github.com/ipdata
pythonhttps://github.com/ipdata/python
Codehttps://github.com/ipdata/python
Issues2 (2)https://github.com/ipdata/python/issues
Pull requestshttps://github.com/ipdata/python/pulls
Actionshttps://github.com/ipdata/python/actions
Projectshttps://github.com/ipdata/python/projects
Security and qualityhttps://github.com/ipdata/python/security
Insightshttps://github.com/ipdata/python/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fipdata%2Fpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fipdata%2Fpython%2Fissues%2Fnew%2Fchoose
jonathan-kosgeihttps://github.com/jonathan-kosgei
masterhttps://github.com/ipdata/python/tree/master
fix-noticed-issueshttps://github.com/ipdata/python/tree/fix-noticed-issues
Conversation 0 https://github.com/ipdata/python/pull/36
Commits 7 https://github.com/ipdata/python/pull/36/commits
Checks 7 https://github.com/ipdata/python/pull/36/checks
Files changed https://github.com/ipdata/python/pull/36/files
Please reload this pagehttps://github.com/ipdata/python/pull/36/files
Fix issues found during the connection-reuse review https://github.com/ipdata/python/pull/36/files#top
Show all changes 7 commits https://github.com/ipdata/python/pull/36/files
ac32091 Fix bulk() lookups given a set of resources claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/ac32091110c68c60c564fdda35e22314d6eb394e
7ce7d14 Keep non-dict list items as they are in DotDict attribute access claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/7ce7d149ebe9193c632f836fa0f69e3d08ae5ba9
017c61e Fix the CLI batch --exclude option claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/017c61e7a466cb7cc50be599c253b43736a45d9a
3504289 Add is_vpn and scores to the CLI batch CSV threat columns claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/350428914ae60128fd242a8fce6c819547cf4054
924985c Fix the --format flag in the README batch CSV example claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/924985c5f4a272267cb43a18978726ce6bc6d73c
9d42f29 Compare the requested and returned IPs in the live bulk tests claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/9d42f29d30ab97c75771332d47d542da91484d59
07ec54d Update the CI actions, test on Python 3.14 and move the publish job t… claude Nov 3, 2026 https://github.com/ipdata/python/pull/36/commits/07ec54d9245ccd4d75df64762a179e5d1ea24b5f
Clear filters https://github.com/ipdata/python/pull/36/files
Please reload this pagehttps://github.com/ipdata/python/pull/36/files
Please reload this pagehttps://github.com/ipdata/python/pull/36/files
python-publish.yml https://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
README.md https://github.com/ipdata/python/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
setup.cfg https://github.com/ipdata/python/pull/36/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
cli.py https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
ipdata.py https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
test_cli.py https://github.com/ipdata/python/pull/36/files#diff-76951082f0634aef4e8efc12911c3c14976cf65fbd11d4f7623b719f8832062c
test_client.py https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
test_ipdata.py https://github.com/ipdata/python/pull/36/files#diff-d791d8560405abe220e048b0dae0a1765ea763d0819f3416cbf6d3d3416ef987
.github/workflows/python-publish.ymlhttps://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/.github/workflows/python-publish.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
https://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
https://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
https://github.com/ipdata/python/pull/36/files#diff-87c8be2ac3b248aef84cc474af838d7cc461b7f8fb7f5444ac75f4d8fc02e377
README.mdhttps://github.com/ipdata/python/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/ipdata/python/pull/36/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
setup.cfghttps://github.com/ipdata/python/pull/36/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/setup.cfg
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
https://github.com/ipdata/python/pull/36/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
src/ipdata/cli.pyhttps://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/src/ipdata/cli.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
https://github.com/ipdata/python/pull/36/files#diff-3f5b5d469b33b98e8d490c6f37a5799df1a41c2b3c8becf536f9f644a482a50b
src/ipdata/ipdata.pyhttps://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/src/ipdata/ipdata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
https://github.com/ipdata/python/pull/36/files#diff-bf65736b7a1e0d96bb4b2413398d39d0d96a323bea4089a402cae23f3c469b74
src/ipdata/test_cli.pyhttps://github.com/ipdata/python/pull/36/files#diff-76951082f0634aef4e8efc12911c3c14976cf65fbd11d4f7623b719f8832062c
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/src/ipdata/test_cli.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
src/ipdata/test_client.pyhttps://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/src/ipdata/test_client.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
https://github.com/ipdata/python/pull/36/files#diff-f596a1efdfabe46829b1629098995bfd80e3dea2f183007e07f3df26fa0e58de
src/ipdata/test_ipdata.pyhttps://github.com/ipdata/python/pull/36/files#diff-d791d8560405abe220e048b0dae0a1765ea763d0819f3416cbf6d3d3416ef987
View file https://github.com/ipdata/python/blob/07ec54d9245ccd4d75df64762a179e5d1ea24b5f/src/ipdata/test_ipdata.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/ipdata/python/pull/36/{{ revealButtonHref }}
https://github.com/ipdata/python/pull/36/files#diff-d791d8560405abe220e048b0dae0a1765ea763d0819f3416cbf6d3d3416ef987
https://github.com/ipdata/python/pull/36/files#diff-d791d8560405abe220e048b0dae0a1765ea763d0819f3416cbf6d3d3416ef987
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.