René's URL Explorer Experiment


Title: fix(vue): tabs no longer get unmounted when navigating back to a tabs context by sean-perkins · Pull Request #24337 · ionic-team/ionic-framework · GitHub

Open Graph Title: fix(vue): tabs no longer get unmounted when navigating back to a tabs context by sean-perkins · Pull Request #24337 · ionic-team/ionic-framework

X Title: fix(vue): tabs no longer get unmounted when navigating back to a tabs context by sean-perkins · Pull Request #24337 · ionic-team/ionic-framework

Description: A powerful cross-platform UI toolkit for building native-quality iOS, Android, and Progressive Web Apps with HTML, CSS, and JavaScript. - fix(vue): tabs no longer get unmounted when navigating back to a tabs context by sean-perkins · Pull Request #24337 · ionic-team/ionic-framework

Open Graph Description: Pull request checklist Please check if your PR fulfills the following requirements: Tests for the changes have been added (for bug fixes / features) Docs have been reviewed and added / updated i...

X Description: Pull request checklist Please check if your PR fulfills the following requirements: Tests for the changes have been added (for bug fixes / features) Docs have been reviewed and added / updated i...

Opengraph URL: https://github.com/ionic-team/ionic-framework/pull/24337

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cf113f09-58f6-e2c2-4840-eddd53c50659
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA860:35E4E2:702641:97B436:6A5EE155
html-safe-nonceeddfa48cb712b6483e7ae1a33606731343af26e8783358dd9a56155ea5a2c1ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODYwOjM1RTRFMjo3MDI2NDE6OTdCNDM2OjZBNUVFMTU1IiwidmlzaXRvcl9pZCI6IjY4NjEyMDMwOTc0MzQxMjA1MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1d80327d7a23485b444e9c050a4ed766b261e5e7c3f1cc946729cfc7f74c4313
hovercard-subject-tagpull_request:796548675
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ionic-team/ionic-framework/24337/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e153929f5f24d4361f222a57a0da3fce7c88d33057f9e07540ad99bbc14b0e91/ionic-team/ionic-framework/pull/24337
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e153929f5f24d4361f222a57a0da3fce7c88d33057f9e07540ad99bbc14b0e91/ionic-team/ionic-framework/pull/24337
og:image:altPull request checklist Please check if your PR fulfills the following requirements: Tests for the changes have been added (for bug fixes / features) Docs have been reviewed and added / updated i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesean-perkins
hostnamegithub.com
expected-hostnamegithub.com
None82d0004a35927bdb00c652a57f456c55aa0eda4ade1bc7956d7510fdea6e454b
turbo-cache-controlno-cache
go-importgithub.com/ionic-team/ionic-framework git https://github.com/ionic-team/ionic-framework.git
octolytics-dimension-user_id3171503
octolytics-dimension-user_loginionic-team
octolytics-dimension-repository_id12256376
octolytics-dimension-repository_nwoionic-team/ionic-framework
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id12256376
octolytics-dimension-repository_network_root_nwoionic-team/ionic-framework
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released2d913dd727d2d7ac189fb4d05b10bc34ecd03ee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/ionic-team/ionic-framework/pull/24337#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fionic-team%2Fionic-framework%2Fpull%2F24337
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fionic-team%2Fionic-framework%2Fpull%2F24337
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ionic-team%2Fionic-framework
Reloadhttps://github.com/ionic-team/ionic-framework/pull/24337
Reloadhttps://github.com/ionic-team/ionic-framework/pull/24337
Reloadhttps://github.com/ionic-team/ionic-framework/pull/24337
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
ionic-team https://github.com/ionic-team
ionic-frameworkhttps://github.com/ionic-team/ionic-framework
Notifications https://github.com/login?return_to=%2Fionic-team%2Fionic-framework
Fork 13.3k https://github.com/login?return_to=%2Fionic-team%2Fionic-framework
Star 52.6k https://github.com/login?return_to=%2Fionic-team%2Fionic-framework
Code https://github.com/ionic-team/ionic-framework
Issues 592 https://github.com/ionic-team/ionic-framework/issues
Pull requests 36 https://github.com/ionic-team/ionic-framework/pulls
Discussions https://github.com/ionic-team/ionic-framework/discussions
Actions https://github.com/ionic-team/ionic-framework/actions
Projects https://github.com/ionic-team/ionic-framework/projects
Wiki https://github.com/ionic-team/ionic-framework/wiki
Security and quality 0 https://github.com/ionic-team/ionic-framework/security
Insights https://github.com/ionic-team/ionic-framework/pulse
Code https://github.com/ionic-team/ionic-framework
Issues https://github.com/ionic-team/ionic-framework/issues
Pull requests https://github.com/ionic-team/ionic-framework/pulls
Discussions https://github.com/ionic-team/ionic-framework/discussions
Actions https://github.com/ionic-team/ionic-framework/actions
Projects https://github.com/ionic-team/ionic-framework/projects
Wiki https://github.com/ionic-team/ionic-framework/wiki
Security and quality https://github.com/ionic-team/ionic-framework/security
Insights https://github.com/ionic-team/ionic-framework/pulse
liamdebeasihttps://github.com/liamdebeasi
mainhttps://github.com/ionic-team/ionic-framework/tree/main
FW-402https://github.com/ionic-team/ionic-framework/tree/FW-402
Conversationhttps://github.com/ionic-team/ionic-framework/pull/24337
Commits3 (3)https://github.com/ionic-team/ionic-framework/pull/24337/commits
Checkshttps://github.com/ionic-team/ionic-framework/pull/24337/checks
Files changedhttps://github.com/ionic-team/ionic-framework/pull/24337/files
fix(vue): tabs no longer get unmounted when navigating back to a tabs contexthttps://github.com/ionic-team/ionic-framework/pull/24337#top
liamdebeasihttps://github.com/liamdebeasi
mainhttps://github.com/ionic-team/ionic-framework/tree/main
FW-402https://github.com/ionic-team/ionic-framework/tree/FW-402
https://github.com/sean-perkins
sean-perkinshttps://github.com/sean-perkins
Dec 7, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issue-1072918165
#24332https://github.com/ionic-team/ionic-framework/issues/24332
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
package: vue https://github.com/ionic-team/ionic-framework/issues?q=state%3Aopen%20label%3A%22package%3A%20vue%22
Dec 7, 2021https://github.com/ionic-team/ionic-framework/pull/24337#event-5724942772
https://github.com/sean-perkins
sean-perkinshttps://github.com/sean-perkins
liamdebeasihttps://github.com/liamdebeasi
December 7, 2021 05:20https://github.com/ionic-team/ionic-framework/pull/24337#event-5724988925
https://github.com/sean-perkins
sean-perkinshttps://github.com/sean-perkins
Dec 7, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issuecomment-987580061
@liamdebeasihttps://github.com/liamdebeasi
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 7, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#pullrequestreview-825394707
View reviewed changes https://github.com/ionic-team/ionic-framework/pull/24337/files
liamdebeasihttps://github.com/liamdebeasi
https://github.com/ionic-team/ionic-framework/pull/24337#pullrequestreview-825394707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 7, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issuecomment-988012759
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonRouterOutlet.ts#L79-L84https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonRouterOutlet.ts#L79-L84
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 7, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issuecomment-988031970
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 8, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issuecomment-988926247
https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonRouterOutlet.ts#L83https://github.com/ionic-team/ionic-framework/blob/main/packages/vue/src/components/IonRouterOutlet.ts#L83
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/sean-perkins
sean-perkinshttps://github.com/sean-perkins
Dec 8, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#ref-issue-1074436499
bug: ion-tabs routing between tabs is slow #24346 https://github.com/ionic-team/ionic-framework/issues/24346
liamdebeasihttps://github.com/liamdebeasi
December 9, 2021 15:47https://github.com/ionic-team/ionic-framework/pull/24337#commits-pushed-c4f3780
https://github.com/liamdebeasi
fix(vue): do not unmount old tab when navigating back to tabs contexthttps://github.com/ionic-team/ionic-framework/pull/24337/commits/c4f3780c9d8abf59e894fd5ad695f07162275019
c4f3780https://github.com/ionic-team/ionic-framework/pull/24337/commits/c4f3780c9d8abf59e894fd5ad695f07162275019
https://github.com/liamdebeasi
chore(): move fix down for better coveragehttps://github.com/ionic-team/ionic-framework/pull/24337/commits/86b63c846041593fe250d0e591e27574626be1da
86b63c8https://github.com/ionic-team/ionic-framework/pull/24337/commits/86b63c846041593fe250d0e591e27574626be1da
https://github.com/liamdebeasi
fix(): add undefined checkhttps://github.com/ionic-team/ionic-framework/pull/24337/commits/ef6eb07fbc9677d83786f60f816c97577a3bc935
ef6eb07https://github.com/ionic-team/ionic-framework/pull/24337/commits/ef6eb07fbc9677d83786f60f816c97577a3bc935
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
force-pushedhttps://github.com/ionic-team/ionic-framework/compare/4a5cd0bb461c1d8d16a6a7cc0b1594428f496041..ef6eb07fbc9677d83786f60f816c97577a3bc935
4a5cd0bhttps://github.com/ionic-team/ionic-framework/commit/4a5cd0bb461c1d8d16a6a7cc0b1594428f496041
ef6eb07https://github.com/ionic-team/ionic-framework/commit/ef6eb07fbc9677d83786f60f816c97577a3bc935
Compare https://github.com/ionic-team/ionic-framework/compare/4a5cd0bb461c1d8d16a6a7cc0b1594428f496041..ef6eb07fbc9677d83786f60f816c97577a3bc935
December 9, 2021 16:33https://github.com/ionic-team/ionic-framework/pull/24337#event-5742100783
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 9, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#pullrequestreview-827925264
View reviewed changes https://github.com/ionic-team/ionic-framework/pull/24337/files/ef6eb07fbc9677d83786f60f816c97577a3bc935
packages/vue/test-app/tests/e2e/specs/tabs.jshttps://github.com/ionic-team/ionic-framework/pull/24337/files/ef6eb07fbc9677d83786f60f816c97577a3bc935#diff-97ddfcaa4d05dae2e5fbdf93fd26a9d595f10ecd1e6cb21f905b8fe73f3a422b
liamdebeasihttps://github.com/liamdebeasi
Dec 9, 2021https://github.com/ionic-team/ionic-framework/pull/24337#discussion_r765960775
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 9, 2021https://github.com/ionic-team/ionic-framework/pull/24337#event-5742107385
https://github.com/sean-perkins
sean-perkinshttps://github.com/sean-perkins
Dec 14, 2021https://github.com/ionic-team/ionic-framework/pull/24337#issuecomment-993705481
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
averyrousseauhttps://github.com/averyrousseau
December 14, 2021 16:18https://github.com/ionic-team/ionic-framework/pull/24337#event-5765384784
https://github.com/averyrousseau
averyrousseauhttps://github.com/averyrousseau
Dec 14, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#pullrequestreview-831985116
View reviewed changes https://github.com/ionic-team/ionic-framework/pull/24337/files/ef6eb07fbc9677d83786f60f816c97577a3bc935
averyrousseauhttps://github.com/averyrousseau
https://github.com/ionic-team/ionic-framework/pull/24337#pullrequestreview-831985116
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
bf8e436https://github.com/ionic-team/ionic-framework/commit/bf8e436ee3f7441ebbc7eaf53ec8d04545dab476
Dec 15, 2021https://github.com/ionic-team/ionic-framework/pull/24337#event-5771899442
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
December 15, 2021 14:50https://github.com/ionic-team/ionic-framework/pull/24337#event-5771899741
https://github.com/liamdebeasi
liamdebeasihttps://github.com/liamdebeasi
Dec 15, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#ref-issue-1072655754
bug: vue, undefined error when leaving tabs and coming back #24332 https://github.com/ionic-team/ionic-framework/issues/24332
liamdebeasihttps://github.com/liamdebeasi
Dec 15, 2021 https://github.com/ionic-team/ionic-framework/pull/24337#ref-commit-4aab72b
https://github.com/sean-perkins
https://github.com/liamdebeasi
fix(vue): tabs no longer get unmounted when navigating back to a tabs…https://github.com/ionic-team/ionic-framework/commit/4aab72b06159729d2dcd18b2ef0b76f693e5a74e
4aab72bhttps://github.com/ionic-team/ionic-framework/commit/4aab72b06159729d2dcd18b2ef0b76f693e5a74e
#24337https://github.com/ionic-team/ionic-framework/pull/24337
#24332https://github.com/ionic-team/ionic-framework/issues/24332
build(deps): bump @ionic/core from 5.6.11 to 6.0.1 numbersprotocol/capture-cam#1152 https://github.com/numbersprotocol/capture-cam/pull/1152
build(deps): bump @ionic/angular from 5.6.11 to 6.0.1 numbersprotocol/capture-cam#1145 https://github.com/numbersprotocol/capture-cam/pull/1145
https://github.co/hiddenchars
https://github.com/ionic-team/ionic-framework/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fionic-team%2Fionic-framework%2Fpull%2F24337
https://github.com/liamdebeasi
liamdebeasi https://github.com/liamdebeasi
https://github.com/ionic-team/ionic-framework/pull/24337/files/ef6eb07fbc9677d83786f60f816c97577a3bc935
https://github.com/averyrousseau
averyrousseau https://github.com/averyrousseau
https://github.com/ionic-team/ionic-framework/pull/24337/files/ef6eb07fbc9677d83786f60f816c97577a3bc935
package: vue https://github.com/ionic-team/ionic-framework/issues?q=state%3Aopen%20label%3A%22package%3A%20vue%22
bug: vue, undefined error when leaving tabs and coming back https://github.com/ionic-team/ionic-framework/issues/24332
Please reload this pagehttps://github.com/ionic-team/ionic-framework/pull/24337
https://github.com/sean-perkins
https://github.com/liamdebeasi
https://github.com/averyrousseau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.