| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:acd02ab0-6b5f-0fde-2bcb-c48e34a1fa07 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E20E:308E6B:BB7E7D:1075893:6A4E88BC |
| html-safe-nonce | 82124627b8ddd0b28369e5b7735af82c0baff30459b29aadefedccf22ff0f4c0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjBFOjMwOEU2QjpCQjdFN0Q6MTA3NTg5Mzo2QTRFODhCQyIsInZpc2l0b3JfaWQiOiI0MTE4NzI0NDcwMTM4Mzc0MzMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ee2dfb16f9f30263aff33f940df22bf1d8f2a43e4cfa255af0acf8004ffa87bf |
| hovercard-subject-tag | pull_request:765959500 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/inducer/arraycontext/116/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/70cb78b346a938dca7f553e751a674e4c8984f76a6310f1902e4d24d1ef11015/inducer/arraycontext/pull/116 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/70cb78b346a938dca7f553e751a674e4c8984f76a6310f1902e4d24d1ef11015/inducer/arraycontext/pull/116 |
| og:image:alt | There's a couple of random fixes to the dataclass helper in here:
Add an assert in is_array_container_type that isinstance(cls, type). If a dataclass has an Optional or Union field (which are... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alexfikl |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/inducer/arraycontext git https://github.com/inducer/arraycontext.git |
| octolytics-dimension-user_id | 352067 |
| octolytics-dimension-user_login | inducer |
| octolytics-dimension-repository_id | 364716587 |
| octolytics-dimension-repository_nwo | inducer/arraycontext |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 364716587 |
| octolytics-dimension-repository_network_root_nwo | inducer/arraycontext |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/inducer/arraycontext/pull/116#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Finducer%2Farraycontext%2Fpull%2F116 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Finducer%2Farraycontext%2Fpull%2F116 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=inducer%2Farraycontext |
| Reload | https://github.com/inducer/arraycontext/pull/116 |
| Reload | https://github.com/inducer/arraycontext/pull/116 |
| Reload | https://github.com/inducer/arraycontext/pull/116 |
|
inducer
| https://github.com/inducer |
| arraycontext | https://github.com/inducer/arraycontext |
|
Notifications
| https://github.com/login?return_to=%2Finducer%2Farraycontext |
|
Fork
11
| https://github.com/login?return_to=%2Finducer%2Farraycontext |
|
Star
9
| https://github.com/login?return_to=%2Finducer%2Farraycontext |
|
Code
| https://github.com/inducer/arraycontext |
|
Issues
23
| https://github.com/inducer/arraycontext/issues |
|
Pull requests
20
| https://github.com/inducer/arraycontext/pulls |
|
Actions
| https://github.com/inducer/arraycontext/actions |
|
Projects
| https://github.com/inducer/arraycontext/projects |
|
Security and quality
0
| https://github.com/inducer/arraycontext/security |
|
Insights
| https://github.com/inducer/arraycontext/pulse |
|
Code
| https://github.com/inducer/arraycontext |
|
Issues
| https://github.com/inducer/arraycontext/issues |
|
Pull requests
| https://github.com/inducer/arraycontext/pulls |
|
Actions
| https://github.com/inducer/arraycontext/actions |
|
Projects
| https://github.com/inducer/arraycontext/projects |
|
Security and quality
| https://github.com/inducer/arraycontext/security |
|
Insights
| https://github.com/inducer/arraycontext/pulse |
| inducer | https://github.com/inducer |
| inducer:main | https://github.com/inducer/arraycontext/tree/main |
| alexfikl:dataclass-container-strings | https://github.com/alexfikl/arraycontext/tree/dataclass-container-strings |
| Conversation | https://github.com/inducer/arraycontext/pull/116 |
| Commits3 (3) | https://github.com/inducer/arraycontext/pull/116/commits |
| Checks | https://github.com/inducer/arraycontext/pull/116/checks |
| Files changed | https://github.com/inducer/arraycontext/pull/116/files |
| Fixes for dataclass_array_container | https://github.com/inducer/arraycontext/pull/116#top |
| inducer | https://github.com/inducer |
| inducer:main | https://github.com/inducer/arraycontext/tree/main |
| alexfikl:dataclass-container-strings | https://github.com/alexfikl/arraycontext/tree/dataclass-container-strings |
|
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| Oct 26, 2021 | https://github.com/inducer/arraycontext/pull/116#issue-1035708676 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| Oct 26, 2021 | https://github.com/inducer/arraycontext/pull/116#issuecomment-951493565 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| Oct 26, 2021 | https://github.com/inducer/arraycontext/pull/116#event-5517453468 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| Oct 26, 2021 | https://github.com/inducer/arraycontext/pull/116#event-5517517312 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| inducer | https://github.com/inducer |
| October 26, 2021 03:15 | https://github.com/inducer/arraycontext/pull/116#event-5517518090 |
| https://github.com/inducer |
| inducer | https://github.com/inducer |
|
Oct 27, 2021
| https://github.com/inducer/arraycontext/pull/116#pullrequestreview-791228628 |
|
View reviewed changes
| https://github.com/inducer/arraycontext/pull/116/files |
| inducer | https://github.com/inducer |
| https://github.com/inducer/arraycontext/pull/116#pullrequestreview-791228628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| arraycontext/container/__init__.py | https://github.com/inducer/arraycontext/pull/116/files#diff-671ce1bbef666785335baa9e03cfd770d87c9dfe677341ee67996e354f2f9425 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| arraycontext/container/dataclass.py | https://github.com/inducer/arraycontext/pull/116/files#diff-b9e71b9f87a1adb9d42cec6d0c805af6144bd27aa729579dba729ce1d9f14562 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| force-pushed | https://github.com/inducer/arraycontext/compare/17dbce45cc9d80a4ee0eb046ead98725297eb3e3..eae95b5ea7eadcd32ccd10845f3359039c811dd9 |
| 17dbce4 | https://github.com/inducer/arraycontext/commit/17dbce45cc9d80a4ee0eb046ead98725297eb3e3 |
| eae95b5 | https://github.com/inducer/arraycontext/commit/eae95b5ea7eadcd32ccd10845f3359039c811dd9 |
|
Compare
| https://github.com/inducer/arraycontext/compare/17dbce45cc9d80a4ee0eb046ead98725297eb3e3..eae95b5ea7eadcd32ccd10845f3359039c811dd9 |
| October 28, 2021 00:33 | https://github.com/inducer/arraycontext/pull/116#event-5530805887 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
|
Oct 29, 2021
| https://github.com/inducer/arraycontext/pull/116#pullrequestreview-793379687 |
|
View reviewed changes
| https://github.com/inducer/arraycontext/pull/116/files |
| arraycontext/container/__init__.py | https://github.com/inducer/arraycontext/pull/116/files#diff-671ce1bbef666785335baa9e03cfd770d87c9dfe677341ee67996e354f2f9425 |
| alexfikl | https://github.com/alexfikl |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#discussion_r739479038 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| inducer | https://github.com/inducer |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#discussion_r739562151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| alexfikl | https://github.com/alexfikl |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#discussion_r739565669 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 1a28536 | https://github.com/inducer/arraycontext/commit/1a28536ef05476d5065adc160f07e616f65db733 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
|
| https://github.com/alexfikl |
| better error message in dataclass_array_container | https://github.com/inducer/arraycontext/pull/116/commits/e1d0dc63b9370d5fa71035fc5508af562abb1ec1 |
| e1d0dc6 | https://github.com/inducer/arraycontext/pull/116/commits/e1d0dc63b9370d5fa71035fc5508af562abb1ec1 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| force-pushed | https://github.com/inducer/arraycontext/compare/eae95b5ea7eadcd32ccd10845f3359039c811dd9..e1d0dc63b9370d5fa71035fc5508af562abb1ec1 |
| eae95b5 | https://github.com/inducer/arraycontext/commit/eae95b5ea7eadcd32ccd10845f3359039c811dd9 |
| e1d0dc6 | https://github.com/inducer/arraycontext/commit/e1d0dc63b9370d5fa71035fc5508af562abb1ec1 |
|
Compare
| https://github.com/inducer/arraycontext/compare/eae95b5ea7eadcd32ccd10845f3359039c811dd9..e1d0dc63b9370d5fa71035fc5508af562abb1ec1 |
| October 29, 2021 19:33 | https://github.com/inducer/arraycontext/pull/116#event-5542459659 |
|
| https://github.com/alexfikl |
| add type annotations to is_array_field | https://github.com/inducer/arraycontext/pull/116/commits/fc6aa1ba0b5ccacc07012ccc8ba4f7e887f6be6c |
| fc6aa1b | https://github.com/inducer/arraycontext/pull/116/commits/fc6aa1ba0b5ccacc07012ccc8ba4f7e887f6be6c |
| https://github.com/inducer |
| inducer | https://github.com/inducer |
|
Oct 29, 2021
| https://github.com/inducer/arraycontext/pull/116#pullrequestreview-793492772 |
|
View reviewed changes
| https://github.com/inducer/arraycontext/pull/116/files/fc6aa1ba0b5ccacc07012ccc8ba4f7e887f6be6c |
| inducer | https://github.com/inducer |
| https://github.com/inducer/arraycontext/pull/116#pullrequestreview-793492772 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| arraycontext/container/__init__.py | https://github.com/inducer/arraycontext/pull/116/files#diff-671ce1bbef666785335baa9e03cfd770d87c9dfe677341ee67996e354f2f9425 |
| inducer | https://github.com/inducer |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#discussion_r739562151 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
|
| https://github.com/alexfikl |
| remove __mro__ check in is_array_container_type | https://github.com/inducer/arraycontext/pull/116/commits/1a28536ef05476d5065adc160f07e616f65db733 |
| 1a28536 | https://github.com/inducer/arraycontext/pull/116/commits/1a28536ef05476d5065adc160f07e616f65db733 |
| https://github.com/inducer |
| inducer | https://github.com/inducer |
| October 29, 2021 22:54 | https://github.com/inducer/arraycontext/pull/116#event-5543094946 |
| https://github.com/inducer |
| inducer | https://github.com/inducer |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#issuecomment-955090206 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
| https://github.com/inducer |
| inducer | https://github.com/inducer |
| f6400a4 | https://github.com/inducer/arraycontext/commit/f6400a4d5f647a534bd923e879ead8a270fa8d96 |
| Oct 29, 2021 | https://github.com/inducer/arraycontext/pull/116#event-5543168189 |
| https://github.com/alexfikl |
| alexfikl | https://github.com/alexfikl |
| October 29, 2021 23:58 | https://github.com/inducer/arraycontext/pull/116#event-5543201378 |
| https://github.co/hiddenchars |
| https://github.com/inducer/arraycontext/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Finducer%2Farraycontext%2Fpull%2F116 |
|
| https://github.com/inducer |
|
inducer
| https://github.com/inducer |
|
| https://github.com/inducer/arraycontext/pull/116/files/1a28536ef05476d5065adc160f07e616f65db733 |
| Please reload this page | https://github.com/inducer/arraycontext/pull/116 |
|
| https://github.com/alexfikl |
|
| https://github.com/inducer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |