| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d0447723-3c52-c9d0-c494-3927167d85a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E292:2668B6:494E3E:63E37B:6AFBBB00 |
| html-safe-nonce | e7abfa7ef203e75b3c5784429334d1de51e38927a199fc237104ca6d03144bf6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjkyOjI2NjhCNjo0OTRFM0U6NjNFMzdCOjZBRkJCQjAwIiwidmlzaXRvcl9pZCI6IjEyNzQ4MDM1MDQyMTIwNjUwMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a6327462a595d12588dbc78a5c9cfde3ac21d29c521b8b9a49a19372dff9619f |
| hovercard-subject-tag | pull_request:573118192 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/icsharpcode/SharpZipLib/576/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5d5bde27e99d3b4fe3459a01a94526213441cdf763454b2ca6bda80fe30b87c3/icsharpcode/SharpZipLib/pull/576 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5d5bde27e99d3b4fe3459a01a94526213441cdf763454b2ca6bda80fe30b87c3/icsharpcode/SharpZipLib/pull/576 |
| og:image:alt | refs #572
Add an implementation of ReadAsync to ZipAESStream, with associated StreamUtils change and a copy/pasted unit test (that currently fails on .NETCore 3.1 due to #572).
WIP because:
There... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Numpsy |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c |
| turbo-cache-control | no-cache |
| go-import | github.com/icsharpcode/SharpZipLib git https://github.com/icsharpcode/SharpZipLib.git |
| octolytics-dimension-user_id | 343434 |
| octolytics-dimension-user_login | icsharpcode |
| octolytics-dimension-repository_id | 868789 |
| octolytics-dimension-repository_nwo | icsharpcode/SharpZipLib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 868789 |
| octolytics-dimension-repository_network_root_nwo | icsharpcode/SharpZipLib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4cce0e99cf61481a318ff12c2e8580153a6c7c6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/icsharpcode/SharpZipLib/pull/576#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F576 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F576 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=icsharpcode%2FSharpZipLib |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| icsharpcode | https://github.com/icsharpcode |
| SharpZipLib | https://github.com/icsharpcode/SharpZipLib |
| Code | https://github.com/icsharpcode/SharpZipLib |
| Issues90 (90) | https://github.com/icsharpcode/SharpZipLib/issues |
| Pull requests28 (28) | https://github.com/icsharpcode/SharpZipLib/pulls |
| Discussions | https://github.com/icsharpcode/SharpZipLib/discussions |
| Actions | https://github.com/icsharpcode/SharpZipLib/actions |
| Projects | https://github.com/icsharpcode/SharpZipLib/projects |
| Wiki | https://github.com/icsharpcode/SharpZipLib/wiki |
| Security and quality | https://github.com/icsharpcode/SharpZipLib/security |
| Insights | https://github.com/icsharpcode/SharpZipLib/pulse |
| https://github.com/icsharpcode/SharpZipLib |
| Numpsy | https://github.com/Numpsy |
| icsharpcode:master | https://github.com/icsharpcode/SharpZipLib/tree/master |
| Numpsy:rw/async_decryption | https://github.com/Numpsy/SharpZipLib/tree/rw/async_decryption |
| Conversation | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| Commits3 (3) | https://github.com/icsharpcode/SharpZipLib/pull/576/commits |
| Checks | https://github.com/icsharpcode/SharpZipLib/pull/576/checks |
| Files changed | https://github.com/icsharpcode/SharpZipLib/pull/576/files |
| [WIP] Add an implementation of ReadAsync to ZipAESStream | https://github.com/icsharpcode/SharpZipLib/pull/576#top |
| Numpsy | https://github.com/Numpsy |
| icsharpcode:master | https://github.com/icsharpcode/SharpZipLib/tree/master |
| Numpsy:rw/async_decryption | https://github.com/Numpsy/SharpZipLib/tree/rw/async_decryption |
|
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Feb 14, 2021 | https://github.com/icsharpcode/SharpZipLib/pull/576#issue-807998039 |
| #572 | https://github.com/icsharpcode/SharpZipLib/issues/572 |
| #572 | https://github.com/icsharpcode/SharpZipLib/issues/572 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| Numpsy | https://github.com/Numpsy |
| February 14, 2021 16:39 | https://github.com/icsharpcode/SharpZipLib/pull/576#commits-pushed-9da6d27 |
|
| https://github.com/Numpsy |
| add an extra unit test for doing an async read on a ZipFile InputStream | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/9da6d27f4b68f0575275cf76bbd105aabd849746 |
| 9da6d27 | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/9da6d27f4b68f0575275cf76bbd105aabd849746 |
|
| https://github.com/Numpsy |
| Add an async version of ReadRequestedBytes | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/08f81860821d6bf47591a5111c972ede8bd23faf |
| 08f8186 | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/08f81860821d6bf47591a5111c972ede8bd23faf |
|
| https://github.com/Numpsy |
| start adding an implementation of ReadAsync to ZipAESStream | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/24234846de1470b4eb625029b193a2cc4166918f |
| 2423484 | https://github.com/icsharpcode/SharpZipLib/pull/576/commits/24234846de1470b4eb625029b193a2cc4166918f |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Feb 14, 2021 | https://github.com/icsharpcode/SharpZipLib/pull/576#issuecomment-778806037 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
|
Feb 14, 2021
| https://github.com/icsharpcode/SharpZipLib/pull/576#pullrequestreview-590066129 |
|
View reviewed changes
| https://github.com/icsharpcode/SharpZipLib/pull/576/files/24234846de1470b4eb625029b193a2cc4166918f |
| src/ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs | https://github.com/icsharpcode/SharpZipLib/pull/576/files/24234846de1470b4eb625029b193a2cc4166918f#diff-2a24c9c7b361f0797d943eab65ac8c82082e850d3a63fbeb5e31beca76412e82 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/576 |
|
Make ZipAESStream throw ZipException instead of Exception when the AES auth code is wrong
#577
| https://github.com/icsharpcode/SharpZipLib/pull/577 |
|
Implement ReadAsync in ZipAESStream, extra simple version
#579
| https://github.com/icsharpcode/SharpZipLib/pull/579 |
|
add a simple async read test for ZipFile
#588
| https://github.com/icsharpcode/SharpZipLib/pull/588 |
|
[Wip] Add an implementation of ReadAsync to PartialInputStream
#589
| https://github.com/icsharpcode/SharpZipLib/pull/589 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
|
May 8, 2021
| https://github.com/icsharpcode/SharpZipLib/pull/576#ref-pullrequest-881365152 |
|
[WIP] Alternate approach to async reads in ZipAESStream
#624
| https://github.com/icsharpcode/SharpZipLib/pull/624 |
| https://github.co/hiddenchars |
| https://github.com/icsharpcode/SharpZipLib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F576 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/576 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/576 |
|
| https://github.com/Numpsy |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |