| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:326cdecb-c73a-20b9-13e6-39e6af1f27d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E436:3D2B40:A1BC4:D63AF:6AFBAD7C |
| html-safe-nonce | 6fe786972566f1d2e5336f663d53574ceedb6b95c73f332a739b55e7088d8389 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDM2OjNEMkI0MDpBMUJDNDpENjNBRjo2QUZCQUQ3QyIsInZpc2l0b3JfaWQiOiI3NTc5NjMwMDYzODIyMDI0MDYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 29be6e168b380084d469022b42ef1c9b74883aa04b0e1d8efe5aaf52831f4093 |
| hovercard-subject-tag | pull_request:470508420 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/icsharpcode/SharpZipLib/512/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7a7ae1bd8a67d7fdc65cd394d435b853c5205e7561e57f89e39f0be46551186d/icsharpcode/SharpZipLib/pull/512 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7a7ae1bd8a67d7fdc65cd394d435b853c5205e7561e57f89e39f0be46551186d/icsharpcode/SharpZipLib/pull/512 |
| og:image:alt | a spin off from #475 which makes the other change suggsted there to remove descriptors from entries during updates, in cases where the header is rewritten rather than just copied directly.
Put in a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Numpsy |
| hostname | github.com |
| expected-hostname | github.com |
| None | e25fbd830d3e6ad0e8935c105cf4fdc70c593dffcd27bb45b790ae4fece5ea55 |
| turbo-cache-control | no-cache |
| go-import | github.com/icsharpcode/SharpZipLib git https://github.com/icsharpcode/SharpZipLib.git |
| octolytics-dimension-user_id | 343434 |
| octolytics-dimension-user_login | icsharpcode |
| octolytics-dimension-repository_id | 868789 |
| octolytics-dimension-repository_nwo | icsharpcode/SharpZipLib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 868789 |
| octolytics-dimension-repository_network_root_nwo | icsharpcode/SharpZipLib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08c8f17f9d27054a108b8b6254e405de0151f660 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/icsharpcode/SharpZipLib/pull/512#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F512 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F512 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=icsharpcode%2FSharpZipLib |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| Reload | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| icsharpcode | https://github.com/icsharpcode |
| SharpZipLib | https://github.com/icsharpcode/SharpZipLib |
| Code | https://github.com/icsharpcode/SharpZipLib |
| Issues90 (90) | https://github.com/icsharpcode/SharpZipLib/issues |
| Pull requests28 (28) | https://github.com/icsharpcode/SharpZipLib/pulls |
| Discussions | https://github.com/icsharpcode/SharpZipLib/discussions |
| Actions | https://github.com/icsharpcode/SharpZipLib/actions |
| Projects | https://github.com/icsharpcode/SharpZipLib/projects |
| Wiki | https://github.com/icsharpcode/SharpZipLib/wiki |
| Security and quality | https://github.com/icsharpcode/SharpZipLib/security |
| Insights | https://github.com/icsharpcode/SharpZipLib/pulse |
| https://github.com/icsharpcode/SharpZipLib |
| Numpsy | https://github.com/Numpsy |
| icsharpcode:master | https://github.com/icsharpcode/SharpZipLib/tree/master |
| Numpsy:rw/zipfile/alternate_descriptor_update | https://github.com/Numpsy/SharpZipLib/tree/rw/zipfile/alternate_descriptor_update |
| Conversation | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| Commits6 (6) | https://github.com/icsharpcode/SharpZipLib/pull/512/commits |
| Checks | https://github.com/icsharpcode/SharpZipLib/pull/512/checks |
| Files changed | https://github.com/icsharpcode/SharpZipLib/pull/512/files |
| experiment with removing descriptors from zip file entries during updates | https://github.com/icsharpcode/SharpZipLib/pull/512#top |
| Numpsy | https://github.com/Numpsy |
| icsharpcode:master | https://github.com/icsharpcode/SharpZipLib/tree/master |
| Numpsy:rw/zipfile/alternate_descriptor_update | https://github.com/Numpsy/SharpZipLib/tree/rw/zipfile/alternate_descriptor_update |
|
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Aug 19, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issue-682241272 |
| #475 | https://github.com/icsharpcode/SharpZipLib/pull/475 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| Numpsy | https://github.com/Numpsy |
| August 19, 2020 23:28 | https://github.com/icsharpcode/SharpZipLib/pull/512#commits-pushed-b62951e |
|
| https://github.com/Numpsy |
| Unit tests for using ZipFile to update file entries that have descrip… | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/b62951e0c1f45c16defdedd1628f9dc85c24027b |
| b62951e | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/b62951e0c1f45c16defdedd1628f9dc85c24027b |
|
| https://github.com/Numpsy |
| fix size calculation in GetDescriptorSize | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/f28a12e41619067acca7ae7db342f1a42de5e3d8 |
| f28a12e | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/f28a12e41619067acca7ae7db342f1a42de5e3d8 |
|
| https://github.com/piksel |
|
| https://github.com/Numpsy |
| Handle optional descriptor signature when updating | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/20e0a812d436543cd7eab4291ea3407dcc9a2f93 |
| 20e0a81 | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/20e0a812d436543cd7eab4291ea3407dcc9a2f93 |
|
| https://github.com/piksel |
|
| https://github.com/Numpsy |
| Handle optional descriptor signature when updating | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/5c09afb9f9dba8261e86140eae4e0c4b7b698fa3 |
| 5c09afb | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/5c09afb9f9dba8261e86140eae4e0c4b7b698fa3 |
|
| https://github.com/Numpsy |
| Remove descriptors from zip entries when moving them during updates. | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/3b33af9677aaf35e9ec64603991306349acc5fba |
| 3b33af9 | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/3b33af9677aaf35e9ec64603991306349acc5fba |
|
| https://github.com/Numpsy |
| Extra test for updating zips whose entries have descriptors with no s… | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/a3bed391da11863277a597f6ae9ce2a9b8c20f83 |
| a3bed39 | https://github.com/icsharpcode/SharpZipLib/pull/512/commits/a3bed391da11863277a597f6ae9ce2a9b8c20f83 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Aug 19, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-676806705 |
| SharpZipLib/src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs | https://github.com/icsharpcode/SharpZipLib/blob/a3bed391da11863277a597f6ae9ce2a9b8c20f83/src/ICSharpCode.SharpZipLib/Zip/ZipFile.cs#L2082 |
| a3bed39 | https://github.com/icsharpcode/SharpZipLib/commit/a3bed391da11863277a597f6ae9ce2a9b8c20f83 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/piksel |
| piksel | https://github.com/piksel |
| Aug 28, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-683100050 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Sep 8, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-689016894 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Sep 22, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-696973998 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/piksel |
| piksel | https://github.com/piksel |
| Oct 3, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-703140228 |
| @Numpsy | https://github.com/Numpsy |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Oct 8, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-705461021 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
|
Oct 8, 2020
| https://github.com/icsharpcode/SharpZipLib/pull/512#ref-pullrequest-643388854 |
|
Fix updating zips whose entries have descriptors.
#475
| https://github.com/icsharpcode/SharpZipLib/pull/475 |
| https://github.com/Numpsy |
| Numpsy | https://github.com/Numpsy |
| Dec 6, 2020 | https://github.com/icsharpcode/SharpZipLib/pull/512#issuecomment-739574106 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| https://github.co/hiddenchars |
| https://github.com/icsharpcode/SharpZipLib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ficsharpcode%2FSharpZipLib%2Fpull%2F512 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
| Please reload this page | https://github.com/icsharpcode/SharpZipLib/pull/512 |
|
| https://github.com/Numpsy |
|
| https://github.com/piksel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |