| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a2d12c91-3495-8672-3b07-3a6f263e6b1a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D020:5CEA4:13F66C7:1BDB304:6A4EA546 |
| html-safe-nonce | 63d6a9fac8f0505cb093fea37eec3b426ecc2d42ab143fbbebf42755e3660124 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDIwOjVDRUE0OjEzRjY2Qzc6MUJEQjMwNDo2QTRFQTU0NiIsInZpc2l0b3JfaWQiOiI1MTE2NjIxMjA4OTYwMjc5ODc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b9ce4faa9d8227355ae60d7d3f5727d040fe4e795d52edad43161c774c0de3d1 |
| hovercard-subject-tag | pull_request:693654032 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/hypertrace/javaagent/339/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/69638a8c68e7f5ac1d08d8e6503bc2d748854c67be0845a9e43e45b95e3d4a2c/hypertrace/javaagent/pull/339 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/69638a8c68e7f5ac1d08d8e6503bc2d748854c67be0845a9e43e45b95e3d4a2c/hypertrace/javaagent/pull/339 |
| og:image:alt | Description
First, duplicates instrumentation targeting io.grpc.netty.Utls to work properly when users are using io.grpc:grpc-netty-shaded. This is rather inelegant, but this was the fastest soluti... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ryandens |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-cache |
| go-import | github.com/hypertrace/javaagent git https://github.com/hypertrace/javaagent.git |
| octolytics-dimension-user_id | 65374698 |
| octolytics-dimension-user_login | hypertrace |
| octolytics-dimension-repository_id | 302314733 |
| octolytics-dimension-repository_nwo | hypertrace/javaagent |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 302314733 |
| octolytics-dimension-repository_network_root_nwo | hypertrace/javaagent |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/hypertrace/javaagent/pull/339#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F339 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F339 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=hypertrace%2Fjavaagent |
| Reload | https://github.com/hypertrace/javaagent/pull/339 |
| Reload | https://github.com/hypertrace/javaagent/pull/339 |
| Reload | https://github.com/hypertrace/javaagent/pull/339 |
| Please reload this page | https://github.com/hypertrace/javaagent/pull/339 |
|
hypertrace
| https://github.com/hypertrace |
| javaagent | https://github.com/hypertrace/javaagent |
|
Notifications
| https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent |
|
Fork
14
| https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent |
|
Star
37
| https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent |
|
Code
| https://github.com/hypertrace/javaagent |
|
Issues
35
| https://github.com/hypertrace/javaagent/issues |
|
Pull requests
4
| https://github.com/hypertrace/javaagent/pulls |
|
Discussions
| https://github.com/hypertrace/javaagent/discussions |
|
Actions
| https://github.com/hypertrace/javaagent/actions |
|
Projects
| https://github.com/hypertrace/javaagent/projects |
|
Security and quality
0
| https://github.com/hypertrace/javaagent/security |
|
Insights
| https://github.com/hypertrace/javaagent/pulse |
|
Code
| https://github.com/hypertrace/javaagent |
|
Issues
| https://github.com/hypertrace/javaagent/issues |
|
Pull requests
| https://github.com/hypertrace/javaagent/pulls |
|
Discussions
| https://github.com/hypertrace/javaagent/discussions |
|
Actions
| https://github.com/hypertrace/javaagent/actions |
|
Projects
| https://github.com/hypertrace/javaagent/projects |
|
Security and quality
| https://github.com/hypertrace/javaagent/security |
|
Insights
| https://github.com/hypertrace/javaagent/pulse |
| ryandens | https://github.com/ryandens |
| main | https://github.com/hypertrace/javaagent/tree/main |
| grpc-request-capture | https://github.com/hypertrace/javaagent/tree/grpc-request-capture |
| Conversation | https://github.com/hypertrace/javaagent/pull/339 |
| Commits19 (19) | https://github.com/hypertrace/javaagent/pull/339/commits |
| Checks | https://github.com/hypertrace/javaagent/pull/339/checks |
| Files changed | https://github.com/hypertrace/javaagent/pull/339/files |
| 🐛 gRPC header capture with shaded netty module and body capture without com.google.protobuf.util.JsonFormat | https://github.com/hypertrace/javaagent/pull/339#top |
| ryandens | https://github.com/ryandens |
| main | https://github.com/hypertrace/javaagent/tree/main |
| grpc-request-capture | https://github.com/hypertrace/javaagent/tree/grpc-request-capture |
|
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| Jul 20, 2021 | https://github.com/hypertrace/javaagent/pull/339#issue-948877277 |
| Please reload this page | https://github.com/hypertrace/javaagent/pull/339 |
| hypertrace docs repo | https://github.com/hypertrace/hypertrace-docs-website |
| Please reload this page | https://github.com/hypertrace/javaagent/pull/339 |
| ryandens | https://github.com/ryandens |
| July 20, 2021 12:09 | https://github.com/hypertrace/javaagent/pull/339#commits-pushed-328452c |
|
| https://github.com/ryandens |
| ✅ add test tasks for gRPC 1.30.0 | https://github.com/hypertrace/javaagent/pull/339/commits/328452c9bc4973343a71a7073d7fab64802cfd32 |
| 328452c | https://github.com/hypertrace/javaagent/pull/339/commits/328452c9bc4973343a71a7073d7fab64802cfd32 |
|
| https://github.com/ryandens |
| ♻️ move GrpcSemanticAttributes to common library for access across gr… | https://github.com/hypertrace/javaagent/pull/339/commits/d2dfd0bf9ef95a1694b37e3fde5ecbd3832868a0 |
| d2dfd0b | https://github.com/hypertrace/javaagent/pull/339/commits/d2dfd0bf9ef95a1694b37e3fde5ecbd3832868a0 |
|
| https://github.com/ryandens |
| ✨ add instrumentation for grpc-shaded-netty-1.9 | https://github.com/hypertrace/javaagent/pull/339/commits/7cdea210898a8aaac8670eedceb7d5c0d5cbfc61 |
| 7cdea21 | https://github.com/hypertrace/javaagent/pull/339/commits/7cdea210898a8aaac8670eedceb7d5c0d5cbfc61 |
|
| https://github.com/ryandens |
| 🎨 format grpc-1.6 build | https://github.com/hypertrace/javaagent/pull/339/commits/7e6706c94d15666ad98dff7484e1185157224edb |
| 7e6706c | https://github.com/hypertrace/javaagent/pull/339/commits/7e6706c94d15666ad98dff7484e1185157224edb |
|
| https://github.com/ryandens |
| 🐛 fix classpath for versioned test source set | https://github.com/hypertrace/javaagent/pull/339/commits/fb8bbc7263f915a368685a7c4819e8d733ca091b |
| fb8bbc7 | https://github.com/hypertrace/javaagent/pull/339/commits/fb8bbc7263f915a368685a7c4819e8d733ca091b |
|
| https://github.com/ryandens |
| ✅ add muzzle check for module | https://github.com/hypertrace/javaagent/pull/339/commits/15358e9d859edc4a1e6be00cd8f396899a74defa |
| 15358e9 | https://github.com/hypertrace/javaagent/pull/339/commits/15358e9d859edc4a1e6be00cd8f396899a74defa |
|
| https://github.com/ryandens |
| 🎨 format shaded netty module | https://github.com/hypertrace/javaagent/pull/339/commits/6b0bb44a3f3f6ddd7bbb869cbe009ecc943e57c2 |
| 6b0bb44 | https://github.com/hypertrace/javaagent/pull/339/commits/6b0bb44a3f3f6ddd7bbb869cbe009ecc943e57c2 |
|
| https://github.com/ryandens |
| ♻️ move usages of grpc-common to util class | https://github.com/hypertrace/javaagent/pull/339/commits/65c7b13ac88becee969cb2bff0432b69738e306a |
| 65c7b13 | https://github.com/hypertrace/javaagent/pull/339/commits/65c7b13ac88becee969cb2bff0432b69738e306a |
|
| https://github.com/ryandens |
| 🐛 add names to instrumentation module | https://github.com/hypertrace/javaagent/pull/339/commits/44bbaaedcff337ab370d42d073ccca4debf5d4b9 |
| 44bbaae | https://github.com/hypertrace/javaagent/pull/339/commits/44bbaaedcff337ab370d42d073ccca4debf5d4b9 |
|
| https://github.com/ryandens |
| 🎨 format utils | https://github.com/hypertrace/javaagent/pull/339/commits/bd25277a7dc7ac3023ecc6c338f6c01babaaa2aa |
| bd25277 | https://github.com/hypertrace/javaagent/pull/339/commits/bd25277a7dc7ac3023ecc6c338f6c01babaaa2aa |
|
| https://github.com/ryandens |
| 🚚 rename NettyUtils | https://github.com/hypertrace/javaagent/pull/339/commits/e3828cc12825811aa1360ca38884171b8bfb8a69 |
| e3828cc | https://github.com/hypertrace/javaagent/pull/339/commits/e3828cc12825811aa1360ca38884171b8bfb8a69 |
|
| https://github.com/ryandens |
| 🚚 move around classes | https://github.com/hypertrace/javaagent/pull/339/commits/234d963dd3b8ffb5db549a987f792fc56fd4ef75 |
| 234d963 | https://github.com/hypertrace/javaagent/pull/339/commits/234d963dd3b8ffb5db549a987f792fc56fd4ef75 |
|
| https://github.com/ryandens |
| 🚚 move instrumentation classes to separate file | https://github.com/hypertrace/javaagent/pull/339/commits/2f48a7d5c9231fc42ab34f15ad140e53e6435ac3 |
| 2f48a7d | https://github.com/hypertrace/javaagent/pull/339/commits/2f48a7d5c9231fc42ab34f15ad140e53e6435ac3 |
|
| https://github.com/ryandens |
| 🐛 copy-paste build script bug | https://github.com/hypertrace/javaagent/pull/339/commits/31a8e8437867fcba4a9827e7a5f5788ff6eb5125 |
| 31a8e84 | https://github.com/hypertrace/javaagent/pull/339/commits/31a8e8437867fcba4a9827e7a5f5788ff6eb5125 |
|
| https://github.com/ryandens |
| 🔥 remove unneeded helper class method | https://github.com/hypertrace/javaagent/pull/339/commits/23a5235c6f3b77f3262140483250273ca15e2161 |
| 23a5235 | https://github.com/hypertrace/javaagent/pull/339/commits/23a5235c6f3b77f3262140483250273ca15e2161 |
|
| https://github.com/ryandens |
| ✅ update muzzle policy to be more restrictive, we need to work withou… | https://github.com/hypertrace/javaagent/pull/339/commits/1f451667f422470fcae5d3209d806901da14ea73 |
| 1f45166 | https://github.com/hypertrace/javaagent/pull/339/commits/1f451667f422470fcae5d3209d806901da14ea73 |
|
| https://github.com/ryandens |
| ✨ add shaded project for protobuf-java-util | https://github.com/hypertrace/javaagent/pull/339/commits/89f6b30c16b1e3ba9488f4e0a9d6e78fbb75c0e0 |
| 89f6b30 | https://github.com/hypertrace/javaagent/pull/339/commits/89f6b30c16b1e3ba9488f4e0a9d6e78fbb75c0e0 |
|
| https://github.com/ryandens |
| ♻️ use shaded protobuf java util in grpc instrumentation | https://github.com/hypertrace/javaagent/pull/339/commits/c1f8378212a7c5683b3b87efac3753bfbe98a824 |
| c1f8378 | https://github.com/hypertrace/javaagent/pull/339/commits/c1f8378212a7c5683b3b87efac3753bfbe98a824 |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| July 21, 2021 17:27 | https://github.com/hypertrace/javaagent/pull/339#event-5051627668 |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| davexroth | https://github.com/davexroth |
| July 21, 2021 17:27 | https://github.com/hypertrace/javaagent/pull/339#event-5051628164 |
|
| https://github.com/ryandens |
| 🔥 remove unneeded relocations | https://github.com/hypertrace/javaagent/pull/339/commits/699943833e9ae2e4068f6cb23413a8e3b738567b |
| 6999438 | https://github.com/hypertrace/javaagent/pull/339/commits/699943833e9ae2e4068f6cb23413a8e3b738567b |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| Jul 21, 2021 | https://github.com/hypertrace/javaagent/pull/339#event-5051671554 |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| shashank11p | https://github.com/shashank11p |
| July 21, 2021 17:53 | https://github.com/hypertrace/javaagent/pull/339#event-5051743900 |
| https://github.com/davexroth |
| davexroth | https://github.com/davexroth |
|
Jul 21, 2021
| https://github.com/hypertrace/javaagent/pull/339#pullrequestreview-712009879 |
|
View reviewed changes
| https://github.com/hypertrace/javaagent/pull/339/files/699943833e9ae2e4068f6cb23413a8e3b738567b |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| 4816a22 | https://github.com/hypertrace/javaagent/commit/4816a227c9b8f00f4dd1361e4cfc19ffca9ce635 |
| Jul 21, 2021 | https://github.com/hypertrace/javaagent/pull/339#event-5051893197 |
| https://github.com/ryandens |
| ryandens | https://github.com/ryandens |
| July 21, 2021 18:27 | https://github.com/hypertrace/javaagent/pull/339#event-5051893234 |
| https://github.co/hiddenchars |
| https://github.com/hypertrace/javaagent/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F339 |
|
| https://github.com/shashank11p |
|
shashank11p
| https://github.com/shashank11p |
|
| https://github.com/davexroth |
|
davexroth
| https://github.com/davexroth |
|
| https://github.com/hypertrace/javaagent/pull/339/files/699943833e9ae2e4068f6cb23413a8e3b738567b |
| Please reload this page | https://github.com/hypertrace/javaagent/pull/339 |
|
| https://github.com/ryandens |
|
| https://github.com/davexroth |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |