René's URL Explorer Experiment


Title: Fix config being loaded twice by ryandens · Pull Request #293 · hypertrace/javaagent · GitHub

Open Graph Title: Fix config being loaded twice by ryandens · Pull Request #293 · hypertrace/javaagent

X Title: Fix config being loaded twice by ryandens · Pull Request #293 · hypertrace/javaagent

Description: Hypertrace OpenTelemetry Java agent with payload/body and headers data capture. - Fix config being loaded twice by ryandens · Pull Request #293 · hypertrace/javaagent

Open Graph Description: Description Resolves #223 (kind of). This bug no longer seems to be present, but as a result of the investigation into #223 a small thread-safety issue was noticed in the double-checked locking imp...

X Description: Description Resolves #223 (kind of). This bug no longer seems to be present, but as a result of the investigation into #223 a small thread-safety issue was noticed in the double-checked locking imp...

Opengraph URL: https://github.com/hypertrace/javaagent/pull/293

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7bd9ab8b-5baa-aabd-7d70-d59c616aba71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96EC:11C2D2:2DA2B0:3D98C7:6A4EB26F
html-safe-nonceda461bec9c318d6f31727b20565362aa3a37a23e237e3f9cf8bbb27adf04730c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkVDOjExQzJEMjoyREEyQjA6M0Q5OEM3OjZBNEVCMjZGIiwidmlzaXRvcl9pZCI6IjY5Mzg2MTIyMjkzMTE3Mzg0NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac63795de828ff7169b9e5a7d8a39971fcf36d493975162e1c96ee025a6acbaeb6
hovercard-subject-tagpull_request:598193695
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/hypertrace/javaagent/293/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca441b8de953ce5b49c08c0bef4e533f26e9015b492ca3af9e6ee0f54f94356c/hypertrace/javaagent/pull/293
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca441b8de953ce5b49c08c0bef4e533f26e9015b492ca3af9e6ee0f54f94356c/hypertrace/javaagent/pull/293
og:image:altDescription Resolves #223 (kind of). This bug no longer seems to be present, but as a result of the investigation into #223 a small thread-safety issue was noticed in the double-checked locking imp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameryandens
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/hypertrace/javaagent git https://github.com/hypertrace/javaagent.git
octolytics-dimension-user_id65374698
octolytics-dimension-user_loginhypertrace
octolytics-dimension-repository_id302314733
octolytics-dimension-repository_nwohypertrace/javaagent
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id302314733
octolytics-dimension-repository_network_root_nwohypertrace/javaagent
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/hypertrace/javaagent/pull/293#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F293
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F293
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=hypertrace%2Fjavaagent
Reloadhttps://github.com/hypertrace/javaagent/pull/293
Reloadhttps://github.com/hypertrace/javaagent/pull/293
Reloadhttps://github.com/hypertrace/javaagent/pull/293
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
hypertrace https://github.com/hypertrace
javaagenthttps://github.com/hypertrace/javaagent
Notifications https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent
Fork 14 https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent
Star 37 https://github.com/login?return_to=%2Fhypertrace%2Fjavaagent
Code https://github.com/hypertrace/javaagent
Issues 35 https://github.com/hypertrace/javaagent/issues
Pull requests 4 https://github.com/hypertrace/javaagent/pulls
Discussions https://github.com/hypertrace/javaagent/discussions
Actions https://github.com/hypertrace/javaagent/actions
Projects https://github.com/hypertrace/javaagent/projects
Security and quality 0 https://github.com/hypertrace/javaagent/security
Insights https://github.com/hypertrace/javaagent/pulse
Code https://github.com/hypertrace/javaagent
Issues https://github.com/hypertrace/javaagent/issues
Pull requests https://github.com/hypertrace/javaagent/pulls
Discussions https://github.com/hypertrace/javaagent/discussions
Actions https://github.com/hypertrace/javaagent/actions
Projects https://github.com/hypertrace/javaagent/projects
Security and quality https://github.com/hypertrace/javaagent/security
Insights https://github.com/hypertrace/javaagent/pulse
pavolloffayhttps://github.com/pavolloffay
hypertrace:mainhttps://github.com/hypertrace/javaagent/tree/main
Conversationhttps://github.com/hypertrace/javaagent/pull/293
Commits5 (5)https://github.com/hypertrace/javaagent/pull/293/commits
Checkshttps://github.com/hypertrace/javaagent/pull/293/checks
Files changedhttps://github.com/hypertrace/javaagent/pull/293/files
Fix config being loaded twicehttps://github.com/hypertrace/javaagent/pull/293#top
pavolloffayhttps://github.com/pavolloffay
hypertrace:mainhttps://github.com/hypertrace/javaagent/tree/main
https://github.com/ryandens
ryandenshttps://github.com/ryandens
Mar 22, 2021https://github.com/hypertrace/javaagent/pull/293#issue-837933109
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
#223https://github.com/hypertrace/javaagent/issues/223
#223https://github.com/hypertrace/javaagent/issues/223
The "Double-Checked Locking is Broken Declaration"https://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html
JSR 133 FAQ "What does volatile do?"http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html#volatile
Guava's NonSerializableMemoizingSupplierhttps://github.com/google/guava/blob/master/guava/src/com/google/common/base/Suppliers.java#L150
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
https://github.com/ryandens
ryandenshttps://github.com/ryandens
Mar 22, 2021 https://github.com/hypertrace/javaagent/pull/293#pullrequestreview-617783318
View reviewed changes https://github.com/hypertrace/javaagent/pull/293/files
javaagent-core/src/test/java/org/hypertrace/agent/core/config/AgentConfigSupplierTest.javahttps://github.com/hypertrace/javaagent/pull/293/files#diff-a3e27cdeb3f4b52ab7e0b0c599e65769146da780fa8529e4dc1a3c9836e57d04
ryandenshttps://github.com/ryandens
Mar 22, 2021https://github.com/hypertrace/javaagent/pull/293#discussion_r598918379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
Mar 23, 2021 https://github.com/hypertrace/javaagent/pull/293#pullrequestreview-618283121
View reviewed changes https://github.com/hypertrace/javaagent/pull/293/files
javaagent-core/src/main/java/org/hypertrace/agent/core/config/HypertraceConfig.javahttps://github.com/hypertrace/javaagent/pull/293/files#diff-4243b2d9383c6c39f190fdcf3734c4f75d42fbce2f8b5594f91286b0e1830187
pavolloffayhttps://github.com/pavolloffay
Mar 23, 2021https://github.com/hypertrace/javaagent/pull/293#discussion_r599335255
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
ryandenshttps://github.com/ryandens
Mar 27, 2021https://github.com/hypertrace/javaagent/pull/293#discussion_r602730841
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
Mar 23, 2021https://github.com/hypertrace/javaagent/pull/293#event-4494494867
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
force-pushedhttps://github.com/hypertrace/javaagent/compare/e016385972fb0537b65e46a975e65c98b39645da..6b787b4a62ff41cfbd042b48f16619b36e4f7a32
e016385https://github.com/hypertrace/javaagent/commit/e016385972fb0537b65e46a975e65c98b39645da
6b787b4https://github.com/hypertrace/javaagent/commit/6b787b4a62ff41cfbd042b48f16619b36e4f7a32
Compare https://github.com/hypertrace/javaagent/compare/e016385972fb0537b65e46a975e65c98b39645da..6b787b4a62ff41cfbd042b48f16619b36e4f7a32
March 23, 2021 09:07https://github.com/hypertrace/javaagent/pull/293#event-4494853845
ryandenshttps://github.com/ryandens
March 27, 2021 11:26https://github.com/hypertrace/javaagent/pull/293#commits-pushed-38c8d9f
https://github.com/ryandens
✨ create memoizing AgentConfigSupplier encapsulating double-checked l…https://github.com/hypertrace/javaagent/pull/293/commits/38c8d9f1a98de11bd4889975e77a0e32e5e4a355
38c8d9fhttps://github.com/hypertrace/javaagent/pull/293/commits/38c8d9f1a98de11bd4889975e77a0e32e5e4a355
https://github.com/ryandens
♻️ refactor HypertraceConfig to use thread-safe AgentConfigSupplierhttps://github.com/hypertrace/javaagent/pull/293/commits/49bd84b212edbf99dbb75c13eabc9cb2f36b1acf
49bd84bhttps://github.com/hypertrace/javaagent/pull/293/commits/49bd84b212edbf99dbb75c13eabc9cb2f36b1acf
https://github.com/ryandens
Revert ":recycle: refactor HypertraceConfig to use thread-safe AgentC…https://github.com/hypertrace/javaagent/pull/293/commits/ca8f431c318fc42cab7c95f65c11e33eac234669
ca8f431https://github.com/hypertrace/javaagent/pull/293/commits/ca8f431c318fc42cab7c95f65c11e33eac234669
19ad84bhttps://github.com/hypertrace/javaagent/commit/19ad84b7c4183a11977a1dce69a03c92c0211336
https://github.com/ryandens
👌 move double-checked locking implementation back into HypertraceConfighttps://github.com/hypertrace/javaagent/pull/293/commits/da325bdc5944d8097a0a2077653e373ac1f9600c
da325bdhttps://github.com/hypertrace/javaagent/pull/293/commits/da325bdc5944d8097a0a2077653e373ac1f9600c
https://github.com/ryandens
🔥 delete AgentConfigSupplier as it is now unusedhttps://github.com/hypertrace/javaagent/pull/293/commits/db27d36e1f353fc45c83c7a8af6f3e1e43bd0dc6
db27d36https://github.com/hypertrace/javaagent/pull/293/commits/db27d36e1f353fc45c83c7a8af6f3e1e43bd0dc6
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
Mar 27, 2021 https://github.com/hypertrace/javaagent/pull/293#pullrequestreview-622698462
View reviewed changes https://github.com/hypertrace/javaagent/pull/293/files/db27d36e1f353fc45c83c7a8af6f3e1e43bd0dc6
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
Mar 27, 2021https://github.com/hypertrace/javaagent/pull/293#issuecomment-808795243
@ryandenshttps://github.com/ryandens
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
https://github.com/pavolloffay
pavolloffayhttps://github.com/pavolloffay
33bc28fhttps://github.com/hypertrace/javaagent/commit/33bc28f7acfeeb5b077f9ad89817884efeb8e45e
Mar 27, 2021https://github.com/hypertrace/javaagent/pull/293#event-4517499732
https://github.co/hiddenchars
https://github.com/hypertrace/javaagent/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhypertrace%2Fjavaagent%2Fpull%2F293
https://github.com/pavolloffay
pavolloffay https://github.com/pavolloffay
https://github.com/hypertrace/javaagent/pull/293/files/db27d36e1f353fc45c83c7a8af6f3e1e43bd0dc6
Hypertrace config is being loaded twice https://github.com/hypertrace/javaagent/issues/223
Please reload this pagehttps://github.com/hypertrace/javaagent/pull/293
https://github.com/ryandens
https://github.com/pavolloffay
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.