Title: GRPC Instrumentation not adding rpc.body to spans · Issue #313 · hypertrace/javaagent · GitHub
Open Graph Title: GRPC Instrumentation not adding rpc.body to spans · Issue #313 · hypertrace/javaagent
X Title: GRPC Instrumentation not adding rpc.body to spans · Issue #313 · hypertrace/javaagent
Description: The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded classes, while during runtime the actual c...
Open Graph Description: The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded cl...
X Description: The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded cl...
Opengraph URL: https://github.com/hypertrace/javaagent/issues/313
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"GRPC Instrumentation not adding rpc.body to spans","articleBody":"The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded classes, while during runtime the actual classes are used. \r\n\r\nSo we should not shade the protobuf dependencies in javaagent. But javaagent also needs to have protobuf dependency for config. So we need to have the protobuf in javaagent to be in agentClassLoader, and do not shade it so that GRPC instrumentation works. ","author":{"url":"https://github.com/shashank11p","@type":"Person","name":"shashank11p"},"datePublished":"2021-05-05T13:20:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/313/javaagent/issues/313"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a7e827b4-ad7c-fe5a-71d8-ca4c4f80443d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AFB2:48B83:312F180:434091F:6A50771F |
| html-safe-nonce | 50d37a2575fffd1d336b84d4d50abfdd2272695c489f934d9e8a392ace9dd0a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkIyOjQ4QjgzOjMxMkYxODA6NDM0MDkxRjo2QTUwNzcxRiIsInZpc2l0b3JfaWQiOiIyMzg3OTk4NTQ5ODg5NTQ2MDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a424cd52a1ebe606b4df98dbbeeec9348513a815fcec2dfe53607841784570eb |
| hovercard-subject-tag | issue:876443997 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/hypertrace/javaagent/313/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6f8a95e4ce8f74d720455806a55fc7df232a3f838ef2cd7a90ab4d9df8ab92f2/hypertrace/javaagent/issues/313 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6f8a95e4ce8f74d720455806a55fc7df232a3f838ef2cd7a90ab4d9df8ab92f2/hypertrace/javaagent/issues/313 |
| og:image:alt | The GRPC instrumentation is not able to add rpc.request.body and rpc.response.body attributes to spans as the protobuf classes are shaded in the javaagent so the instrumentation looks for shaded cl... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shashank11p |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| go-import | github.com/hypertrace/javaagent git https://github.com/hypertrace/javaagent.git |
| octolytics-dimension-user_id | 65374698 |
| octolytics-dimension-user_login | hypertrace |
| octolytics-dimension-repository_id | 302314733 |
| octolytics-dimension-repository_nwo | hypertrace/javaagent |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 302314733 |
| octolytics-dimension-repository_network_root_nwo | hypertrace/javaagent |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width