Title: Remove wrapping from servlet instrumentation · Issue #222 · hypertrace/javaagent · GitHub
Open Graph Title: Remove wrapping from servlet instrumentation · Issue #222 · hypertrace/javaagent
X Title: Remove wrapping from servlet instrumentation · Issue #222 · hypertrace/javaagent
Description: Wrapping request/response types in servlet can cause issues with casting to specific types. We haven't seen any issue in this repo, which can be a result of not wide exposure and lack of tests on different servlet containers. OTEL had a ...
Open Graph Description: Wrapping request/response types in servlet can cause issues with casting to specific types. We haven't seen any issue in this repo, which can be a result of not wide exposure and lack of tests on d...
X Description: Wrapping request/response types in servlet can cause issues with casting to specific types. We haven't seen any issue in this repo, which can be a result of not wide exposure and lack of tests ...
Opengraph URL: https://github.com/hypertrace/javaagent/issues/222
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove wrapping from servlet instrumentation ","articleBody":"Wrapping request/response types in servlet can cause issues with casting to specific types.\r\nWe haven't seen any issue in this repo, which can be a result of not wide exposure and lack of tests on different servlet containers.\r\n\r\nOTEL had a wrapping in place for a short period of time and it resulted in issues https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/1096. Therefore we should consider removing wrapping and directly instrument streams associated with the request like we do in other instrumentations. \r\n\r\nPart of this task should be performance testing if the stream instrumentation does not add latency/CPU cycles.\r\n\r\n","author":{"url":"https://github.com/pavolloffay","@type":"Person","name":"pavolloffay"},"datePublished":"2021-01-11T08:34:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/222/javaagent/issues/222"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3e61b797-9757-fc02-f4ab-8a763356af5b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BF3A:10ED6:36457D:48D863:6A4DC65A |
| html-safe-nonce | 507ba8e91e0f3b33ec74f559ddea49d91c05893beed658e3d638c8b4fd133d58 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjNBOjEwRUQ2OjM2NDU3RDo0OEQ4NjM6NkE0REM2NUEiLCJ2aXNpdG9yX2lkIjoiMzY5NzUwNTAzNTg3MDkxNDEzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7fb6175852e7d4130d66d324eadcff2351f085f3ab0cd7c06d0f315738ea6a45 |
| hovercard-subject-tag | issue:783174632 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/hypertrace/javaagent/222/issue_layout |
| twitter:image | https://opengraph.githubassets.com/70b25ff3402a12645a99d232d2e19462cb80944ebc5d537cf8486f9f4eb7c1ec/hypertrace/javaagent/issues/222 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/70b25ff3402a12645a99d232d2e19462cb80944ebc5d537cf8486f9f4eb7c1ec/hypertrace/javaagent/issues/222 |
| og:image:alt | Wrapping request/response types in servlet can cause issues with casting to specific types. We haven't seen any issue in this repo, which can be a result of not wide exposure and lack of tests on d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pavolloffay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| go-import | github.com/hypertrace/javaagent git https://github.com/hypertrace/javaagent.git |
| octolytics-dimension-user_id | 65374698 |
| octolytics-dimension-user_login | hypertrace |
| octolytics-dimension-repository_id | 302314733 |
| octolytics-dimension-repository_nwo | hypertrace/javaagent |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 302314733 |
| octolytics-dimension-repository_network_root_nwo | hypertrace/javaagent |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width