René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"observe block won't return false","articleBody":"Manually defining state getters with an observe block will return `nil` when the return value is false\r\n\r\n```ruby\r\nclass MyStore\r\n  include Hyperstack::State::Observable\r\n\r\n  def my_state\r\n    observe { @my_state }\r\n  end\r\n\r\n  def my_state=(value)\r\n    mutate { @my_state = value }\r\n  end\r\nend\r\n\r\nstore = MyStore.new\r\n\r\nstore.my_state\r\n# =\u003e nil\r\n\r\nstore.my_state = true\r\n# =\u003e true\r\n\r\nstore.my_state = false\r\n#=\u003e nil\r\n```\r\n\r\nLooking at the code for observe, if the block doesn't return a truthy value it instead returns the last arg passed in\r\n\r\n```ruby\r\n# lib/hyperstack/state/observable.rb:14\r\n          base.send(:\"define_#{kind}\", :observe) do |*args, \u0026block|\r\n            result = block \u0026\u0026 block.call || args.last\r\n            Internal::State::Mapper.observed! self\r\n            result\r\n          end\r\n```\r\n\r\nI think it should instead set to the result to `block.call` if the block exists, otherwise use `args.last` instead of relying on the return value of the block to determine whether or not to use `args.last`\r\n\r\n```ruby\r\n# lib/hyperstack/state/observable.rb:14\r\n          base.send(:\"define_#{kind}\", :observe) do |*args, \u0026block|\r\n            result = block_given? ? block.call : args.last\r\n            Internal::State::Mapper.observed! self\r\n            result\r\n          end\r\n```","author":{"url":"https://github.com/adamcreekroad","@type":"Person","name":"adamcreekroad"},"datePublished":"2020-10-29T16:22:20.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/322/hyperstack/issues/322"}