René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"hyper-model reflects on associations of sibling STI class","articleBody":"This is only an issue when using STI classes that have their own associations.\r\n\r\nAn example:\r\n\r\n```ruby\r\nclass Owner \u003c ApplicationRecord\r\n  has_many :pets\r\nend\r\n\r\nclass Bone \u003c ApplicationRecord\r\n  belongs_to :dog\r\nend\r\n\r\nclass ScratchingPost \u003c ApplicationRecord\r\n  belongs_to :cat\r\nend\r\n\r\nclass Pet \u003c ApplicationRecord\r\n  belongs_to :owner\r\nend\r\n\r\nclass Dog \u003c Pet\r\n  has_many :bones\r\nend\r\n\r\nclass Cat \u003c Pet\r\n  has_many :scratching_posts\r\nend\r\n\r\nPet.reflect_on_all_associations\r\n# Currently\r\n#=\u003e [{ belongs_to: :owner, ... }, { has_many: :bones, ... }, { has_many: :scratching_posts, ... }]\r\n# Should be\r\n#=\u003e [{ belongs_to: :owner, ... }]\r\n\r\nDog.reflect_on_all_associations\r\n# Currently\r\n#=\u003e [{ belongs_to: :owner, ... }, { has_many: :bones, ... }, { has_many: :scratching_posts, ... }]\r\n# Should be\r\n#=\u003e [{ belongs_to: :owner, ... }, { has_many: :bones, ... }]\r\n\r\nCat.reflect_on_all_associations\r\n# Currently\r\n#=\u003e [{ belongs_to: :owner, ... }, { has_many: :bones, ... }, { has_many: :scratching_posts, ... }]\r\n# Should be\r\n#=\u003e [{ belongs_to: :owner, ... }, { has_many: :scratching_posts, ... }]\r\n```\r\n\r\nThe code that is doing this is \r\n\r\n```ruby\r\n def self.reflect_on_all_associations\r\n  base_class.instance_eval { @associations ||= superclass.instance_eval { (@associations \u0026\u0026 @associations.dup) || [] } }\r\nend\r\n```\r\n\r\nIt always reflects on the base_class, so that and all the inheriting get all the associations. This causes issues where hyper-model is trying to instantiate associations on the client, but they don't exist on that class but maybe its sibling's class the an error is thrown and the page goes blank.\r\n\r\nI'm thinking this was done before STI was implemented and the `type` column was looked at and used. But since that has been implemented, this should be fixed so that only the proper associations are reflected on and used.\r\n\r\nA fix would be\r\n```ruby\r\ndef self.reflect_on_all_associations\r\n  @associations ||= superclass.instance_eval { (@associations \u0026\u0026 @associations.dup) || [] }\r\nend\r\n```\r\n\r\nRun locally, all specs pass.","author":{"url":"https://github.com/adamcreekroad","@type":"Person","name":"adamcreekroad"},"datePublished":"2019-11-04T16:10:02.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/275/hyperstack/issues/275"}