René's URL Explorer Experiment


Title: when a record is destroyed make sure all "reactivity" is turned off during the update · Issue #195 · hyperstack-org/hyperstack · GitHub

Open Graph Title: when a record is destroyed make sure all "reactivity" is turned off during the update · Issue #195 · hyperstack-org/hyperstack

X Title: when a record is destroyed make sure all "reactivity" is turned off during the update · Issue #195 · hyperstack-org/hyperstack

Description: For example this spec will fail: context "updating a has_many relationship" do before(:each) do m = FactoryBot.create(:test_model, test_attribute: 'hello') FactoryBot.create(:child_model, test_model: m) mount "TestComponent3" do class In...

Open Graph Description: For example this spec will fail: context "updating a has_many relationship" do before(:each) do m = FactoryBot.create(:test_model, test_attribute: 'hello') FactoryBot.create(:child_model, test_mode...

X Description: For example this spec will fail: context "updating a has_many relationship" do before(:each) do m = FactoryBot.create(:test_model, test_attribute: 'hello') FactoryBot.create(:chil...

Opengraph URL: https://github.com/hyperstack-org/hyperstack/issues/195

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"when a record is destroyed make sure all \"reactivity\" is turned off during the update","articleBody":"For example this spec will fail:\r\n```ruby\r\n  context \"updating a has_many relationship\" do\r\n\r\n    before(:each) do\r\n\r\n      m = FactoryBot.create(:test_model, test_attribute: 'hello')\r\n      FactoryBot.create(:child_model, test_model: m)\r\n\r\n      mount \"TestComponent3\" do\r\n        class InnerComponent \u003c HyperComponent\r\n          param :child\r\n          render { LI { \"child id = #{@Child.id} #{@Child.test_model.test_attribute}\"} }\r\n        end\r\n        class TestComponent3 \u003c HyperComponent\r\n          render(OL) do\r\n            TestModel.all[0].child_models.each do |child|\r\n              InnerComponent(child: child)\r\n            end\r\n          end\r\n        end\r\n      end\r\n      page.should have_content('child id = 1')\r\n    end\r\n\r\n    it \"will update when sent from the server\" do\r\n      ChildModel.create(child_attribute: :foo, test_model: TestModel.find(1))\r\n      page.should have_content('child id = 2')\r\n      ChildModel.find(1).destroy\r\n      sleep 0.1 # necessary for poltergeist to work with pusher faker\r\n      page.should_not have_content('child id = 1', wait: 2)\r\n      page.should have_content('child id = 2')\r\n    end\r\nend\r\n```\r\nbecause `InnerComponent` accesses the child's `test_model`, which is set to nil when the child is destroyed (because we want to keep all the linkages nicely synchronized) but setting this to nil causes the component to re-rerender.  \r\n\r\nHere is a patch (not fully tested)\r\n\r\n```ruby\r\nmodule ReactiveRecord\r\n  class Base\r\n    alias destroy_associations_before_patch destroy_associations\r\n    def destroy_associations(*args, \u0026block)\r\n      @being_destroyed = true\r\n      destroy_associations_before_patch\r\n    end\r\n\r\n    alias change_status_and_notify_helper_before_patch change_status_and_notify_helper\r\n    def change_status_and_notify_helper(*args, \u0026block)\r\n      return if @being_destroyed\r\n      change_status_and_notify_helper_before_patch(*args, \u0026block)\r\n    end\r\n  end\r\nend\r\n```\r\n\r\nNote that simply wrapping the `destroy_associations` method with the `Base.loading` method will not work, as this will turn off notification for both sides of the relationship.  I.e. the has_many side will never re-render either, which it should.","author":{"url":"https://github.com/catmando","@type":"Person","name":"catmando"},"datePublished":"2019-06-12T20:42:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/195/hyperstack/issues/195"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fa7db553-dd77-8bed-9836-d96a217cc14f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB05E:804D0:12D7579:1817A7B:69919E51
html-safe-noncebcb9f9d3617303821950d4f4d9a76367ada6214d42f26ba64fff24de1add5e38
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDVFOjgwNEQwOjEyRDc1Nzk6MTgxN0E3Qjo2OTkxOUU1MSIsInZpc2l0b3JfaWQiOiI1MzExMzMwNzgxMDU4MTQ1ODczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace0718b2d54ebf3dc54a92bc6a62394e7446cad03c45b857256fc9f766985ff30
hovercard-subject-tagissue:455415230
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/hyperstack-org/hyperstack/195/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e0cd238f1127aa2b1800a66b1d4f0e34f2d9f3d3bff037e1db8da0be47c31b10/hyperstack-org/hyperstack/issues/195
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0cd238f1127aa2b1800a66b1d4f0e34f2d9f3d3bff037e1db8da0be47c31b10/hyperstack-org/hyperstack/issues/195
og:image:altFor example this spec will fail: context "updating a has_many relationship" do before(:each) do m = FactoryBot.create(:test_model, test_attribute: 'hello') FactoryBot.create(:child_model, test_mode...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecatmando
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/hyperstack-org/hyperstack git https://github.com/hyperstack-org/hyperstack.git
octolytics-dimension-user_id34562730
octolytics-dimension-user_loginhyperstack-org
octolytics-dimension-repository_id145879576
octolytics-dimension-repository_nwohyperstack-org/hyperstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id145879576
octolytics-dimension-repository_network_root_nwohyperstack-org/hyperstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/hyperstack-org/hyperstack/issues/195#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhyperstack-org%2Fhyperstack%2Fissues%2F195
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhyperstack-org%2Fhyperstack%2Fissues%2F195
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=hyperstack-org%2Fhyperstack
Reloadhttps://github.com/hyperstack-org/hyperstack/issues/195
Reloadhttps://github.com/hyperstack-org/hyperstack/issues/195
Reloadhttps://github.com/hyperstack-org/hyperstack/issues/195
hyperstack-org https://github.com/hyperstack-org
hyperstackhttps://github.com/hyperstack-org/hyperstack
Notifications https://github.com/login?return_to=%2Fhyperstack-org%2Fhyperstack
Fork 39 https://github.com/login?return_to=%2Fhyperstack-org%2Fhyperstack
Star 540 https://github.com/login?return_to=%2Fhyperstack-org%2Fhyperstack
Code https://github.com/hyperstack-org/hyperstack
Issues 164 https://github.com/hyperstack-org/hyperstack/issues
Pull requests 27 https://github.com/hyperstack-org/hyperstack/pulls
Actions https://github.com/hyperstack-org/hyperstack/actions
Wiki https://github.com/hyperstack-org/hyperstack/wiki
Security 0 https://github.com/hyperstack-org/hyperstack/security
Insights https://github.com/hyperstack-org/hyperstack/pulse
Code https://github.com/hyperstack-org/hyperstack
Issues https://github.com/hyperstack-org/hyperstack/issues
Pull requests https://github.com/hyperstack-org/hyperstack/pulls
Actions https://github.com/hyperstack-org/hyperstack/actions
Wiki https://github.com/hyperstack-org/hyperstack/wiki
Security https://github.com/hyperstack-org/hyperstack/security
Insights https://github.com/hyperstack-org/hyperstack/pulse
New issuehttps://github.com/login?return_to=https://github.com/hyperstack-org/hyperstack/issues/195
New issuehttps://github.com/login?return_to=https://github.com/hyperstack-org/hyperstack/issues/195
when a record is destroyed make sure all "reactivity" is turned off during the updatehttps://github.com/hyperstack-org/hyperstack/issues/195#top
bugSomething isn't workinghttps://github.com/hyperstack-org/hyperstack/issues?q=state%3Aopen%20label%3A%22bug%22
ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branchhttps://github.com/hyperstack-org/hyperstack/issues?q=state%3Aopen%20label%3A%22ready-to-release%22
alpha1.5https://github.com/hyperstack-org/hyperstack/milestone/3
https://github.com/catmando
https://github.com/catmando
catmandohttps://github.com/catmando
on Jun 12, 2019https://github.com/hyperstack-org/hyperstack/issues/195#issue-455415230
bugSomething isn't workinghttps://github.com/hyperstack-org/hyperstack/issues?q=state%3Aopen%20label%3A%22bug%22
ready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branchhttps://github.com/hyperstack-org/hyperstack/issues?q=state%3Aopen%20label%3A%22ready-to-release%22
alpha1.5No due datehttps://github.com/hyperstack-org/hyperstack/milestone/3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.