René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"nested component class lookup fails","articleBody":"For example this test case will fail:\r\n\r\n```ruby\r\n  it 'Looks up components in nested namespaces correctly' do\r\n    mount 'Foo::Bar::Zoom' do\r\n      module Foo\r\n        module Bar\r\n          class Zoom \u003c HyperComponent\r\n            render do\r\n              Wham()\r\n            end\r\n          end\r\n        end\r\n      end\r\n\r\n      module Wham\r\n      end\r\n\r\n      module Foo\r\n        module Bar\r\n          class Wham \u003c HyperComponent\r\n            render(DIV) do\r\n              \"found me!\"\r\n            end\r\n          end\r\n        end\r\n      end\r\n    end\r\n    expect(page).to have_content('found me!')\r\n  end\r\n```\r\n\r\nThe problem is in the `lookup_const` method in the `Tags` module the `const_defined?` and `const_get` calls must include the second `false` parameter to prevent looking up the ancestor tree.\r\n\r\nYou can patch it like this:\r\n\r\n```ruby\r\nmodule Hyperstack\r\n  module Internal\r\n    module Component    \r\n      module Tags\r\n        def lookup_const(name)\r\n          return nil unless name =~ /^[A-Z]/\r\n          scopes = self.class.name.to_s.split('::').inject([Object]) do |nesting, next_const|\r\n            nesting + [nesting.last.const_get(next_const)]\r\n          end.reverse\r\n          scope = scopes.detect { |s| s.const_defined?(name, false) }\r\n          scope.const_get(name, false) if scope\r\n        end\r\n      end\r\n    end\r\n  end\r\nend\r\n```\r\nFor the hyperloop legacy branch the same method is in\r\n```ruby\r\nmodule React\r\n  module Component\r\n    module Tags\r\n      def lookup_const(name) \r\n        ...\r\n      end\r\n    end\r\n  end\r\nend\r\n```\r\n\r\nHowever this has a knock on effect that breaks hyper-model's INPUT tag redefinition.  In that method redefinition the newly defined tag constants are made on the Tag module scope (incorrectly) and this bug allowed that to work.  So that has to also be fixed, i.e. the new tags need to be defined against Object.\r\n\r\n","author":{"url":"https://github.com/catmando","@type":"Person","name":"catmando"},"datePublished":"2019-05-02T00:05:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/181/hyperstack/issues/181"}