René's URL Explorer Experiment


Title: Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests by HoneyryderChuck · Pull Request #3 · http-parser/http-parser.java · GitHub

Open Graph Title: Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests by HoneyryderChuck · Pull Request #3 · http-parser/http-parser.java

X Title: Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests by HoneyryderChuck · Pull Request #3 · http-parser/http-parser.java

Description: Coming back from here and here. Currently. the #on_headers_complete callback is being fired 2 times when a request with chunked body is parsed. An example that demonstrates the issue can be found here. I've built against my fix locally and tested my ruby script, and it fixes the issue. I didn't add a java test, as the README doesn't tell me how can I setup the environment and run my tests, which is information I'd need before start doing something.

Open Graph Description: Coming back from here and here. Currently. the #on_headers_complete callback is being fired 2 times when a request with chunked body is parsed. An example that demonstrates the issue can be found h...

X Description: Coming back from here and here. Currently. the #on_headers_complete callback is being fired 2 times when a request with chunked body is parsed. An example that demonstrates the issue can be found h...

Opengraph URL: https://github.com/http-parser/http-parser.java/pull/3

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:726e6c95-7cb3-6497-0dcb-8e042d0ff0aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD17A:126D75:1548677:1F0B38A:6A4E495F
html-safe-noncef16c8ec1b2d35707a38338075afa2abf60e1963a32edfc047baedd6bf5cc0293
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTdBOjEyNkQ3NToxNTQ4Njc3OjFGMEIzOEE6NkE0RTQ5NUYiLCJ2aXNpdG9yX2lkIjoiOTAwMTg0NzY5NzIwODkyMDQxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5cd305b45be9aef32e29c11857cca1521fedec3930fbf107ceedaea3f41100a6
hovercard-subject-tagpull_request:145471125
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/http-parser/http-parser.java/pull/3/files
twitter:imagehttps://avatars.githubusercontent.com/u/215707?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/215707?s=400&v=4
og:image:altComing back from here and here. Currently. the #on_headers_complete callback is being fired 2 times when a request with chunked body is parsed. An example that demonstrates the issue can be found h...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/http-parser/http-parser.java git https://github.com/http-parser/http-parser.java.git
octolytics-dimension-user_id1701775
octolytics-dimension-user_loginhttp-parser
octolytics-dimension-repository_id4212336
octolytics-dimension-repository_nwohttp-parser/http-parser.java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id997318
octolytics-dimension-repository_parent_nwoa2800276/http-parser.java
octolytics-dimension-repository_network_root_id997318
octolytics-dimension-repository_network_root_nwoa2800276/http-parser.java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8506f6d0538364886e3f0153c154c410965e70d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/http-parser/http-parser.java/pull/3/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhttp-parser%2Fhttp-parser.java%2Fpull%2F3%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhttp-parser%2Fhttp-parser.java%2Fpull%2F3%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=http-parser%2Fhttp-parser.java
Reloadhttps://github.com/http-parser/http-parser.java/pull/3/files
Reloadhttps://github.com/http-parser/http-parser.java/pull/3/files
Reloadhttps://github.com/http-parser/http-parser.java/pull/3/files
Please reload this pagehttps://github.com/http-parser/http-parser.java/pull/3/files
http-parser https://github.com/http-parser
http-parser.javahttps://github.com/http-parser/http-parser.java
a2800276/http-parser.javahttps://github.com/a2800276/http-parser.java
Notifications https://github.com/login?return_to=%2Fhttp-parser%2Fhttp-parser.java
Fork 12 https://github.com/login?return_to=%2Fhttp-parser%2Fhttp-parser.java
Star 20 https://github.com/login?return_to=%2Fhttp-parser%2Fhttp-parser.java
Code https://github.com/http-parser/http-parser.java
Issues 0 https://github.com/http-parser/http-parser.java/issues
Pull requests 2 https://github.com/http-parser/http-parser.java/pulls
Actions https://github.com/http-parser/http-parser.java/actions
Projects https://github.com/http-parser/http-parser.java/projects
Wiki https://github.com/http-parser/http-parser.java/wiki
Security and quality 0 https://github.com/http-parser/http-parser.java/security
Insights https://github.com/http-parser/http-parser.java/pulse
Code https://github.com/http-parser/http-parser.java
Issues https://github.com/http-parser/http-parser.java/issues
Pull requests https://github.com/http-parser/http-parser.java/pulls
Actions https://github.com/http-parser/http-parser.java/actions
Projects https://github.com/http-parser/http-parser.java/projects
Wiki https://github.com/http-parser/http-parser.java/wiki
Security and quality https://github.com/http-parser/http-parser.java/security
Insights https://github.com/http-parser/http-parser.java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fhttp-parser%2Fhttp-parser.java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fhttp-parser%2Fhttp-parser.java%2Fissues%2Fnew%2Fchoose
HoneyryderChuckhttps://github.com/HoneyryderChuck
http-parser:masterhttps://github.com/http-parser/http-parser.java/tree/master
HoneyryderChuck:masterhttps://github.com/HoneyryderChuck/http-parser.java/tree/master
Conversation 0 https://github.com/http-parser/http-parser.java/pull/3
Commits 2 https://github.com/http-parser/http-parser.java/pull/3/commits
Checks 0 https://github.com/http-parser/http-parser.java/pull/3/checks
Files changed https://github.com/http-parser/http-parser.java/pull/3/files
Please reload this pagehttps://github.com/http-parser/http-parser.java/pull/3/files
Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests https://github.com/http-parser/http-parser.java/pull/3/files#top
Show all changes 2 commits https://github.com/http-parser/http-parser.java/pull/3/files
1d6cef0 Always call on_message_begin for start_req_or_res atambo May 26, 2013 https://github.com/http-parser/http-parser.java/pull/3/commits/1d6cef028e4c074f6d59d9f57e974e2d39406503
2fbc8cf removing the headers complete callback from when finishing parsing a … Oct 7, 2017 https://github.com/http-parser/http-parser.java/pull/3/commits/2fbc8cf6c5c102133cfb1632672ffeb8fee11924
Clear filters https://github.com/http-parser/http-parser.java/pull/3/files
Please reload this pagehttps://github.com/http-parser/http-parser.java/pull/3/files
Please reload this pagehttps://github.com/http-parser/http-parser.java/pull/3/files
src/impl/http_parser/lolevel/HTTPParser.javahttps://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
View file https://github.com/http-parser/http-parser.java/blob/2fbc8cf6c5c102133cfb1632672ffeb8fee11924/src/impl/http_parser/lolevel/HTTPParser.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/http-parser/http-parser.java/pull/3/{{ revealButtonHref }}
https://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
https://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
https://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
https://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
https://github.com/http-parser/http-parser.java/pull/3/files#diff-bbda4218ce2aee02db1907fbfcf1af604a7022f081a77017ced9dc222bcef035
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.