Title: Use of six.text type for comparison in treewalker._base · Issue #63 · html5lib/html5lib-python · GitHub
Open Graph Title: Use of six.text type for comparison in treewalker._base · Issue #63 · html5lib/html5lib-python
X Title: Use of six.text type for comparison in treewalker._base · Issue #63 · html5lib/html5lib-python
Description: all over the in the file html5lib/treewalkers/_base.py there are places where isinstance is used and the variable is compared to six.text_type instead of six.string_types On Python 2, six.text_type = unicode, this means that if an attrib...
Open Graph Description: all over the in the file html5lib/treewalkers/_base.py there are places where isinstance is used and the variable is compared to six.text_type instead of six.string_types On Python 2, six.text_type...
X Description: all over the in the file html5lib/treewalkers/_base.py there are places where isinstance is used and the variable is compared to six.text_type instead of six.string_types On Python 2, six.text_type...
Opengraph URL: https://github.com/html5lib/html5lib-python/issues/63
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Use of six.text type for comparison in treewalker._base","articleBody":"all over the in the file html5lib/treewalkers/_base.py there are places where isinstance is used and the variable is compared to six.text_type instead of six.string_types\n\nOn Python 2, six.text_type = unicode, this means that if an attribute of value passed in is str, then there will be an assertion error. \n\non Python 2: \n- six.string_types = (basestring,)\n- six.text_type = unicode\n\non Python 3:\n- six.string_types = (builtins.str, )\n- six.text_type = builtins.str\n\nSo I think the values should be compared against six.string_types and then six.text_type be used to coerce them for output.\n","author":{"url":"https://github.com/marcdm","@type":"Person","name":"marcdm"},"datePublished":"2013-06-16T18:18:56.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/63/html5lib-python/issues/63"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:82ae9cef-4832-7efb-4614-3e859fcd48a9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AF36:27B1FA:54E69E:706273:696B4267 |
| html-safe-nonce | 1dc55818f09e7be5b5e960d6082bffbaaa739da9299876faa657eb182797bcaf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjM2OjI3QjFGQTo1NEU2OUU6NzA2MjczOjY5NkI0MjY3IiwidmlzaXRvcl9pZCI6IjcyMzUzODk1MTczNTMxNDA4MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 23b04f4acc21d3e63084c42698a46665e28c9125d5292af1d8412c4fd8b6f2d5 |
| hovercard-subject-tag | issue:15608560 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/html5lib/html5lib-python/63/issue_layout |
| twitter:image | https://opengraph.githubassets.com/988a30c6f63675b64f08bc0c62e84499c7b6042a453da9c765767fb067e3eeb6/html5lib/html5lib-python/issues/63 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/988a30c6f63675b64f08bc0c62e84499c7b6042a453da9c765767fb067e3eeb6/html5lib/html5lib-python/issues/63 |
| og:image:alt | all over the in the file html5lib/treewalkers/_base.py there are places where isinstance is used and the variable is compared to six.text_type instead of six.string_types On Python 2, six.text_type... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | marcdm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/html5lib/html5lib-python git https://github.com/html5lib/html5lib-python.git |
| octolytics-dimension-user_id | 4092973 |
| octolytics-dimension-user_login | html5lib |
| octolytics-dimension-repository_id | 9322649 |
| octolytics-dimension-repository_nwo | html5lib/html5lib-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9322649 |
| octolytics-dimension-repository_network_root_nwo | html5lib/html5lib-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width