René's URL Explorer Experiment


Title: Remove event parameter by yfre · Pull Request #134 · hap-java/HAP-Java · GitHub

Open Graph Title: Remove event parameter by yfre · Pull Request #134 · hap-java/HAP-Java

X Title: Remove event parameter by yfre · Pull Request #134 · hap-java/HAP-Java

Description: "event" is payload parameter used to subscribe or unsubscribe to/from event notification. e.g. controller sends "event:true" to the HAP accessory if it wants to get event notifications. it is unclear from the specification whether it should be sent with accessory description or not. it is marked as optional. Java-HAP was always sending it with the value "false". however, the recent version of home app stops working if this parameter is in the payload for some accessory types, e.g. ColorTemperature. (reported here openhab/openhab-addons#9799 and here https://community.openhab.org/t/homekit-color-temperature-with-hue-bulbs/105658). I could also re-produce this behaviour. this PR removes "event" parameter from the payload.

Open Graph Description: "event" is payload parameter used to subscribe or unsubscribe to/from event notification. e.g. controller sends "event:true" to the HAP accessory if it wants to get event notifi...

X Description: "event" is payload parameter used to subscribe or unsubscribe to/from event notification. e.g. controller sends "event:true" to the HAP accessory if it wants to ...

Opengraph URL: https://github.com/hap-java/HAP-Java/pull/134

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f535098-458c-7be7-1ce2-e78124314d18
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8FFC:2E3323:2CB57D8:3DE78AB:6977AEF0
html-safe-nonce6dcb5fe0656d10090864092d1a272f68aa3d71f166328661fcf4a5549821af3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkZDOjJFMzMyMzoyQ0I1N0Q4OjNERTc4QUI6Njk3N0FFRjAiLCJ2aXNpdG9yX2lkIjoiMTgwMzQ5NTM5ODI5NTcxMTQ3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac18b949740c2720661e5d37158ab1b5b1b1492b6fe2488f66bfd699eb23111cb6
hovercard-subject-tagpull_request:560594045
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/hap-java/HAP-Java/pull/134/files
twitter:imagehttps://avatars.githubusercontent.com/u/11726616?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11726616?s=400&v=4
og:image:alt"event" is payload parameter used to subscribe or unsubscribe to/from event notification. e.g. controller sends "event:true" to the HAP accessory if it wants to get event notifi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd86879038a75d35d75e56f263b8ad57328b023c6a7de3aa5f9ca0dfd46935bb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/hap-java/HAP-Java git https://github.com/hap-java/HAP-Java.git
octolytics-dimension-user_id47992845
octolytics-dimension-user_loginhap-java
octolytics-dimension-repository_id31193475
octolytics-dimension-repository_nwohap-java/HAP-Java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31193475
octolytics-dimension-repository_network_root_nwohap-java/HAP-Java
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8458c691435c924883b72423ecd12134159e1b18
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/hap-java/HAP-Java/pull/134/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhap-java%2FHAP-Java%2Fpull%2F134%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhap-java%2FHAP-Java%2Fpull%2F134%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=hap-java%2FHAP-Java
Reloadhttps://github.com/hap-java/HAP-Java/pull/134/files
Reloadhttps://github.com/hap-java/HAP-Java/pull/134/files
Reloadhttps://github.com/hap-java/HAP-Java/pull/134/files
hap-java https://github.com/hap-java
HAP-Javahttps://github.com/hap-java/HAP-Java
Notifications https://github.com/login?return_to=%2Fhap-java%2FHAP-Java
Fork 84 https://github.com/login?return_to=%2Fhap-java%2FHAP-Java
Star 160 https://github.com/login?return_to=%2Fhap-java%2FHAP-Java
Code https://github.com/hap-java/HAP-Java
Issues 10 https://github.com/hap-java/HAP-Java/issues
Pull requests 1 https://github.com/hap-java/HAP-Java/pulls
Actions https://github.com/hap-java/HAP-Java/actions
Projects 0 https://github.com/hap-java/HAP-Java/projects
Wiki https://github.com/hap-java/HAP-Java/wiki
Security 0 https://github.com/hap-java/HAP-Java/security
Insights https://github.com/hap-java/HAP-Java/pulse
Code https://github.com/hap-java/HAP-Java
Issues https://github.com/hap-java/HAP-Java/issues
Pull requests https://github.com/hap-java/HAP-Java/pulls
Actions https://github.com/hap-java/HAP-Java/actions
Projects https://github.com/hap-java/HAP-Java/projects
Wiki https://github.com/hap-java/HAP-Java/wiki
Security https://github.com/hap-java/HAP-Java/security
Insights https://github.com/hap-java/HAP-Java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fhap-java%2FHAP-Java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fhap-java%2FHAP-Java%2Fissues%2Fnew%2Fchoose
ccutrerhttps://github.com/ccutrer
hap-java:masterhttps://github.com/hap-java/HAP-Java/tree/master
yfre:remove_event_paramhttps://github.com/yfre/HAP-Java/tree/remove_event_param
Conversation 0 https://github.com/hap-java/HAP-Java/pull/134
Commits 1 https://github.com/hap-java/HAP-Java/pull/134/commits
Checks 0 https://github.com/hap-java/HAP-Java/pull/134/checks
Files changed https://github.com/hap-java/HAP-Java/pull/134/files
Please reload this pagehttps://github.com/hap-java/HAP-Java/pull/134/files
Remove event parameter https://github.com/hap-java/HAP-Java/pull/134/files#top
Show all changes 1 commit https://github.com/hap-java/HAP-Java/pull/134/files
87bab73 remove optional event parameters. it breaks some accessories in home app Jan 24, 2021 https://github.com/hap-java/HAP-Java/pull/134/commits/87bab73be807fec98b4f51b4a97326e3fd21045a
Clear filters https://github.com/hap-java/HAP-Java/pull/134/files
Please reload this pagehttps://github.com/hap-java/HAP-Java/pull/134/files
Please reload this pagehttps://github.com/hap-java/HAP-Java/pull/134/files
src/main/java/io/github/hapjava/characteristics/impl/base/BaseCharacteristic.javahttps://github.com/hap-java/HAP-Java/pull/134/files#diff-915affc488975bb6c963c8c637cf6d62748b94ff974b4f45096e23b4f1e46784
View file https://github.com/yfre/HAP-Java/blob/87bab73be807fec98b4f51b4a97326e3fd21045a/src/main/java/io/github/hapjava/characteristics/impl/base/BaseCharacteristic.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/hap-java/HAP-Java/pull/134/{{ revealButtonHref }}
https://github.com/hap-java/HAP-Java/pull/134/files#diff-915affc488975bb6c963c8c637cf6d62748b94ff974b4f45096e23b4f1e46784
https://github.com/hap-java/HAP-Java/pull/134/files#diff-915affc488975bb6c963c8c637cf6d62748b94ff974b4f45096e23b4f1e46784
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.