René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"HomekitRoot leaks connections in it's subscriptionManager when calling \"start\" then \"stop\"","articleBody":"I've come to notice this issue when working on the Homekit extension for Openhab2. When I reload the bundle, it calls `homekitRoot.stop()`, followed by a reload of the Java classes, followed by a `homekitRoot.start()`. What I'm noticing is that the subscriptions from before are accumulating, resulting in more and more [`SubscriptionManager::publish`](https://github.com/beowulfe/HAP-Java/blob/3ec72649c59671d2d917fa9072bdd6aef55bccaa/src/main/java/com/beowulfe/hap/impl/connections/SubscriptionManager.java#L84) calls with each reload.\r\n\r\nHere's what I'll see in the logs when toggling a homekit switch from the iOS client during the first load:\r\n\r\n```\r\n11:22:58.773 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n```\r\n\r\nThen, after, say, 5 reloads of the bundle (resulting in a call to `HomekitRoot::stop()` and `HomekitRoot::start() each time`, toggling a switch from the iOS client will cause that message to be logged an additional five times:\r\n\r\n```\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n12:03:21.146 [INFO ] [.impl.connections.SubscriptionManager] - Publishing changes for 612672328\r\n```\r\n\r\nAfter digging around, it looks like [characteristic.unsubscribe() in SubscriptionManage.java#L71](https://github.com/beowulfe/HAP-Java/blob/3ec72649c59671d2d917fa9072bdd6aef55bccaa/src/main/java/com/beowulfe/hap/impl/connections/SubscriptionManager.java#L71) isn't getting called during `stop()`. I added some log messages to log when a connection is removed via [SubscriptionManager::removeConnection()](https://github.com/beowulfe/HAP-Java/blob/3ec72649c59671d2d917fa9072bdd6aef55bccaa/src/main/java/com/beowulfe/hap/impl/connections/SubscriptionManager.java#L64) and [SubscriptionManager::removeSubscription(...)](https://github.com/beowulfe/HAP-Java/blob/3ec72649c59671d2d917fa9072bdd6aef55bccaa/src/main/java/com/beowulfe/hap/impl/connections/SubscriptionManager.java#L48), and neither are invoked nor do connections appear to be ever removed. I'm not sure what mechanism is expected to clean these up, but the failure to have these cleaned up is what's leading to the accumulation of characteristic subscriptions.","author":{"url":"https://github.com/timcharper","@type":"Person","name":"timcharper"},"datePublished":"2019-01-21T20:56:19.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/54/HAP-Java/issues/54"}