René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Model year incorrectly identified for certain heavy vehicles","articleBody":"# Issue\r\nThe current implementation of `Vin.year` returns the incorrect year for some heavy trucks and vans:\r\n\r\n```python\r\nIn [1]: from libvin import Vin\r\n\r\nIn [2]: v = Vin('1FUJGLDR69LAC9984')\r\n\r\nIn [3]: v.year\r\nOut[3]: 2039\r\n\r\nIn [4]: v.is_pre_2010\r\nOut[4]: False\r\n```\r\nThe correct model year for this VIN is 2009 [(source)](https://www.vindecoderz.com/EN/check-lookup/1FUJGLDR69LAC9984).\r\n\r\nFor vehicles with a gross vehicle weight rating (GVWR) over 10,000 lbs the 7th digit of the VIN does not indicate if the vehicles was manufactured before or after 2009 as it does for passenger vehicles.\r\n\r\n# Potential solutions\r\nOne potential solution(https://github.com/emesterhazy/python-libvin/commit/58de6905448b774de2127944b76198400b3f46e7) is to check `Vin.year` and overwrite the `is_pre_2010` condition if the model year is more than X years into the future. For the example above, the fix would check the model year when the `Vin` object is created, and overwrite the `is_pre_2010` property since 2039 is too far into the future. Then when `Vin.year` is accessed it will return the correct year (2009), and `Vin.is_pre_2010` will return `True`.\r\n\r\n```python\r\nclass Vin(object):\r\n    def __init__(self, vin):\r\n        self.vin = vin.upper()\r\n\r\n        # Overwrite is_pre_2010 attribute if it would result in a model year\r\n        # more than 2 years into the future. See notes in is_pre_2010\r\n        self._pre_2010_overwrite = False\r\n        if (not self.is_pre_2010 and\r\n                YEARS_CODES_PRE_2040[self.vin[9]] \u003e= datetime.now().year + 2):\r\n            self._pre_2010_overwrite = True\r\n\r\n...\r\n\r\n    @property\r\n        def is_pre_2010(self):\r\n\r\n            if self._pre_2010_overwrite:\r\n                return True\r\n            else:\r\n                return self.vin[6].isdigit()\r\n\r\n```\r\n\r\nThe downside to this is that the fix will also \"correct\" valid passenger car VINs for vehicles with model years more than 2 years into the future. However, I don't think this will be an issue in real world use.\r\n\r\nI have a pull request ready if you agree with this approach.","author":{"url":"https://github.com/emesterhazy","@type":"Person","name":"emesterhazy"},"datePublished":"2018-08-25T16:43:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/24/python-libvin/issues/24"}