René's URL Explorer Experiment


Title: Improved item placement in _updateNodeWidths() by dswitzer · Pull Request #822 · gridstack/gridstack.js · GitHub

Open Graph Title: Improved item placement in _updateNodeWidths() by dswitzer · Pull Request #822 · gridstack/gridstack.js

X Title: Improved item placement in _updateNodeWidths() by dswitzer · Pull Request #822 · gridstack/gridstack.js

Description: Description I noticed there are several bugs in the GridStack.prototype._updateNodeWidths that can lead to elements not being placed correctly when the grid size changes. This causes issues when trying to use Gridstack in a responsive design. Here's a summary of what my patch changes: Not all the items are guaranteed to be processed. This is because the update() method can change the this.grid.nodes array. This can lead to items being ignored. The code now processes each item in the grid. The code does not correctly confine items to the grid's width. This code adds sanity checks to make sure that an item is always placed inside the grid and that it's width does not overlap the grid's width. Checklist Created tests which fail without the change (if possible) All tests passing (npm test) Extended the README / documentation, if necessary

Open Graph Description: Description I noticed there are several bugs in the GridStack.prototype._updateNodeWidths that can lead to elements not being placed correctly when the grid size changes. This causes issues when tr...

X Description: Description I noticed there are several bugs in the GridStack.prototype._updateNodeWidths that can lead to elements not being placed correctly when the grid size changes. This causes issues when tr...

Opengraph URL: https://github.com/gridstack/gridstack.js/pull/822

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:acf8f691-9f46-bac1-9402-94093cdcaffb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE34:1A666C:5D384:7DBFB:6AFF5D58
html-safe-nonce91d5851e901e1159fa6337826eccd4c707ff9cd52bbaf2fa5eb836b98b5c7480
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTM0OjFBNjY2Qzo1RDM4NDo3REJGQjo2QUZGNUQ1OCIsInZpc2l0b3JfaWQiOiIzOTc1OTAxNDEwMTAwMjA2OTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1fb7acd395cee857f3b5e19201bb7f77be190cc2df25a02c8cb9d49fff9bc21e
hovercard-subject-tagpull_request:155434272
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gridstack/gridstack.js/pull/822/files
twitter:imagehttps://avatars.githubusercontent.com/u/900497?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/900497?s=400&v=4
og:image:altDescription I noticed there are several bugs in the GridStack.prototype._updateNodeWidths that can lead to elements not being placed correctly when the grid size changes. This causes issues when tr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2422ccd4bc783f932948cce4871cb9e0622bab749db07f387c9631b7e6834d1f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gridstack/gridstack.js git https://github.com/gridstack/gridstack.js.git
octolytics-dimension-user_id31674162
octolytics-dimension-user_logingridstack
octolytics-dimension-repository_id26417283
octolytics-dimension-repository_nwogridstack/gridstack.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26417283
octolytics-dimension-repository_network_root_nwogridstack/gridstack.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2a39546baeb98186e651a01d5d7aa6465825eeb1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gridstack/gridstack.js/pull/822/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fpull%2F822%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fpull%2F822%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gridstack%2Fgridstack.js
Reloadhttps://github.com/gridstack/gridstack.js/pull/822/files
Reloadhttps://github.com/gridstack/gridstack.js/pull/822/files
Reloadhttps://github.com/gridstack/gridstack.js/pull/822/files
gridstackhttps://github.com/gridstack
gridstack.jshttps://github.com/gridstack/gridstack.js
Codehttps://github.com/gridstack/gridstack.js
Issues17 (17)https://github.com/gridstack/gridstack.js/issues
Pull requests3 (3)https://github.com/gridstack/gridstack.js/pulls
Actionshttps://github.com/gridstack/gridstack.js/actions
Projectshttps://github.com/gridstack/gridstack.js/projects
Wikihttps://github.com/gridstack/gridstack.js/wiki
Security and qualityhttps://github.com/gridstack/gridstack.js/security
Insightshttps://github.com/gridstack/gridstack.js/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgridstack%2Fgridstack.js%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgridstack%2Fgridstack.js%2Fissues%2Fnew%2Fchoose
dswitzerhttps://github.com/dswitzer
gridstack:develophttps://github.com/gridstack/gridstack.js/tree/develop
dswitzer:patch-1https://github.com/dswitzer/gridstack.js/tree/patch-1
Conversation 7 https://github.com/gridstack/gridstack.js/pull/822
Commits 1 https://github.com/gridstack/gridstack.js/pull/822/commits
Checks 0 https://github.com/gridstack/gridstack.js/pull/822/checks
Files changed https://github.com/gridstack/gridstack.js/pull/822/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/822/files
Improved item placement in _updateNodeWidths() https://github.com/gridstack/gridstack.js/pull/822/files#top
Show all changes 1 commit https://github.com/gridstack/gridstack.js/pull/822/files
2cbd04d Improved item placement in _updateNodeWidths() dswitzer Nov 29, 2017 https://github.com/gridstack/gridstack.js/pull/822/commits/2cbd04d8ecd2ced0188a013cb501491df4e414ba
Clear filters https://github.com/gridstack/gridstack.js/pull/822/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/822/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/822/files
src/gridstack.jshttps://github.com/gridstack/gridstack.js/pull/822/files#diff-6ab653006eaef2edd57e41f51fc2634cbe690dcfb43b4965b303314a0ccc2b34
View file https://github.com/dswitzer/gridstack.js/blob/2cbd04d8ecd2ced0188a013cb501491df4e414ba/src/gridstack.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/822/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/822/files#diff-6ab653006eaef2edd57e41f51fc2634cbe690dcfb43b4965b303314a0ccc2b34
adumesnyhttps://github.com/adumesny
Dec 19, 2019https://github.com/gridstack/gridstack.js/pull/822/files#r359670462
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/822/files
https://github.com/gridstack/gridstack.js/pull/822/files#diff-6ab653006eaef2edd57e41f51fc2634cbe690dcfb43b4965b303314a0ccc2b34
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.