René's URL Explorer Experiment


Title: collision: more edge case fixes by adumesny · Pull Request #1663 · gridstack/gridstack.js · GitHub

Open Graph Title: collision: more edge case fixes by adumesny · Pull Request #1663 · gridstack/gridstack.js

X Title: collision: more edge case fixes by adumesny · Pull Request #1663 · gridstack/gridstack.js

Description: Description fix #1094 found I needed to take entire row (not just new location) when doing collision to correctly push down bottom items first so they keep their order and prevent large objects from leapfrogging smaller ones. (like old code used to do) removed _beforeDrag and _packY fields and re-use existing _orig position data which simplifies things removed yOffset during _fixCollisions() as it was incorrect (reverse sorting should take care of that) on _leave() of external item, we now restore all items to original position using restoreInitial() (prevents any error from sticking) NEEDLESS to say, this is MUCH more complicated than the old _fixCollision() that moved to new loc then pushed anything down in that row and below (bottom first) which is dead simple... but required you to move 90% past the item when moving down. Checklist Created tests which fail without the change (if possible) All tests passing (yarn test) Extended the README / documentation, if necessary

Open Graph Description: Description fix #1094 found I needed to take entire row (not just new location) when doing collision to correctly push down bottom items first so they keep their order and prevent large objects fr...

X Description: Description fix #1094 found I needed to take entire row (not just new location) when doing collision to correctly push down bottom items first so they keep their order and prevent large objects fr...

Opengraph URL: https://github.com/gridstack/gridstack.js/pull/1663

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1836edbe-0bff-55c0-bba4-a88a2a037125
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA40E:36462:262AC9:36A30A:6AFEC70D
html-safe-nonceb5aca3fa1f1bf633b142b11cdf774fef8905392bbc4ac3b27e00f3d94dd99805
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDBFOjM2NDYyOjI2MkFDOTozNkEzMEE6NkFGRUM3MEQiLCJ2aXNpdG9yX2lkIjoiNzkyNDY1NDA1MDk1NDM2NDY4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7d0978d9836ec6bcc466d705cd7dc2cab8c244b96bbf7c2ed45ed52838bfdb43
hovercard-subject-tagpull_request:597225048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/gridstack/gridstack.js/pull/1663/files
twitter:imagehttps://avatars.githubusercontent.com/u/3496166?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3496166?s=400&v=4
og:image:altDescription fix #1094 found I needed to take entire row (not just new location) when doing collision to correctly push down bottom items first so they keep their order and prevent large objects fr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned8c1842fa8c1871211ad74f52ea520b67ae48004324d6e87b7e785d96d607625
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/gridstack/gridstack.js git https://github.com/gridstack/gridstack.js.git
octolytics-dimension-user_id31674162
octolytics-dimension-user_logingridstack
octolytics-dimension-repository_id26417283
octolytics-dimension-repository_nwogridstack/gridstack.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26417283
octolytics-dimension-repository_network_root_nwogridstack/gridstack.js
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release336c37170bdcca2f0ee691c238c77bbf8bd65264
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/gridstack/gridstack.js/pull/1663/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fpull%2F1663%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fpull%2F1663%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=gridstack%2Fgridstack.js
Reloadhttps://github.com/gridstack/gridstack.js/pull/1663/files
Reloadhttps://github.com/gridstack/gridstack.js/pull/1663/files
Reloadhttps://github.com/gridstack/gridstack.js/pull/1663/files
gridstackhttps://github.com/gridstack
gridstack.jshttps://github.com/gridstack/gridstack.js
Codehttps://github.com/gridstack/gridstack.js
Issues17 (17)https://github.com/gridstack/gridstack.js/issues
Pull requests3 (3)https://github.com/gridstack/gridstack.js/pulls
Actionshttps://github.com/gridstack/gridstack.js/actions
Projectshttps://github.com/gridstack/gridstack.js/projects
Wikihttps://github.com/gridstack/gridstack.js/wiki
Security and qualityhttps://github.com/gridstack/gridstack.js/security
Insightshttps://github.com/gridstack/gridstack.js/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgridstack%2Fgridstack.js%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgridstack%2Fgridstack.js%2Fissues%2Fnew%2Fchoose
adumesnyhttps://github.com/adumesny
gridstack:develophttps://github.com/gridstack/gridstack.js/tree/develop
adumesny:develophttps://github.com/adumesny/gridstack.js/tree/develop
Conversation 3 https://github.com/gridstack/gridstack.js/pull/1663
Commits 1 https://github.com/gridstack/gridstack.js/pull/1663/commits
Checks 0 https://github.com/gridstack/gridstack.js/pull/1663/checks
Files changed https://github.com/gridstack/gridstack.js/pull/1663/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/1663/files
collision: more edge case fixes https://github.com/gridstack/gridstack.js/pull/1663/files#top
Show all changes 1 commit https://github.com/gridstack/gridstack.js/pull/1663/files
7aa2d4e collision: more edge case fixes adumesny Mar 13, 2021 https://github.com/gridstack/gridstack.js/pull/1663/commits/7aa2d4ea65b8321afa1fe75537795ee4ff984baf
Clear filters https://github.com/gridstack/gridstack.js/pull/1663/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/1663/files
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/1663/files
LICENSE https://github.com/gridstack/gridstack.js/pull/1663/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7
two.html https://github.com/gridstack/gridstack.js/pull/1663/files#diff-726b47191eb939cc3b55bbfd27cf90582ea7a78dad4cb9a938da0e87e0ae9e92
CHANGES.md https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
package.json https://github.com/gridstack/gridstack.js/pull/1663/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
141_1534_swap.html https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
gridstack-dd.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
gridstack-ddi.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-168f8a1f0f58f2e17d35f7edd1c514d7ff22f9e162196431a9f988029e1c138a
gridstack-engine.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-62ee986279cc76672b19d96edd6a4ddc40246eb5370c927ed389195b6315c19c
gridstack-extra.scss https://github.com/gridstack/gridstack.js/pull/1663/files#diff-db9073d05018590e59553f08004b1ca84e23a8bef72985778f802f3b410cd716
gridstack-poly.js https://github.com/gridstack/gridstack.js/pull/1663/files#diff-109beb63ebd826ad98105f96feecda5fd3fb168bcf9f3f8fcff10f9cf558302e
gridstack.scss https://github.com/gridstack/gridstack.js/pull/1663/files#diff-5255904d94c7e1eec4cd7d514ce5c65dd17a85a4f5eb333cdf8749ab4921c482
gridstack.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-68833c62f34b191bd3b73049e061db3c2880749f28ecdcb6ecdbe09294a7b54e
dd-base-impl.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-aadad02bcb82d3cc1b99671c9524bda8b5968b4ee1508e56106668dc986c303f
dd-draggable.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-80ddd0719d88edebeedcbdf4ef6d96c79ca6421595c8d12e99569c884b3c97f2
dd-droppable.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-91fbb3da7cf3f7fb4285c57ed3a6bf725471f2f15627a22f611e235519dcc101
dd-element.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ea11caffe9613ea2ee8f26895dadf3a024ea2a1af562b3696ca77b587267eb9c
dd-manager.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-30076af4441af81d5101920a913cdaf8d37328d915cf86c3687b0a8308142b5f
dd-resizable-handle.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-a020b2df1fe0d0e1032c727acd9e0fa851b246d60d809e3d00503e0aeec7745e
dd-resizable.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-b240470e99037ca479c851a37381270596dfbf7a651fd6ccd153d392a3c38dc9
dd-utils.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-53339a463007133191887d704c95e7c90d45785c00f4c6d7c19d35ca493a0ffc
gridstack-dd-native.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-813a77a9b71efaf1183c881c17d8f5e936fff1a72b8ede0259c1878ab6021967
index-h5.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-97699eb5e3e7a9ae1ba3c1cf4d22c91f31da90e889f822e9767840f0d8f00745
index-jq.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-2ec6f740742f09b1be9c020b6ee59169882dc06728a32655609ee8b34f0c278f
index-static.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-26ed8cf8f699f84751d5328519f59575a8d917c16ffbe5d4d1679d076e075ffb
gridstack-dd-jqueryui.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-b790ae92fcf26750da1cb244a68f9dea5c24db35417a34286b8239a500a9c00a
types.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-c54113cf61ec99691748a3890bfbeb00e10efb3f0a76f03a0fd9ec49072e410a
utils.ts https://github.com/gridstack/gridstack.js/pull/1663/files#diff-39b2554fd18da165b59a6351b1aafff3714e2a80c1435f2de9706355b4d32351
LICENSEhttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/LICENSE
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7
demo/two.htmlhttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-726b47191eb939cc3b55bbfd27cf90582ea7a78dad4cb9a938da0e87e0ae9e92
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/demo/two.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-726b47191eb939cc3b55bbfd27cf90582ea7a78dad4cb9a938da0e87e0ae9e92
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-726b47191eb939cc3b55bbfd27cf90582ea7a78dad4cb9a938da0e87e0ae9e92
doc/CHANGES.mdhttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/doc/CHANGES.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-94424aecd97a5ecab8757f89441a9a0ffb8dcc2b97225160510673674e49deb2
package.jsonhttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
spec/e2e/html/141_1534_swap.htmlhttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/spec/e2e/html/141_1534_swap.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-86dfc56104c8b06111dc88f4463ddd14dccd7779b17c4503ecddbaa02cd269c5
src/gridstack-dd.tshttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/src/gridstack-dd.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-ec7af56b0381573510a04594acab2899c39f741fbe3dc6514d95d92176d23748
src/gridstack-ddi.tshttps://github.com/gridstack/gridstack.js/pull/1663/files#diff-168f8a1f0f58f2e17d35f7edd1c514d7ff22f9e162196431a9f988029e1c138a
View file https://github.com/adumesny/gridstack.js/blob/7aa2d4ea65b8321afa1fe75537795ee4ff984baf/src/gridstack-ddi.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/gridstack/gridstack.js/pull/1663/{{ revealButtonHref }}
https://github.com/gridstack/gridstack.js/pull/1663/files#diff-168f8a1f0f58f2e17d35f7edd1c514d7ff22f9e162196431a9f988029e1c138a
Please reload this pagehttps://github.com/gridstack/gridstack.js/pull/1663/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.