René's URL Explorer Experiment


Title: Animate doesn't work · Issue #937 · gridstack/gridstack.js · GitHub

Open Graph Title: Animate doesn't work · Issue #937 · gridstack/gridstack.js

X Title: Animate doesn't work · Issue #937 · gridstack/gridstack.js

Description: Animate doesn't work. You can try any* of the demos and add animate: true to them, and animation will not work. It doesn't matter whether you use the configuration object, data-gs-animate, or setAnimation() api. *Adding animate to the tw...

Open Graph Description: Animate doesn't work. You can try any* of the demos and add animate: true to them, and animation will not work. It doesn't matter whether you use the configuration object, data-gs-animate, or setAn...

X Description: Animate doesn't work. You can try any* of the demos and add animate: true to them, and animation will not work. It doesn't matter whether you use the configuration object, data-gs-animate, ...

Opengraph URL: https://github.com/gridstack/gridstack.js/issues/937

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Animate doesn't work","articleBody":"Animate doesn't work. You can try any* of the demos and add animate: true to them, and animation will not work. It doesn't matter whether you use the configuration object, data-gs-animate, or setAnimation() api.\r\n\r\n*Adding animate to the two-grid demo does work. Animate works as long as you have two or more grids on your page, see details below.\r\n\r\n## Your environment\r\nGridstack v 1.0.0-dev\r\nFirefox, Chrome, Edge, IE11\r\n\r\n## Steps to reproduce\r\nI have taken the float demo and simply added animate: true. See here:\r\nhttps://gridstackdemo.azurewebsites.net/demo/float.html\r\n\r\nNote that while rearranging items they are not animated. The grid itself (height, etc) is animated, the item being dragged is animated (when released). Other items pushed out of the way (by dragging a block around) will not be animated.\r\n\r\n## Expected behaviour\r\nAnimation should happen\r\n\r\n## Actual behaviour\r\nItems snap to position instead of animating.\r\n\r\n## Additional Information\r\nThe animation isn't happening because all of the style information containing \"top\" and \"height\" properties gets deleted and recreated constantly.  See here (this method is called constantly while dragging a block around):\r\nhttps://github.com/gridstack/gridstack.js/blob/7d9ac26847b89c593ab5ee5d778185091267d4d4/dist/gridstack.js#L1003\r\n\r\nSince the animation is based upon CSS transition, it fails to work since the code is simply removing \"top\", etc. For example, what's essentially happening is a block goes through this:\r\ntop: 0px\r\n-top property removed by stylesheet being deleted in javascript\r\n-new stylesheet is created\r\ntop: 80px\r\n\r\nOf course CSS can't transition between these states. Animation works as long as there are two or more grids because the other grid's stylesheet will still exist, and thus blocks will always have a top property instead of the interim undefined state. I would submit a pull request if I knew how to address this issue, but I'm at a loss why it is done this way.\r\n\r\nMy hacky workaround for the time being is to create my own stylesheet file with greater specificity so my blocks will always have some sort of top property.","author":{"url":"https://github.com/ermcgrat","@type":"Person","name":"ermcgrat"},"datePublished":"2018-08-16T18:04:23Z","url":"https://github.com/gridstack/gridstack.js/issues/937"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:90dadbb8-cfc1-2a35-2d6d-875719feb8f5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8FD4:1A1B84:76C75:A3804:6AFF4A78
html-safe-noncedbdf7fb300752fe3755986f3cb7c75ffd0bcaaeac6390ec792a8b57745f3f49c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkQ0OjFBMUI4NDo3NkM3NTpBMzgwNDo2QUZGNEE3OCIsInZpc2l0b3JfaWQiOiIyMTAzMDQ0NjM2Nzk1Njg1NDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfdd61de302aefe867d99bbc514a0cfd010a65d67c0fad225524c6154cbfc3473
hovercard-subject-tagissue:351310519
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/gridstack/gridstack.js/937/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6ec886231d5d1414c1250d9e53cca3e62b3c1875b43279b8fed1576de99b16c1/gridstack/gridstack.js/issues/937
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6ec886231d5d1414c1250d9e53cca3e62b3c1875b43279b8fed1576de99b16c1/gridstack/gridstack.js/issues/937
og:image:altAnimate doesn't work. You can try any* of the demos and add animate: true to them, and animation will not work. It doesn't matter whether you use the configuration object, data-gs-animate, or setAn...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameermcgrat
hostnamegithub.com
expected-hostnamegithub.com
None6672a281260b126053da5da19a6127ba7804ee26f255c9b12ad124a822a55cd0
turbo-cache-controlno-preview
go-importgithub.com/gridstack/gridstack.js git https://github.com/gridstack/gridstack.js.git
octolytics-dimension-user_id31674162
octolytics-dimension-user_logingridstack
octolytics-dimension-repository_id26417283
octolytics-dimension-repository_nwogridstack/gridstack.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id26417283
octolytics-dimension-repository_network_root_nwogridstack/gridstack.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release28805d6cf6280f5e10f2a6624504c872d9633a0f
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/gridstack/gridstack.js/issues/937#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fissues%2F937
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgridstack%2Fgridstack.js%2Fissues%2F937
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=gridstack%2Fgridstack.js
Reloadhttps://github.com/gridstack/gridstack.js/issues/937
Reloadhttps://github.com/gridstack/gridstack.js/issues/937
Reloadhttps://github.com/gridstack/gridstack.js/issues/937
gridstackhttps://github.com/gridstack
gridstack.jshttps://github.com/gridstack/gridstack.js
Codehttps://github.com/gridstack/gridstack.js
Issues17 (17)https://github.com/gridstack/gridstack.js/issues
Pull requests3 (3)https://github.com/gridstack/gridstack.js/pulls
Actionshttps://github.com/gridstack/gridstack.js/actions
Projectshttps://github.com/gridstack/gridstack.js/projects
Wikihttps://github.com/gridstack/gridstack.js/wiki
Security and qualityhttps://github.com/gridstack/gridstack.js/security
Insightshttps://github.com/gridstack/gridstack.js/insights
https://github.com/gridstack/gridstack.js
New issuehttps://github.com/login?return_to=https://github.com/gridstack/gridstack.js/issues/937
New issuehttps://github.com/login?return_to=https://github.com/gridstack/gridstack.js/issues/937
#1047https://github.com/gridstack/gridstack.js/pull/1047
Animate doesn't workhttps://github.com/gridstack/gridstack.js/issues/937#top
#1047https://github.com/gridstack/gridstack.js/pull/1047
type:bughttps://github.com/gridstack/gridstack.js/issues?q=state%3Aopen%20label%3A%22type%3Abug%22
https://github.com/ermcgrat
ermcgrathttps://github.com/ermcgrat
on Aug 16, 2018https://github.com/gridstack/gridstack.js/issues/937#issue-351310519
https://gridstackdemo.azurewebsites.net/demo/float.htmlhttps://gridstackdemo.azurewebsites.net/demo/float.html
gridstack.js/dist/gridstack.jshttps://github.com/gridstack/gridstack.js/blob/7d9ac26847b89c593ab5ee5d778185091267d4d4/dist/gridstack.js#L1003
7d9ac26https://github.com/gridstack/gridstack.js/commit/7d9ac26847b89c593ab5ee5d778185091267d4d4
https://github.com/JanStorm
JanStormhttps://github.com/JanStorm
on Jan 18, 2019https://github.com/gridstack/gridstack.js/issues/937#issuecomment-455607711
radiolipshttps://github.com/radiolips
on Nov 17, 2019https://github.com/gridstack/gridstack.js/issues/937#event-2805434829
Fix gridstack#937https://github.com/radiolips/gridstack.js/commit/ab419e1db64eb57de4fc422006043382cb1958e6
gridstack#937https://github.com/gridstack/gridstack.js/issues/937
https://docs.github.com/articles/closing-issues-via-commit-messages
ab419e1https://github.com/radiolips/gridstack.js/commit/ab419e1db64eb57de4fc422006043382cb1958e6
radiolipshttps://github.com/radiolips
completedhttps://github.com/gridstack/gridstack.js/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#1047https://github.com/gridstack/gridstack.js/pull/1047
on Nov 17, 2019https://github.com/gridstack/gridstack.js/issues/937#event-2805436291
radiolipshttps://github.com/radiolips
on Nov 17, 2019https://github.com/gridstack/gridstack.js/issues/937#event-2805436319
Merge pull request #1047 from radiolips/bugfix/937https://github.com/gridstack/gridstack.js/commit/dbe5850d9541fb7f5ab5ba68d1fcf3097aa00222
#1047https://github.com/gridstack/gridstack.js/pull/1047
https://docs.github.com/articles/closing-issues-via-commit-messages
dbe5850https://github.com/gridstack/gridstack.js/commit/dbe5850d9541fb7f5ab5ba68d1fcf3097aa00222
https://github.com/radiolips
radiolipshttps://github.com/radiolips
on Nov 17, 2019https://github.com/gridstack/gridstack.js/issues/937#issuecomment-554749654
@ermcgrathttps://github.com/ermcgrat
https://github.com/adumesny
adumesnyhttps://github.com/adumesny
on Nov 26, 2019https://github.com/gridstack/gridstack.js/issues/937#issuecomment-558716287
adumesnyhttps://github.com/adumesny
on Nov 26, 2019https://github.com/gridstack/gridstack.js/issues/937#event-2832665840
adumesnyhttps://github.com/adumesny
type:bughttps://github.com/gridstack/gridstack.js/issues?q=state%3Aopen%20label%3A%22type%3Abug%22
severity:minorhttps://github.com/gridstack/gridstack.js/issues?q=state%3Aopen%20label%3A%22severity%3Aminor%22
on Dec 21, 2019https://github.com/gridstack/gridstack.js/issues/937#event-2902461923
https://github.com/marttop
marttophttps://github.com/marttop
on Sep 30, 2020https://github.com/gridstack/gridstack.js/issues/937#issuecomment-701280450
https://github.com/adumesny
adumesnyhttps://github.com/adumesny
on Sep 30, 2020https://github.com/gridstack/gridstack.js/issues/937#issuecomment-701338067
@marttophttps://github.com/marttop
https://github.com/marttop
marttophttps://github.com/marttop
on Sep 30, 2020https://github.com/gridstack/gridstack.js/issues/937#issuecomment-701362211
@adumesnyhttps://github.com/adumesny
https://github.com/marttop
marttophttps://github.com/marttop
on Sep 30, 2020https://github.com/gridstack/gridstack.js/issues/937#issuecomment-701507596
#1391https://github.com/gridstack/gridstack.js/pull/1391
@adumesnyhttps://github.com/adumesny
marttophttps://github.com/marttop
on Oct 2, 2020https://github.com/gridstack/gridstack.js/issues/937#event-3833387951
Fixed 'animate' issue.https://github.com/gridstack/gridstack.js/commit/b89f8f48fe63a2141064bf089c55660061480f13
b89f8f4https://github.com/gridstack/gridstack.js/commit/b89f8f48fe63a2141064bf089c55660061480f13
adumesnyhttps://github.com/adumesny
on Oct 4, 2020https://github.com/gridstack/gridstack.js/issues/937#event-3838070305
fix to animatehttps://github.com/adumesny/gridstack.js/commit/3c63efbd316c59d844b03347e8d1b97067076017
3c63efbhttps://github.com/adumesny/gridstack.js/commit/3c63efbd316c59d844b03347e8d1b97067076017
https://github.com/adumesny
adumesnyhttps://github.com/adumesny
on Oct 4, 2020https://github.com/gridstack/gridstack.js/issues/937#issuecomment-703333877
adumesnyhttps://github.com/adumesny
completedhttps://github.com/gridstack/gridstack.js/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 4, 2020https://github.com/gridstack/gridstack.js/issues/937#event-3838071265
adumesnyhttps://github.com/adumesny
on Oct 6, 2020https://github.com/gridstack/gridstack.js/issues/937#event-3843707685
v2: fix to animatehttps://github.com/adumesny/gridstack.js/commit/731d5fa243031b74bf678bc80b6dbf187579599b
731d5fahttps://github.com/adumesny/gridstack.js/commit/731d5fa243031b74bf678bc80b6dbf187579599b
Sign up for freehttps://github.com/signup?return_to=https://github.com/gridstack/gridstack.js/issues/937
Sign in to commenthttps://github.com/login?return_to=https://github.com/gridstack/gridstack.js/issues/937
type:bughttps://github.com/gridstack/gridstack.js/issues?q=state%3Aopen%20label%3A%22type%3Abug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.