Title: RFC: Merge `flask-graphql`, `sanic-graphql` etc into `graphql-server-core` · Issue #34 · graphql-python/graphql-server · GitHub
Open Graph Title: RFC: Merge `flask-graphql`, `sanic-graphql` etc into `graphql-server-core` · Issue #34 · graphql-python/graphql-server
X Title: RFC: Merge `flask-graphql`, `sanic-graphql` etc into `graphql-server-core` · Issue #34 · graphql-python/graphql-server
Description: The problem Currently server integrations are split into separate repos: https://github.com/graphql-python/flask-graphql/ https://github.com/graphql-python/sanic-graphql/ https://github.com/graphql-python/aiohttp-graphql https://github.c...
Open Graph Description: The problem Currently server integrations are split into separate repos: https://github.com/graphql-python/flask-graphql/ https://github.com/graphql-python/sanic-graphql/ https://github.com/graphql...
X Description: The problem Currently server integrations are split into separate repos: https://github.com/graphql-python/flask-graphql/ https://github.com/graphql-python/sanic-graphql/ https://github.com/graphql...
Opengraph URL: https://github.com/graphql-python/graphql-server/issues/34
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"RFC: Merge `flask-graphql`, `sanic-graphql` etc into `graphql-server-core`","articleBody":"# The problem\r\n\r\nCurrently server integrations are split into separate repos:\r\n\r\n* https://github.com/graphql-python/flask-graphql/\r\n* https://github.com/graphql-python/sanic-graphql/\r\n* https://github.com/graphql-python/aiohttp-graphql\r\n* https://github.com/graphql-python/webob-graphql/\r\n\r\nAnd they are all depend on https://github.com/graphql-python/graphql-server-core\r\n\r\nThe issue with this is that each framework specific library shares a lot of code with the other libraries and it's hard to coordinate cross cutting changes.\r\n\r\n# The solution\r\n\r\nThe suggestion is that we merge the framework specific code into the `grapqhl-server-core` library so that the code is consolidated into 1 place. That way it's much easier to share code and keep things up to date.\r\n\r\nTo install the integration with flask for example:\r\n\r\n`pip install graphql-server-core[flask]`\r\n\r\nThen you can use it by:\r\n\r\n```python\r\nfrom grapqhl_server.flask import GraphQLView\r\n\r\n...\r\n```\r\n\r\n# Drawbacks\r\n\r\nIt will make the `graphql-server-core` library harder to maintain. At the moment it is very small and easy to test. Merging in the other server libs will make the library become more complex, harder to test (you will need to install all of the dependencies for testing) and easier to accidentally add unneeded dependencies. Any contributions will have to make sure they don't break other server variants supported by the library which they are not familiar with.\r\n\r\n# Alternatives\r\n\r\nWe keep the separation of libraries and try and consolidate folder layout and coding standards.\r\n\r\n# List of packages to merge\r\n\r\n* [x] https://github.com/graphql-python/flask-graphql/\r\n* [x] https://github.com/graphql-python/sanic-graphql/\r\n* [x] https://github.com/graphql-python/aiohttp-graphql\r\n* [x] https://github.com/graphql-python/webob-graphql/","author":{"url":"https://github.com/jkimbo","@type":"Person","name":"jkimbo"},"datePublished":"2020-03-14T16:07:03Z","url":"https://github.com/graphql-python/graphql-server/issues/34"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ee03fbda-9779-6f79-e453-6e82ad85629c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9BBE:224A11:29AFF:36088:6AFFA87E |
| html-safe-nonce | 96a6c47d90878066dc280ecf05b890a7c392f88198f0a1e1563468a242482242 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkJFOjIyNEExMToyOUFGRjozNjA4ODo2QUZGQTg3RSIsInZpc2l0b3JfaWQiOiI4NTA2ODY2NzA5MzU5OTk1MDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 441d509e8879ca24a159a1fc65ba5a0c361f07adbd6c59f6a1e0d0e12748f3ed |
| hovercard-subject-tag | issue:581267246 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-python/graphql-server/34/issue_layout |
| twitter:image | https://opengraph.githubassets.com/30dc56690faa52dd1e23f7370fa4a4fb5a0fcfe5bb4926d3a0f3668ea53cb316/graphql-python/graphql-server/issues/34 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/30dc56690faa52dd1e23f7370fa4a4fb5a0fcfe5bb4926d3a0f3668ea53cb316/graphql-python/graphql-server/issues/34 |
| og:image:alt | The problem Currently server integrations are split into separate repos: https://github.com/graphql-python/flask-graphql/ https://github.com/graphql-python/sanic-graphql/ https://github.com/graphql... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jkimbo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6a41d7f592f24f38b58637f25dec5e9e26cb838995072a495a552ba4e4eecf75 |
| turbo-cache-control | no-preview |
| go-import | github.com/graphql-python/graphql-server git https://github.com/graphql-python/graphql-server.git |
| octolytics-dimension-user_id | 15002022 |
| octolytics-dimension-user_login | graphql-python |
| octolytics-dimension-repository_id | 85903189 |
| octolytics-dimension-repository_nwo | graphql-python/graphql-server |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 85903189 |
| octolytics-dimension-repository_network_root_nwo | graphql-python/graphql-server |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0e75efa5f34074f831bc22b1a793c40d20fa144b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width