René's URL Explorer Experiment


Title: broken support for AsyncioExecutor · Issue #32 · graphql-python/graphql-server · GitHub

Open Graph Title: broken support for AsyncioExecutor · Issue #32 · graphql-python/graphql-server

X Title: broken support for AsyncioExecutor · Issue #32 · graphql-python/graphql-server

Description: The #13 PR introduced executors into request processing for batched queries. It also broken support for use of AsyncioExecutor from within asyncio context. When using AsyncioExecutor this line blocks forever: https://github.com/graphql-p...

Open Graph Description: The #13 PR introduced executors into request processing for batched queries. It also broken support for use of AsyncioExecutor from within asyncio context. When using AsyncioExecutor this line bloc...

X Description: The #13 PR introduced executors into request processing for batched queries. It also broken support for use of AsyncioExecutor from within asyncio context. When using AsyncioExecutor this line bloc...

Opengraph URL: https://github.com/graphql-python/graphql-server/issues/32

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"broken support for AsyncioExecutor","articleBody":"The #13 PR introduced executors into request processing for batched queries. It also broken support for use of AsyncioExecutor from within asyncio context.\r\n\r\nWhen using AsyncioExecutor this line blocks forever:\r\n\r\nhttps://github.com/graphql-python/graphql-server-core/blob/427cccb00ae41fb88e8fcaf89aa64f5edb855394/graphql_server/__init__.py#L137\r\n\r\nThe `get()` method is called on Promise that must be `await`ed in async context, here it will stay `pending` forever.\r\n\r\nCall to `wait_until_finished()` on executor does not help because `get_response` is not a coroutine and returns a Promise. Async Promises are not handled by `wait_until_finished()` method of AsyncioExecutor ([code](https://github.com/graphql-python/graphql-core/blob/a600f7c662e7a6db7d6b56e7c67bf43925b6b23d/graphql/execution/executors/asyncio.py#L47)). Even if it was, `AsyncioExecutor.wait_until_finished()` cannot run from within asyncio context and would fail for any asyncio-based application like aiohttp server.\r\n\r\nrelated issue: https://github.com/graphql-python/graphql-core/issues/67\r\n\r\nFix to the above issue introduces a flag `return_promise` which is just what we need to handle response in async context.\r\n\r\nimplementatio details:\r\n\r\nhttps://github.com/graphql-python/graphql-core/commit/b4758b1\r\nhttps://github.com/graphql-python/graphql-core/commit/895b324\r\nhttps://github.com/graphql-python/graphql-core/commit/cea224a\r\n\r\nThis fragment of graphql-core test show hows its intended to be used in asyncio context:\r\n\r\nhttps://github.com/graphql-python/graphql-core/blob/a600f7c662e7a6db7d6b56e7c67bf43925b6b23d/tests_py35/core_execution/test_asyncio_executor.py#L65-L75\r\n\r\nThe `return_promise` lets the main application handle waiting for executors to finish its task, so graphql-server-core should respect that.\r\n\r\nI found this issue in my aiohttp application (using [graphql-python/aiohttp-graphql](https://github.com/graphql-python/aiohttp-graphql)), all queries would block forever. I had to restrict this package version to `\u003c=1.1.1`","author":{"url":"https://github.com/blazewicz","@type":"Person","name":"blazewicz"},"datePublished":"2019-12-21T09:58:03Z","url":"https://github.com/graphql-python/graphql-server/issues/32"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3c1a7134-c5c4-c01b-8662-2982712e23f9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8CC4:1BEF18:11A37D8:1780677:6AFFCD98
html-safe-nonce6d1d405aed345a42f2eaa4cfe589d13a9d80cb6cf6eaf8cace34960f860fbe80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0M0OjFCRUYxODoxMUEzN0Q4OjE3ODA2Nzc6NkFGRkNEOTgiLCJ2aXNpdG9yX2lkIjoiMzk4NzQxNzgzMjMyODUxNDk2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfe7bb433f8636942333e9444a1761970c7ba60d0710265336c73a16c72b4b914
hovercard-subject-tagissue:541308747
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-python/graphql-server/32/issue_layout
twitter:imagehttps://opengraph.githubassets.com/885f06b35bc36ecf03fb294face78f97c5272566da9935f1cee6efd302b67309/graphql-python/graphql-server/issues/32
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/885f06b35bc36ecf03fb294face78f97c5272566da9935f1cee6efd302b67309/graphql-python/graphql-server/issues/32
og:image:altThe #13 PR introduced executors into request processing for batched queries. It also broken support for use of AsyncioExecutor from within asyncio context. When using AsyncioExecutor this line bloc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameblazewicz
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/graphql-python/graphql-server git https://github.com/graphql-python/graphql-server.git
octolytics-dimension-user_id15002022
octolytics-dimension-user_logingraphql-python
octolytics-dimension-repository_id85903189
octolytics-dimension-repository_nwographql-python/graphql-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id85903189
octolytics-dimension-repository_network_root_nwographql-python/graphql-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/graphql-python/graphql-server/issues/32#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-python%2Fgraphql-server%2Fissues%2F32
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-python%2Fgraphql-server%2Fissues%2F32
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=graphql-python%2Fgraphql-server
Reloadhttps://github.com/graphql-python/graphql-server/issues/32
Reloadhttps://github.com/graphql-python/graphql-server/issues/32
Reloadhttps://github.com/graphql-python/graphql-server/issues/32
graphql-pythonhttps://github.com/graphql-python
graphql-serverhttps://github.com/graphql-python/graphql-server
Codehttps://github.com/graphql-python/graphql-server
Issues5 (5)https://github.com/graphql-python/graphql-server/issues
Pull requests2 (2)https://github.com/graphql-python/graphql-server/pulls
Actionshttps://github.com/graphql-python/graphql-server/actions
Projectshttps://github.com/graphql-python/graphql-server/projects
Security and qualityhttps://github.com/graphql-python/graphql-server/security
Insightshttps://github.com/graphql-python/graphql-server/insights
https://github.com/graphql-python/graphql-server
New issuehttps://github.com/login?return_to=https://github.com/graphql-python/graphql-server/issues/32
New issuehttps://github.com/login?return_to=https://github.com/graphql-python/graphql-server/issues/32
#33https://github.com/graphql-python/graphql-server/pull/33
broken support for AsyncioExecutorhttps://github.com/graphql-python/graphql-server/issues/32#top
#33https://github.com/graphql-python/graphql-server/pull/33
https://github.com/blazewicz
blazewiczhttps://github.com/blazewicz
on Dec 21, 2019https://github.com/graphql-python/graphql-server/issues/32#issue-541308747
#13https://github.com/graphql-python/graphql-server/pull/13
https://github.com/graphql-python/graphql-server-core/blob/427cccb00ae41fb88e8fcaf89aa64f5edb855394/graphql_server/__init__.py#L137https://github.com/graphql-python/graphql-server-core/blob/427cccb00ae41fb88e8fcaf89aa64f5edb855394/graphql_server/__init__.py#L137
codehttps://github.com/graphql-python/graphql-core/blob/a600f7c662e7a6db7d6b56e7c67bf43925b6b23d/graphql/execution/executors/asyncio.py#L47
graphql-python/graphql-core#67https://github.com/graphql-python/graphql-core/issues/67
graphql-python/graphql-core@b4758b1https://github.com/graphql-python/graphql-core/commit/b4758b1
graphql-python/graphql-core@895b324https://github.com/graphql-python/graphql-core/commit/895b324
graphql-python/graphql-core@cea224ahttps://github.com/graphql-python/graphql-core/commit/cea224a
https://github.com/graphql-python/graphql-core/blob/a600f7c662e7a6db7d6b56e7c67bf43925b6b23d/tests_py35/core_execution/test_asyncio_executor.py#L65-L75https://github.com/graphql-python/graphql-core/blob/a600f7c662e7a6db7d6b56e7c67bf43925b6b23d/tests_py35/core_execution/test_asyncio_executor.py#L65-L75
graphql-python/aiohttp-graphqlhttps://github.com/graphql-python/aiohttp-graphql
Citohttps://github.com/Cito
completedhttps://github.com/graphql-python/graphql-server/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#33https://github.com/graphql-python/graphql-server/pull/33
on Jan 23, 2020https://github.com/graphql-python/graphql-server/issues/32#event-2975086929
https://github.com/Cito
Citohttps://github.com/Cito
on Jan 23, 2020https://github.com/graphql-python/graphql-server/issues/32#issuecomment-577907492
Sign up for freehttps://github.com/signup?return_to=https://github.com/graphql-python/graphql-server/issues/32
Sign in to commenthttps://github.com/login?return_to=https://github.com/graphql-python/graphql-server/issues/32
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.