Title: Performance of isawaitable · Issue #54 · graphql-python/graphql-core · GitHub
Open Graph Title: Performance of isawaitable · Issue #54 · graphql-python/graphql-core
X Title: Performance of isawaitable · Issue #54 · graphql-python/graphql-core
Description: I've run a very simplistic benchmark, just returning a long list of single-field objects. It seems graphql-core-next is 2.5x slower than graphql-core: https://gist.github.com/ktosiek/849e8c7de8852c2df1df5af8ac193287 Looking at flamegraph...
Open Graph Description: I've run a very simplistic benchmark, just returning a long list of single-field objects. It seems graphql-core-next is 2.5x slower than graphql-core: https://gist.github.com/ktosiek/849e8c7de8852c...
X Description: I've run a very simplistic benchmark, just returning a long list of single-field objects. It seems graphql-core-next is 2.5x slower than graphql-core: https://gist.github.com/ktosiek/849e8c7de8...
Opengraph URL: https://github.com/graphql-python/graphql-core/issues/54
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Performance of isawaitable","articleBody":"I've run a very simplistic benchmark, just returning a long list of single-field objects.\r\nIt seems graphql-core-next is 2.5x slower than graphql-core: https://gist.github.com/ktosiek/849e8c7de8852c2df1df5af8ac193287\r\n\r\nLooking at flamegraphs, I see isawaitable is used **a lot**, and it's a pretty slow function. Would it be possible to pass raw results around more? It seems resolve_field_value_or_error and complete_value_catching_error are the main offenders here.","author":{"url":"https://github.com/ktosiek","@type":"Person","name":"ktosiek"},"datePublished":"2019-09-04T07:12:13Z","url":"https://github.com/graphql-python/graphql-core/issues/54"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:df2e790a-2bc4-b155-43e1-166ea455b31c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B08E:07D0:31DE83:4004B3:6AFFC788 |
| html-safe-nonce | ecbb8dd44e1cfd655f02b4ff8b3df2af74d53e2507b81821dca71f8468057d11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDhFOjA3RDA6MzFERTgzOjQwMDRCMzo2QUZGQzc4OCIsInZpc2l0b3JfaWQiOiIzMDgxMjA0ODI4MzY2NDIzOTQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a18d93e0a0b52d449243773ebde4ecbf29a8a14188c1cedb668d282b964e2225 |
| hovercard-subject-tag | issue:488983399 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/graphql-python/graphql-core/54/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6d4c97903cc15a9f79fca4499ee896eeae2dbc4aa6a9a596f637a6e3f01536d4/graphql-python/graphql-core/issues/54 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6d4c97903cc15a9f79fca4499ee896eeae2dbc4aa6a9a596f637a6e3f01536d4/graphql-python/graphql-core/issues/54 |
| og:image:alt | I've run a very simplistic benchmark, just returning a long list of single-field objects. It seems graphql-core-next is 2.5x slower than graphql-core: https://gist.github.com/ktosiek/849e8c7de8852c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ktosiek |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1e805b832df235bb21305db712c3b6432920019dfc12cb25b9cb8d3b0c9403cf |
| turbo-cache-control | no-preview |
| go-import | github.com/graphql-python/graphql-core git https://github.com/graphql-python/graphql-core.git |
| octolytics-dimension-user_id | 15002022 |
| octolytics-dimension-user_login | graphql-python |
| octolytics-dimension-repository_id | 143207933 |
| octolytics-dimension-repository_nwo | graphql-python/graphql-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 143207933 |
| octolytics-dimension-repository_network_root_nwo | graphql-python/graphql-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8fa4a54e6871c7908eda1c246ad5972982c0b59d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width