René's URL Explorer Experiment


Title: ValueCache calls are made inside the batch load call by bbakerman · Pull Request #99 · graphql-java/java-dataloader · GitHub

Open Graph Title: ValueCache calls are made inside the batch load call by bbakerman · Pull Request #99 · graphql-java/java-dataloader

X Title: ValueCache calls are made inside the batch load call by bbakerman · Pull Request #99 · graphql-java/java-dataloader

Description: The ValueCache is an async affair. The previous PRs such as #91 handled it badly because they made the "load" call asynchronous with repect to the method returning a CF that might need to be dispat...

Open Graph Description: The ValueCache is an async affair. The previous PRs such as #91 handled it badly because they made the "load" call asynchronous with repect to the method returning a CF that might need to...

X Description: The ValueCache is an async affair. The previous PRs such as #91 handled it badly because they made the "load" call asynchronous with repect to the method returning a CF that might...

Opengraph URL: https://github.com/graphql-java/java-dataloader/pull/99

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76e500c8-34da-f108-527b-7bc513e2805d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEE6:3A10FF:1BB7D30:2497020:6971A2C2
html-safe-nonce9ad052d0ad6f8f9bd06e3c5cdf01d623389717354ae0ce15bb50d84d9898827e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUU2OjNBMTBGRjoxQkI3RDMwOjI0OTcwMjA6Njk3MUEyQzIiLCJ2aXNpdG9yX2lkIjoiMzMzNTY3NDkxNDcwOTU0NTY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace336661089871e73ddb8f6b0a9a2ac67bb2694eb4e79b7ad904cf721a6e02ea5
hovercard-subject-tagpull_request:705878699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/java-dataloader/99/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d4850d93892db9bac70c6ec9723fd2b589e2d88e0d3252a9107b596881266200/graphql-java/java-dataloader/pull/99
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d4850d93892db9bac70c6ec9723fd2b589e2d88e0d3252a9107b596881266200/graphql-java/java-dataloader/pull/99
og:image:altThe ValueCache is an async affair. The previous PRs such as #91 handled it badly because they made the "load" call asynchronous with repect to the method returning a CF that might need to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebbakerman
hostnamegithub.com
expected-hostnamegithub.com
Nonefdfdce9cd4f6ab85dca2b0d11264270829297c962dd5a79df449062d7822258f
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/java-dataloader git https://github.com/graphql-java/java-dataloader.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id97364654
octolytics-dimension-repository_nwographql-java/java-dataloader
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id97364654
octolytics-dimension-repository_network_root_nwographql-java/java-dataloader
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51c736e60b302bd039c9d5164573d176ceb24bb2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/java-dataloader/pull/99#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F99
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F99
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fjava-dataloader
Reloadhttps://github.com/graphql-java/java-dataloader/pull/99
Reloadhttps://github.com/graphql-java/java-dataloader/pull/99
Reloadhttps://github.com/graphql-java/java-dataloader/pull/99
graphql-java https://github.com/graphql-java
java-dataloaderhttps://github.com/graphql-java/java-dataloader
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Fork 95 https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Star 520 https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Code https://github.com/graphql-java/java-dataloader
Issues 1 https://github.com/graphql-java/java-dataloader/issues
Pull requests 10 https://github.com/graphql-java/java-dataloader/pulls
Discussions https://github.com/graphql-java/java-dataloader/discussions
Actions https://github.com/graphql-java/java-dataloader/actions
Projects 0 https://github.com/graphql-java/java-dataloader/projects
Wiki https://github.com/graphql-java/java-dataloader/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/graphql-java/java-dataloader/security
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
Insights https://github.com/graphql-java/java-dataloader/pulse
Code https://github.com/graphql-java/java-dataloader
Issues https://github.com/graphql-java/java-dataloader/issues
Pull requests https://github.com/graphql-java/java-dataloader/pulls
Discussions https://github.com/graphql-java/java-dataloader/discussions
Actions https://github.com/graphql-java/java-dataloader/actions
Projects https://github.com/graphql-java/java-dataloader/projects
Wiki https://github.com/graphql-java/java-dataloader/wiki
Security https://github.com/graphql-java/java-dataloader/security
Insights https://github.com/graphql-java/java-dataloader/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/graphql-java/java-dataloader/pull/99#issue-comment-box
bbakermanhttps://github.com/bbakerman
masterhttps://github.com/graphql-java/java-dataloader/tree/master
cache_calls_in_batch_loadhttps://github.com/graphql-java/java-dataloader/tree/cache_calls_in_batch_load
ValueCache calls are made inside the batch load call https://github.com/graphql-java/java-dataloader/pull/99#top
bbakermanhttps://github.com/bbakerman
masterhttps://github.com/graphql-java/java-dataloader/tree/master
cache_calls_in_batch_loadhttps://github.com/graphql-java/java-dataloader/tree/cache_calls_in_batch_load
Conversation 5 https://github.com/graphql-java/java-dataloader/pull/99
Commits 9 https://github.com/graphql-java/java-dataloader/pull/99/commits
Checks 0 https://github.com/graphql-java/java-dataloader/pull/99/checks
Files changed https://github.com/graphql-java/java-dataloader/pull/99/files
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/{{ revealButtonHref }}
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 7, 2021https://github.com/graphql-java/java-dataloader/pull/99#issue-963213265
#91https://github.com/graphql-java/java-dataloader/pull/91
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
bbakermanhttps://github.com/bbakerman
July 31, 2021 18:01https://github.com/graphql-java/java-dataloader/pull/99#commits-pushed-e3e70a4
https://github.com/bbakerman
This adds support for calling dispatch if the ValueCache takes time i…https://github.com/graphql-java/java-dataloader/pull/99/commits/e3e70a4fba1b9516fb0f2d15f2846141d683bcb8
e3e70a4https://github.com/graphql-java/java-dataloader/pull/99/commits/e3e70a4fba1b9516fb0f2d15f2846141d683bcb8
https://github.com/bbakerman
javadoc problemhttps://github.com/graphql-java/java-dataloader/pull/99/commits/ae0a29e85c4458e277110d169d1066d68d4364ba
ae0a29ehttps://github.com/graphql-java/java-dataloader/pull/99/commits/ae0a29e85c4458e277110d169d1066d68d4364ba
https://github.com/bbakerman
This attacks the problem os async ValueCache lookups in the batch loa…https://github.com/graphql-java/java-dataloader/pull/99/commits/a74031ad7ff10883f71524b164890da45b50706f
a74031ahttps://github.com/graphql-java/java-dataloader/pull/99/commits/a74031ad7ff10883f71524b164890da45b50706f
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 7, 2021 https://github.com/graphql-java/java-dataloader/pull/99#ref-issue-956984830
ValueCache: batch function isn't always triggered on cache miss #90 https://github.com/graphql-java/java-dataloader/issues/90
https://github.com/bbakerman
Doco updated and removed get returning Tryhttps://github.com/graphql-java/java-dataloader/pull/99/commits/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
38b3755https://github.com/graphql-java/java-dataloader/pull/99/commits/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021https://github.com/graphql-java/java-dataloader/pull/99#event-5126173699
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021 https://github.com/graphql-java/java-dataloader/pull/99#pullrequestreview-724853448
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
src/main/java/org/dataloader/DataLoader.javahttps://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62#diff-2f217b06748f16325d4013014fe2b879e36fb8cfe898b683aed7ca631c9850ff
bbakermanhttps://github.com/bbakerman
Aug 8, 2021https://github.com/graphql-java/java-dataloader/pull/99#discussion_r684693839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021 https://github.com/graphql-java/java-dataloader/pull/99#pullrequestreview-724853510
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
src/main/java/org/dataloader/DataLoaderHelper.javahttps://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
bbakermanhttps://github.com/bbakerman
Aug 8, 2021https://github.com/graphql-java/java-dataloader/pull/99#discussion_r684693951
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021 https://github.com/graphql-java/java-dataloader/pull/99#pullrequestreview-724853940
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
src/main/java/org/dataloader/impl/Assertions.javahttps://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62#diff-2c77c553c8490368c3761eb60ceabd5c04d219435293292b2d466da8438a54c5
bbakermanhttps://github.com/bbakerman
Aug 8, 2021https://github.com/graphql-java/java-dataloader/pull/99#discussion_r684695001
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021 https://github.com/graphql-java/java-dataloader/pull/99#pullrequestreview-724855167
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62
src/main/java/org/dataloader/DataLoaderHelper.javahttps://github.com/graphql-java/java-dataloader/pull/99/files/38b375526bedc54f90cd43d4f17d5d07bf0e4e62#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
bbakermanhttps://github.com/bbakerman
Aug 8, 2021https://github.com/graphql-java/java-dataloader/pull/99#discussion_r684697671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.com/bbakerman
more tests and more resilient setCache callshttps://github.com/graphql-java/java-dataloader/pull/99/commits/d8078e0a2ebbef0d9b3de0eadb1654a44773963b
d8078e0https://github.com/graphql-java/java-dataloader/pull/99/commits/d8078e0a2ebbef0d9b3de0eadb1654a44773963b
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Aug 8, 2021 https://github.com/graphql-java/java-dataloader/pull/99#ref-issue-957447094
DataLoader 3.x will not be upgraded in graphql-java 17.0 #98 https://github.com/graphql-java/java-dataloader/issues/98
bbakermanhttps://github.com/bbakerman
August 8, 2021 19:52https://github.com/graphql-java/java-dataloader/pull/99#commits-pushed-d691f88
https://github.com/bbakerman
found a buf where the cache set is done on entries that are already i…https://github.com/graphql-java/java-dataloader/pull/99/commits/d691f88281eb14995a5c8b21bf94a97091022043
d691f88https://github.com/graphql-java/java-dataloader/pull/99/commits/d691f88281eb14995a5c8b21bf94a97091022043
https://github.com/bbakerman
improved the set cache code - thenCompose was missinghttps://github.com/graphql-java/java-dataloader/pull/99/commits/efdb9a7ad1dbaf7d884dcab07e6db8116e790cc6
efdb9a7https://github.com/graphql-java/java-dataloader/pull/99/commits/efdb9a7ad1dbaf7d884dcab07e6db8116e790cc6
https://github.com/andimarek
andimarekhttps://github.com/andimarek
Aug 9, 2021 https://github.com/graphql-java/java-dataloader/pull/99#pullrequestreview-724953400
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/99/files/efdb9a7ad1dbaf7d884dcab07e6db8116e790cc6
src/main/java/org/dataloader/DataLoaderHelper.javahttps://github.com/graphql-java/java-dataloader/pull/99/files/efdb9a7ad1dbaf7d884dcab07e6db8116e790cc6#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
andimarekhttps://github.com/andimarek
Aug 9, 2021https://github.com/graphql-java/java-dataloader/pull/99#discussion_r684852528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
bbakermanhttps://github.com/bbakerman
August 9, 2021 15:14https://github.com/graphql-java/java-dataloader/pull/99#commits-pushed-4ecb786
https://github.com/bbakerman
Moved to CompletableFuture inside codehttps://github.com/graphql-java/java-dataloader/pull/99/commits/4ecb78675896841e032dc44ffb2c012e00800b8d
4ecb786https://github.com/graphql-java/java-dataloader/pull/99/commits/4ecb78675896841e032dc44ffb2c012e00800b8d
https://github.com/bbakerman
better assertshttps://github.com/graphql-java/java-dataloader/pull/99/commits/af28c040d695139a00b2c6c5de259d33d777566f
af28c04https://github.com/graphql-java/java-dataloader/pull/99/commits/af28c040d695139a00b2c6c5de259d33d777566f
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
3.xhttps://github.com/graphql-java/java-dataloader/milestone/6
Aug 9, 2021https://github.com/graphql-java/java-dataloader/pull/99#event-5127859893
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
8836d7ehttps://github.com/graphql-java/java-dataloader/commit/8836d7e153f94a518303b3b9fdc6e13377144f07
Aug 9, 2021https://github.com/graphql-java/java-dataloader/pull/99#event-5127861317
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F99
https://github.com/andimarek
andimarek https://github.com/andimarek
https://github.com/graphql-java/java-dataloader/pull/99/files/efdb9a7ad1dbaf7d884dcab07e6db8116e790cc6
3.x https://github.com/graphql-java/java-dataloader/milestone/6
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/99
https://github.com/bbakerman
https://github.com/andimarek
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.