René's URL Explorer Experiment


Title: Fix value cache batch loader environment by andimarek · Pull Request #278 · graphql-java/java-dataloader · GitHub

Open Graph Title: Fix value cache batch loader environment by andimarek · Pull Request #278 · graphql-java/java-dataloader

X Title: Fix value cache batch loader environment by andimarek · Pull Request #278 · graphql-java/java-dataloader

Description: This is a demonstration patch stacked on top of #277. It addresses the BatchLoaderEnvironment semantic regression described in the requested-changes review. Problem #277 builds a BatchLoaderEnvironment before value-cache filtering. If a dispatch has a partial ValueCache hit, the actual batch loader is invoked only with the missed keys, but the environment can still describe the original full key/context list. That breaks the existing invariant that environment.getKeyContextsList() is aligned with the keys argument received by a BatchLoaderWithContext. Fix When ValueCache filtering produces missedKeys, build a fresh BatchLoaderEnvironment from missedKeys and missedKeyContexts before invoking the concrete batch loader. The actual fix is intentionally small: src/main/java/org/dataloader/DataLoaderHelper.java:483 builds missedEnvironment from missedKeys and missedKeyContexts. src/main/java/org/dataloader/DataLoaderHelper.java:484 passes missedEnvironment into the concrete invokeLoader(...) call for the cache misses. GitHub line link: https://github.com/graphql-java/java-dataloader/blob/fix-pr-277-value-cache-environment/src/main/java/org/dataloader/DataLoaderHelper.java#L483-L484 Test Adds a regression test where: A is returned from ValueCache B misses and is sent to the batch loader the batch loader asserts it receives only B environment.getKeyContextsList().get(0) matches B's context, not A's The key test lines are: src/test/java/org/dataloader/DataLoaderBatchLoaderEnvironmentTest.java:221-249 GitHub line link: https://github.com/graphql-java/java-dataloader/blob/fix-pr-277-value-cache-environment/src/test/java/org/dataloader/DataLoaderBatchLoaderEnvironmentTest.java#L221-L249 Verification ./gradlew test --tests org.dataloader.DataLoaderBatchLoaderEnvironmentTest ./gradlew test git diff --check origin/pr/277

Open Graph Description: This is a demonstration patch stacked on top of #277. It addresses the BatchLoaderEnvironment semantic regression described in the requested-changes review. Problem #277 builds a BatchLoaderEnviron...

X Description: This is a demonstration patch stacked on top of #277. It addresses the BatchLoaderEnvironment semantic regression described in the requested-changes review. Problem #277 builds a BatchLoaderEnviron...

Opengraph URL: https://github.com/graphql-java/java-dataloader/pull/278

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3dd8c823-e3ee-4310-88f3-4bb68d07832b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD34C:E3C4F:21DB046:2B253B0:6B017EB6
html-safe-nonce4858ff710cced484a8616115c85f3b84ef619b4724ab2205c2f3ea0be687cbc3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzRDOkUzQzRGOjIxREIwNDY6MkIyNTNCMDo2QjAxN0VCNiIsInZpc2l0b3JfaWQiOiIxODQ1OTgxNTkyNzcwNjc0MzU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac938bdc6505a056b8417c34bc6f1179cc178d4dd8fe642f3bcd171bc0074793dc
hovercard-subject-tagpull_request:3714659153
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/java-dataloader/pull/278/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altThis is a demonstration patch stacked on top of #277. It addresses the BatchLoaderEnvironment semantic regression described in the requested-changes review. Problem #277 builds a BatchLoaderEnviron...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/java-dataloader git https://github.com/graphql-java/java-dataloader.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id97364654
octolytics-dimension-repository_nwographql-java/java-dataloader
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id97364654
octolytics-dimension-repository_network_root_nwographql-java/java-dataloader
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/java-dataloader/pull/278/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F278%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F278%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fjava-dataloader
Reloadhttps://github.com/graphql-java/java-dataloader/pull/278/files
Reloadhttps://github.com/graphql-java/java-dataloader/pull/278/files
Reloadhttps://github.com/graphql-java/java-dataloader/pull/278/files
graphql-javahttps://github.com/graphql-java
java-dataloaderhttps://github.com/graphql-java/java-dataloader
Codehttps://github.com/graphql-java/java-dataloader
Issues2 (2)https://github.com/graphql-java/java-dataloader/issues
Pull requests18 (18)https://github.com/graphql-java/java-dataloader/pulls
Discussionshttps://github.com/graphql-java/java-dataloader/discussions
Actionshttps://github.com/graphql-java/java-dataloader/actions
Projectshttps://github.com/graphql-java/java-dataloader/projects
Wikihttps://github.com/graphql-java/java-dataloader/wiki
Security and qualityhttps://github.com/graphql-java/java-dataloader/security
Insightshttps://github.com/graphql-java/java-dataloader/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/java-dataloader/tree/master
fix-pr-277-value-cache-environmenthttps://github.com/graphql-java/java-dataloader/tree/fix-pr-277-value-cache-environment
Conversation 2 https://github.com/graphql-java/java-dataloader/pull/278
Commits 4 https://github.com/graphql-java/java-dataloader/pull/278/commits
Checks 2 https://github.com/graphql-java/java-dataloader/pull/278/checks
Files changed https://github.com/graphql-java/java-dataloader/pull/278/files
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/278/files
Fix value cache batch loader environment https://github.com/graphql-java/java-dataloader/pull/278/files#top
Show all changes 4 commits https://github.com/graphql-java/java-dataloader/pull/278/files
3075fcc Allow scheduling of CF completion bbakerman May 17, 2026 https://github.com/graphql-java/java-dataloader/pull/278/commits/3075fcc796e71b67f95d04433c9065cda07c6bc4
8eadcb2 Allow scheduling of CF completion bbakerman May 17, 2026 https://github.com/graphql-java/java-dataloader/pull/278/commits/8eadcb235841b8767c626e89cd735f58103dfd4c
e04c76d Allow BatchLoaderScheduler process all CF completions as a batch and … fxbonnet May 18, 2026 https://github.com/graphql-java/java-dataloader/pull/278/commits/e04c76d677c88cce8481640350ccf09213de6dc3
e029423 Fix value cache batch loader environment andimarek May 20, 2026 https://github.com/graphql-java/java-dataloader/pull/278/commits/e029423710a396da7c3f7f4c448f2e16f1ecee5b
Clear filters https://github.com/graphql-java/java-dataloader/pull/278/files
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/278/files
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/278/files
README.md https://github.com/graphql-java/java-dataloader/pull/278/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
DataLoaderHelper.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
CompletableFutureKit.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
BatchLoaderScheduler.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
DataLoaderBatchLoaderEnvironmentTest.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-7a2a4ec71f25ae91d18d00b77f5ead506a27666eefc4bfa2c71bece0d3b6358b
CompletableFutureKitTest.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-142dc5e01cf1d09b709bc0e2fcf2930e12d97fe88ee573959c4feb39bc0e252f
BatchLoaderSchedulerTest.java https://github.com/graphql-java/java-dataloader/pull/278/files#diff-f803ccd044a0dbb009c24deba0847bc497e866adc238e28455650d8be4ce33c9
README.mdhttps://github.com/graphql-java/java-dataloader/pull/278/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
View file https://github.com/graphql-java/java-dataloader/blob/e029423710a396da7c3f7f4c448f2e16f1ecee5b/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/278/{{ revealButtonHref }}
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
src/main/java/org/dataloader/DataLoaderHelper.javahttps://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
View file https://github.com/graphql-java/java-dataloader/blob/e029423710a396da7c3f7f4c448f2e16f1ecee5b/src/main/java/org/dataloader/DataLoaderHelper.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/278/{{ revealButtonHref }}
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88
src/main/java/org/dataloader/impl/CompletableFutureKit.javahttps://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
View file https://github.com/graphql-java/java-dataloader/blob/e029423710a396da7c3f7f4c448f2e16f1ecee5b/src/main/java/org/dataloader/impl/CompletableFutureKit.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/278/{{ revealButtonHref }}
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-2afb0ca975b7f6b786195aa907f67a745efae44dfadce07248745e74448f5d00
src/main/java/org/dataloader/scheduler/BatchLoaderScheduler.javahttps://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
View file https://github.com/graphql-java/java-dataloader/blob/e029423710a396da7c3f7f4c448f2e16f1ecee5b/src/main/java/org/dataloader/scheduler/BatchLoaderScheduler.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/278/{{ revealButtonHref }}
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
https://github.com/graphql-java/java-dataloader/pull/278/files#diff-1329a484d3dab322e68f33841f91a48508ec6da87ee4c06cb579a03d9c93848c
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/278/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.