| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:01e47375-cad9-6c5b-6cc9-08984e8e3aae |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DEE:287BC8:1138C24:177FC80:6970038F |
| html-safe-nonce | 577481e5d8ced51c9d66d37c26cb499407e620699f2c18a457d735bebb89b43b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REVFOjI4N0JDODoxMTM4QzI0OjE3N0ZDODA6Njk3MDAzOEYiLCJ2aXNpdG9yX2lkIjoiMjMxNjU0NjcxODAyNDMzNjI3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0080297940090f3223d8f5fa45396c219baf44c44c023cdada90f692b30f6b1e |
| hovercard-subject-tag | pull_request:2257244063 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/java-dataloader/172/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/52a0e939fc93e8dfc378482ae7ac3b1e973d0f9edb61f28fa13a646548773437/graphql-java/java-dataloader/pull/172 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/52a0e939fc93e8dfc378482ae7ac3b1e973d0f9edb61f28fa13a646548773437/graphql-java/java-dataloader/pull/172 |
| og:image:alt | We resolve two bugs in the interaction between Publisher DataLoaders and ValueCaches:
if the value was cached, we complete the corresponding queued futures immediately.
if the value was not cached... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AlexandreCarlton |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0366807b865cee6776368231232f84d6c8096e6bce43f701a4fb28ea795ec427 |
| turbo-cache-control | no-preview |
| go-import | github.com/graphql-java/java-dataloader git https://github.com/graphql-java/java-dataloader.git |
| octolytics-dimension-user_id | 14289921 |
| octolytics-dimension-user_login | graphql-java |
| octolytics-dimension-repository_id | 97364654 |
| octolytics-dimension-repository_nwo | graphql-java/java-dataloader |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 97364654 |
| octolytics-dimension-repository_network_root_nwo | graphql-java/java-dataloader |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 33f356bb2fb58726ccb2f26395bf8ddc9a2d9eaa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/graphql-java/java-dataloader/pull/172#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F172 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F172 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fjava-dataloader |
| Reload | https://github.com/graphql-java/java-dataloader/pull/172 |
| Reload | https://github.com/graphql-java/java-dataloader/pull/172 |
| Reload | https://github.com/graphql-java/java-dataloader/pull/172 |
|
graphql-java
| https://github.com/graphql-java |
| java-dataloader | https://github.com/graphql-java/java-dataloader |
|
Notifications
| https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader |
|
Fork
95
| https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader |
|
Star
520
| https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader |
|
Code
| https://github.com/graphql-java/java-dataloader |
|
Issues
1
| https://github.com/graphql-java/java-dataloader/issues |
|
Pull requests
10
| https://github.com/graphql-java/java-dataloader/pulls |
|
Discussions
| https://github.com/graphql-java/java-dataloader/discussions |
|
Actions
| https://github.com/graphql-java/java-dataloader/actions |
|
Projects
0
| https://github.com/graphql-java/java-dataloader/projects |
|
Wiki
| https://github.com/graphql-java/java-dataloader/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/graphql-java/java-dataloader/security |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
|
Insights
| https://github.com/graphql-java/java-dataloader/pulse |
|
Code
| https://github.com/graphql-java/java-dataloader |
|
Issues
| https://github.com/graphql-java/java-dataloader/issues |
|
Pull requests
| https://github.com/graphql-java/java-dataloader/pulls |
|
Discussions
| https://github.com/graphql-java/java-dataloader/discussions |
|
Actions
| https://github.com/graphql-java/java-dataloader/actions |
|
Projects
| https://github.com/graphql-java/java-dataloader/projects |
|
Wiki
| https://github.com/graphql-java/java-dataloader/wiki |
|
Security
| https://github.com/graphql-java/java-dataloader/security |
|
Insights
| https://github.com/graphql-java/java-dataloader/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/graphql-java/java-dataloader/pull/172#issue-comment-box |
| bbakerman | https://github.com/bbakerman |
| graphql-java:master | https://github.com/graphql-java/java-dataloader/tree/master |
| AlexandreCarlton:fix-publisher-dataloader-with-value-cache | https://github.com/AlexandreCarlton/java-dataloader/tree/fix-publisher-dataloader-with-value-cache |
|
Allow ValueCache to work with Publisher DataLoader
| https://github.com/graphql-java/java-dataloader/pull/172#top |
| bbakerman | https://github.com/bbakerman |
| graphql-java:master | https://github.com/graphql-java/java-dataloader/tree/master |
| AlexandreCarlton:fix-publisher-dataloader-with-value-cache | https://github.com/AlexandreCarlton/java-dataloader/tree/fix-publisher-dataloader-with-value-cache |
|
Conversation
8
| https://github.com/graphql-java/java-dataloader/pull/172 |
|
Commits
2
| https://github.com/graphql-java/java-dataloader/pull/172/commits |
|
Checks
1
| https://github.com/graphql-java/java-dataloader/pull/172/checks |
|
Files changed
| https://github.com/graphql-java/java-dataloader/pull/172/files |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| https://github.co/hiddenchars |
| https://github.com/graphql-java/java-dataloader/pull/{{ revealButtonHref }} |
|
| https://github.com/AlexandreCarlton |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
| Jan 1, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#issue-2765295876 |
| #171 | https://github.com/graphql-java/java-dataloader/pull/171 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
| January 1, 2025 22:04 | https://github.com/graphql-java/java-dataloader/pull/172#commits-pushed-47411a9 |
|
| https://github.com/AlexandreCarlton |
| Parameterise more tests across DataLoader implementations | https://github.com/graphql-java/java-dataloader/pull/172/commits/47411a9b05ac15acc8757c510b9933662491107c |
| 47411a9 | https://github.com/graphql-java/java-dataloader/pull/172/commits/47411a9b05ac15acc8757c510b9933662491107c |
|
| https://github.com/AlexandreCarlton |
| Allow ValueCache to work with Publisher DataLoader | https://github.com/graphql-java/java-dataloader/pull/172/commits/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| 9a20334 | https://github.com/graphql-java/java-dataloader/pull/172/commits/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Jan 3, 2025
| https://github.com/graphql-java/java-dataloader/pull/172#pullrequestreview-2528587335 |
|
View reviewed changes
| https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| src/main/java/org/dataloader/DataLoaderHelper.java | https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464#diff-e44f0238fddb1d168a414ceef18d7194686b83ecf167cb794d2d03e714494c88 |
| bbakerman | https://github.com/bbakerman |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901490934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| bbakerman | https://github.com/bbakerman |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901492642 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901986962 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| bbakerman | https://github.com/bbakerman |
| Jan 5, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1903204884 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Jan 3, 2025
| https://github.com/graphql-java/java-dataloader/pull/172#pullrequestreview-2528589781 |
|
View reviewed changes
| https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| src/test/java/org/dataloader/DataLoaderValueCacheTest.java | https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464#diff-f44f866077430ed6a0153356bfe2663ce334628f54f06482485b7a906198fb8d |
| bbakerman | https://github.com/bbakerman |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901492430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #171 | https://github.com/graphql-java/java-dataloader/pull/171 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901981008 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 9a20334#r1901980139 | https://github.com/graphql-java/java-dataloader/commit/9a20334effd34fc1dd31c9592b3ac278c6fbc464#r1901980139 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| https://github.com/AlexandreCarlton |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
|
Jan 3, 2025
| https://github.com/graphql-java/java-dataloader/pull/172#pullrequestreview-2529411302 |
|
View reviewed changes
| https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| src/test/java/org/dataloader/DataLoaderValueCacheTest.java | https://github.com/graphql-java/java-dataloader/pull/172/files/47411a9b05ac15acc8757c510b9933662491107c..9a20334effd34fc1dd31c9592b3ac278c6fbc464#diff-f44f866077430ed6a0153356bfe2663ce334628f54f06482485b7a906198fb8d |
| AlexandreCarlton | https://github.com/AlexandreCarlton |
| Jan 3, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1901980139 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| bbakerman | https://github.com/bbakerman |
| Jan 5, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#discussion_r1903198492 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
|
Jan 5, 2025
| https://github.com/graphql-java/java-dataloader/pull/172#pullrequestreview-2530826781 |
|
View reviewed changes
| https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
| https://github.com/bbakerman |
| bbakerman | https://github.com/bbakerman |
| 205aaa5 | https://github.com/graphql-java/java-dataloader/commit/205aaa5581a9cf81a4e5081cc6015ef473f27586 |
| Jan 5, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#event-15816729190 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
| https://github.com/dondonz |
| dondonz | https://github.com/dondonz |
| 4.0.0 | https://github.com/graphql-java/java-dataloader/milestone/12 |
| Mar 1, 2025 | https://github.com/graphql-java/java-dataloader/pull/172#event-16519741304 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F172 |
|
| https://github.com/bbakerman |
|
bbakerman
| https://github.com/bbakerman |
|
| https://github.com/graphql-java/java-dataloader/pull/172/files/9a20334effd34fc1dd31c9592b3ac278c6fbc464 |
|
4.0.0
| https://github.com/graphql-java/java-dataloader/milestone/12 |
| Please reload this page | https://github.com/graphql-java/java-dataloader/pull/172 |
|
| https://github.com/AlexandreCarlton |
|
| https://github.com/bbakerman |
|
| https://github.com/dondonz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |