René's URL Explorer Experiment


Title: Remove CacheMap#containsKey before #get by AlexandreCarlton · Pull Request #146 · graphql-java/java-dataloader · GitHub

Open Graph Title: Remove CacheMap#containsKey before #get by AlexandreCarlton · Pull Request #146 · graphql-java/java-dataloader

X Title: Remove CacheMap#containsKey before #get by AlexandreCarlton · Pull Request #146 · graphql-java/java-dataloader

Description: Currently, when accessing values from the DataLoader's CacheMap, we first check #containsKey before invoking #get. This is problematic for two reasons: the underlying cache's metrics are skewed (i...

Open Graph Description: Currently, when accessing values from the DataLoader's CacheMap, we first check #containsKey before invoking #get. This is problematic for two reasons: the underlying cache's metrics are s...

X Description: Currently, when accessing values from the DataLoader's CacheMap, we first check #containsKey before invoking #get. This is problematic for two reasons: the underlying cache's metri...

Opengraph URL: https://github.com/graphql-java/java-dataloader/pull/146

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2e61bf29-5430-3b8c-847a-7d072edb784a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB2C:240DB3:12D6DDC:1A6F8FE:696FCAD2
html-safe-nonce69eb96d8ecfabe8f501e35c65312ee310de85cb2dbeefe92a16b408b2d5c3466
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjJDOjI0MERCMzoxMkQ2RERDOjFBNkY4RkU6Njk2RkNBRDIiLCJ2aXNpdG9yX2lkIjoiNTk2NTc1NTIwNDM4NjAyNDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac121c8d766d03849ebe4e8d733ca591c4b798be9dcb3cd07535a5af5f82fffa66
hovercard-subject-tagpull_request:1845377197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/graphql-java/java-dataloader/146/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c4f368357d1690647587a7b24962ae1f74fed986a18c4ce6e4300c0e27361c28/graphql-java/java-dataloader/pull/146
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c4f368357d1690647587a7b24962ae1f74fed986a18c4ce6e4300c0e27361c28/graphql-java/java-dataloader/pull/146
og:image:altCurrently, when accessing values from the DataLoader's CacheMap, we first check #containsKey before invoking #get. This is problematic for two reasons: the underlying cache's metrics are s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexandreCarlton
hostnamegithub.com
expected-hostnamegithub.com
None0a44b41159f8508d767a50a41d4355b6e6607de801262664cbe75414886e44e9
turbo-cache-controlno-preview
go-importgithub.com/graphql-java/java-dataloader git https://github.com/graphql-java/java-dataloader.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id97364654
octolytics-dimension-repository_nwographql-java/java-dataloader
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id97364654
octolytics-dimension-repository_network_root_nwographql-java/java-dataloader
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release347f3ebfaef84b36b267c7a20bade84594f267d5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/java-dataloader/pull/146#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F146
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F146
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=graphql-java%2Fjava-dataloader
Reloadhttps://github.com/graphql-java/java-dataloader/pull/146
Reloadhttps://github.com/graphql-java/java-dataloader/pull/146
Reloadhttps://github.com/graphql-java/java-dataloader/pull/146
graphql-java https://github.com/graphql-java
java-dataloaderhttps://github.com/graphql-java/java-dataloader
Notifications https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Fork 95 https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Star 520 https://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader
Code https://github.com/graphql-java/java-dataloader
Issues 1 https://github.com/graphql-java/java-dataloader/issues
Pull requests 10 https://github.com/graphql-java/java-dataloader/pulls
Discussions https://github.com/graphql-java/java-dataloader/discussions
Actions https://github.com/graphql-java/java-dataloader/actions
Projects 0 https://github.com/graphql-java/java-dataloader/projects
Wiki https://github.com/graphql-java/java-dataloader/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/graphql-java/java-dataloader/security
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/146
Insights https://github.com/graphql-java/java-dataloader/pulse
Code https://github.com/graphql-java/java-dataloader
Issues https://github.com/graphql-java/java-dataloader/issues
Pull requests https://github.com/graphql-java/java-dataloader/pulls
Discussions https://github.com/graphql-java/java-dataloader/discussions
Actions https://github.com/graphql-java/java-dataloader/actions
Projects https://github.com/graphql-java/java-dataloader/projects
Wiki https://github.com/graphql-java/java-dataloader/wiki
Security https://github.com/graphql-java/java-dataloader/security
Insights https://github.com/graphql-java/java-dataloader/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fjava-dataloader%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/graphql-java/java-dataloader/pull/146#issue-comment-box
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/java-dataloader/tree/master
AlexandreCarlton:dont-check-key-is-present-before-cache-map-gethttps://github.com/AlexandreCarlton/java-dataloader/tree/dont-check-key-is-present-before-cache-map-get
Remove CacheMap#containsKey before #get https://github.com/graphql-java/java-dataloader/pull/146#top
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/java-dataloader/tree/master
AlexandreCarlton:dont-check-key-is-present-before-cache-map-gethttps://github.com/AlexandreCarlton/java-dataloader/tree/dont-check-key-is-present-before-cache-map-get
Conversation 1 https://github.com/graphql-java/java-dataloader/pull/146
Commits 1 https://github.com/graphql-java/java-dataloader/pull/146/commits
Checks 0 https://github.com/graphql-java/java-dataloader/pull/146/checks
Files changed 2 https://github.com/graphql-java/java-dataloader/pull/146/files
https://github.co/hiddenchars
https://github.com/graphql-java/java-dataloader/pull/{{ revealButtonHref }}
https://github.com/AlexandreCarlton
AlexandreCarltonhttps://github.com/AlexandreCarlton
Apr 29, 2024https://github.com/graphql-java/java-dataloader/pull/146#issue-2268659198
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/146
https://github.com/AlexandreCarlton
Remove CacheMap#containsKey before #gethttps://github.com/graphql-java/java-dataloader/pull/146/commits/12a73d31495b71e4f003bc260796718399034909
12a73d3https://github.com/graphql-java/java-dataloader/pull/146/commits/12a73d31495b71e4f003bc260796718399034909
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
Apr 29, 2024 https://github.com/graphql-java/java-dataloader/pull/146#pullrequestreview-2029822276
View reviewed changes https://github.com/graphql-java/java-dataloader/pull/146/files/12a73d31495b71e4f003bc260796718399034909
bbakermanhttps://github.com/bbakerman
https://github.com/graphql-java/java-dataloader/pull/146#pullrequestreview-2029822276
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/146
https://github.com/bbakerman
bbakermanhttps://github.com/bbakerman
3a16d9chttps://github.com/graphql-java/java-dataloader/commit/3a16d9cd30dfb32d99790f13213ea527a80affe6
Apr 29, 2024https://github.com/graphql-java/java-dataloader/pull/146#event-12650287780
AlexandreCarltonhttps://github.com/AlexandreCarlton
Apr 30, 2024 https://github.com/graphql-java/java-dataloader/pull/146#ref-commit-42cab40
https://github.com/AlexandreCarlton
Verify a throwing CacheMap#get does not break DataLoaderhttps://github.com/AlexandreCarlton/java-dataloader/commit/42cab409b8f5d3b7b44d7e690a0bef7e17efdc85
42cab40https://github.com/AlexandreCarlton/java-dataloader/commit/42cab409b8f5d3b7b44d7e690a0bef7e17efdc85
graphql-java#146https://github.com/graphql-java/java-dataloader/pull/146
https://github.com/AlexandreCarlton
AlexandreCarltonhttps://github.com/AlexandreCarlton
Apr 30, 2024 https://github.com/graphql-java/java-dataloader/pull/146#ref-pullrequest-2271131621
Verify a throwing CacheMap#get does not break DataLoader #147 https://github.com/graphql-java/java-dataloader/pull/147
https://github.com/dondonz
dondonzhttps://github.com/dondonz
Next release 3.4.0https://github.com/graphql-java/java-dataloader/milestone/11
May 17, 2024https://github.com/graphql-java/java-dataloader/pull/146#event-12853278281
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fjava-dataloader%2Fpull%2F146
https://github.com/bbakerman
bbakerman https://github.com/bbakerman
https://github.com/graphql-java/java-dataloader/pull/146/files/12a73d31495b71e4f003bc260796718399034909
3.4.0 https://github.com/graphql-java/java-dataloader/milestone/11
Please reload this pagehttps://github.com/graphql-java/java-dataloader/pull/146
https://github.com/AlexandreCarlton
https://github.com/bbakerman
https://github.com/dondonz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.