René's URL Explorer Experiment


Title: Make dead Spock conditions in execution and directive tests run by costajohnt · Pull Request #4565 · graphql-java/graphql-java · GitHub

Open Graph Title: Make dead Spock conditions in execution and directive tests run by costajohnt · Pull Request #4565 · graphql-java/graphql-java

X Title: Make dead Spock conditions in execution and directive tests run by costajohnt · Pull Request #4565 · graphql-java/graphql-java

Description: Several Spock checks in these tests were never evaluated as conditions, so they could not fail. Spock only asserts top-level expressions in then:/expect:; a comparison inside if/else is evaluated and discarded, and !x instanceof Y parses as (!x) instanceof Y, which is always false. ExecutionStrategyTest (non-null scalar feature): the whole then: was an if/else, so it asserted nothing. Made live, all three rows failed, because the test passed the nullable type instead of the non-null typeInfo it built, completeValue reports the error through the field value future rather than throwing, and the no-error row expected an exception. The test now uses typeInfo, joins the future, and asserts the exception and error count against errorExpected. SubscriptionExecutionStrategyTest: message.data == null was inside a closure. The actual payload is [newMessage: null] (newMessage is nullable, so the null bubbles up to it), which is now asserted. DeferWithDataLoaderTest: the batch loader counter checks were inside if/else; they now use assert and pass in all three rows. ValueTraverserTest, SchemaGeneratorDirectiveHelperTest: !x instanceof GraphQLObjectType becomes !(x instanceof GraphQLObjectType). Test-only change. The five classes pass locally (151 tests). Found with groovyfmt, a Groovy formatter and linter.

Open Graph Description: Several Spock checks in these tests were never evaluated as conditions, so they could not fail. Spock only asserts top-level expressions in then:/expect:; a comparison inside if/else is evaluated a...

X Description: Several Spock checks in these tests were never evaluated as conditions, so they could not fail. Spock only asserts top-level expressions in then:/expect:; a comparison inside if/else is evaluated a...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4565

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:446b166f-2e72-e821-bdf7-a61b3ba9d4cf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC546:215B92:220B381:2D4C2CB:6B018AE2
html-safe-nonceb1ed08580b3b12a2d88d961af2eb8608d4e49201236180aedcc416b114c26298
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTQ2OjIxNUI5MjoyMjBCMzgxOjJENEMyQ0I6NkIwMThBRTIiLCJ2aXNpdG9yX2lkIjoiNzYyNzEwMTI0MjEyODQzNTkzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd5345f01da0e03a0b2b074e6bae266ac71e3bb5f795db2561e846723aa37fbc3
hovercard-subject-tagpull_request:5351882317
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4565/files
twitter:imagehttps://avatars.githubusercontent.com/u/14304404?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14304404?s=400&v=4
og:image:altSeveral Spock checks in these tests were never evaluated as conditions, so they could not fail. Spock only asserts top-level expressions in then:/expect:; a comparison inside if/else is evaluated a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4565/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4565%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4565%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4565/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4565/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4565/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
costajohnt:fix-dead-spock-conditionshttps://github.com/costajohnt/graphql-java/tree/fix-dead-spock-conditions
Conversation 3 https://github.com/graphql-java/graphql-java/pull/4565
Commits 1 https://github.com/graphql-java/graphql-java/pull/4565/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4565/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4565/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4565/files
Make dead Spock conditions in execution and directive tests run https://github.com/graphql-java/graphql-java/pull/4565/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4565/files
9fee231 Make dead Spock conditions in execution and directive tests run costajohnt Nov 17, 2026 https://github.com/graphql-java/graphql-java/pull/4565/commits/9fee23175f835b48f1ed525819ec5bd4031b5d9b
Clear filters https://github.com/graphql-java/graphql-java/pull/4565/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4565/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4565/files
ValueTraverserTest.groovy https://github.com/graphql-java/graphql-java/pull/4565/files#diff-5a348698d5fd54e955c08a6f7b4364c74eeb08a4ef8310e089fa3138b99825e0
ExecutionStrategyTest.groovy https://github.com/graphql-java/graphql-java/pull/4565/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
SubscriptionExecutionStrategyTest.groovy https://github.com/graphql-java/graphql-java/pull/4565/files#diff-9eeca449a089bd4fd20aae431954d79464bd3a5b5761b90fc549f6657ff69f47
DeferWithDataLoaderTest.groovy https://github.com/graphql-java/graphql-java/pull/4565/files#diff-8bb0dd7aaa26911a3573363644408c924da319c0f00b737634232e6cb3067210
SchemaGeneratorDirectiveHelperTest.groovy https://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
src/test/groovy/graphql/analysis/values/ValueTraverserTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4565/files#diff-5a348698d5fd54e955c08a6f7b4364c74eeb08a4ef8310e089fa3138b99825e0
View file https://github.com/costajohnt/graphql-java/blob/9fee23175f835b48f1ed525819ec5bd4031b5d9b/src/test/groovy/graphql/analysis/values/ValueTraverserTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4565/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-5a348698d5fd54e955c08a6f7b4364c74eeb08a4ef8310e089fa3138b99825e0
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-5a348698d5fd54e955c08a6f7b4364c74eeb08a4ef8310e089fa3138b99825e0
src/test/groovy/graphql/execution/ExecutionStrategyTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4565/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
View file https://github.com/costajohnt/graphql-java/blob/9fee23175f835b48f1ed525819ec5bd4031b5d9b/src/test/groovy/graphql/execution/ExecutionStrategyTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4565/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-712673c8ad60dc594a5cc619fd4cd1905470cecb8f340a0240e839237532e47b
src/test/groovy/graphql/execution/SubscriptionExecutionStrategyTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4565/files#diff-9eeca449a089bd4fd20aae431954d79464bd3a5b5761b90fc549f6657ff69f47
View file https://github.com/costajohnt/graphql-java/blob/9fee23175f835b48f1ed525819ec5bd4031b5d9b/src/test/groovy/graphql/execution/SubscriptionExecutionStrategyTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4565/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-9eeca449a089bd4fd20aae431954d79464bd3a5b5761b90fc549f6657ff69f47
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-9eeca449a089bd4fd20aae431954d79464bd3a5b5761b90fc549f6657ff69f47
src/test/groovy/graphql/execution/instrumentation/dataloader/DeferWithDataLoaderTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4565/files#diff-8bb0dd7aaa26911a3573363644408c924da319c0f00b737634232e6cb3067210
View file https://github.com/costajohnt/graphql-java/blob/9fee23175f835b48f1ed525819ec5bd4031b5d9b/src/test/groovy/graphql/execution/instrumentation/dataloader/DeferWithDataLoaderTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4565/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-8bb0dd7aaa26911a3573363644408c924da319c0f00b737634232e6cb3067210
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-8bb0dd7aaa26911a3573363644408c924da319c0f00b737634232e6cb3067210
src/test/groovy/graphql/schema/idl/SchemaGeneratorDirectiveHelperTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
View file https://github.com/costajohnt/graphql-java/blob/9fee23175f835b48f1ed525819ec5bd4031b5d9b/src/test/groovy/graphql/schema/idl/SchemaGeneratorDirectiveHelperTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4565/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
https://github.com/graphql-java/graphql-java/pull/4565/files#diff-c110564413787bcd5d9816f152071a28d579f3eec5cf8e54cfdc4cd01dd80203
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4565/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.