René's URL Explorer Experiment


Title: stop re-walking variable values in validateOneOfInputTypes by nab-iha3 · Pull Request #4564 · graphql-java/graphql-java · GitHub

Open Graph Title: stop re-walking variable values in validateOneOfInputTypes by nab-iha3 · Pull Request #4564 · graphql-java/graphql-java

X Title: stop re-walking variable values in validateOneOfInputTypes by nab-iha3 · Pull Request #4564 · graphql-java/graphql-java

Description: input Filter { and: [Filter!] or: [Filter!] not: Filter eq: String }, Query.f(filter: Filter): Int, $f = {and: [{eq: "x"} x 100,000]} (~1.1 MB of variables), JDK 25: query ($f: Filter) { a0: f(filter: $f) a1: f(filter: $f) ... } aliases before after 1 16 ms 13 ms 1000 1615 ms 17 ms { items { f(filter: $f) } } over 10,000 items: 21.6 s before, 0.33 s after getArgumentValues calls validateOneOfInputTypes for every argument of every field invocation, and for a variable reference it walks the whole coerced variable value: every input object field and, since #4494 (mine), every list element. variable values are already coerced and checked once per request in coerceVariableValues, so each field that references the variable repeats the full walk. the cost is variable size times field invocations, which makes it a request amplification any client that can send variables can trigger, and the schema does not need a @oneOf type, only a list or input object argument. coercion itself also ran the recursive walk at every nested input object, so a value nested 120 deep was walked once per ancestor (50,000 leaves: 122 ms before, 11 ms after). validateOneOfInputTypes now returns for variable references, coerceVariableValues checks variable default values the way it already checked supplied ones, and external values are checked once after coercion instead of at every level. one visible change: an invalid default like query ($v: [OneOf] = [{a: null}]) is now rejected during variable coercion, the same as a supplied [{"a": null}], instead of as a field error. the getArgumentValues rows that fed hand-built invalid CoercedVariables (a state coercion no longer lets through) moved to a coerceVariableValues test with the same values and exceptions. the new default value test and the @Timeout(10) end to end test fail before the change.

Open Graph Description: input Filter { and: [Filter!] or: [Filter!] not: Filter eq: String }, Query.f(filter: Filter): Int, $f = {and: [{eq: "x"} x 100,000]} (~1.1 MB of variables), JDK 25: query ($f: Filter) { ...

X Description: input Filter { and: [Filter!] or: [Filter!] not: Filter eq: String }, Query.f(filter: Filter): Int, $f = {and: [{eq: "x"} x 100,000]} (~1.1 MB of variables), JDK 25: query ($f: Fi...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4564

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b39b2781-4650-a451-40c2-950ef684efe6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD12:38C5CF:278F930:3231099:6B017C6E
html-safe-noncecd69016e8ac7b5d2d3044929ab7bfea99416a9b45c690d7871af1cafce740857
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDEyOjM4QzVDRjoyNzhGOTMwOjMyMzEwOTk6NkIwMTdDNkUiLCJ2aXNpdG9yX2lkIjoiODYzNTczNzY0NDQzNTY5MjYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8aa8aa3a78c8daace37d946d6ddb966120b051f07a925547b28b5b760662bdd7
hovercard-subject-tagpull_request:5324529007
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4564/files
twitter:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
og:image:altinput Filter { and: [Filter!] or: [Filter!] not: Filter eq: String }, Query.f(filter: Filter): Int, $f = {and: [{eq: "x"} x 100,000]} (~1.1 MB of variables), JDK 25: query ($f: Filter) { ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4564/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4564%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4564%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4564/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4564/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4564/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
nab-iha3https://github.com/nab-iha3
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
nab-iha3:oneof-variable-rewalkhttps://github.com/nab-iha3/graphql-java/tree/oneof-variable-rewalk
Conversation 3 https://github.com/graphql-java/graphql-java/pull/4564
Commits 1 https://github.com/graphql-java/graphql-java/pull/4564/commits
Checks 9 https://github.com/graphql-java/graphql-java/pull/4564/checks
Files changed 3 https://github.com/graphql-java/graphql-java/pull/4564/files
stop re-walking variable values in validateOneOfInputTypes https://github.com/graphql-java/graphql-java/pull/4564/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4564/files
9452455 stop re-walking variable values in validateOneOfInputTypes nab-iha3 Nov 15, 2026 https://github.com/graphql-java/graphql-java/pull/4564/commits/945245571153d03d2053a1e334f5c7470c6843c6
Clear filters https://github.com/graphql-java/graphql-java/pull/4564/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4564/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4564/files
ValuesResolverConversion.java https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
ValuesResolverOneOfValidation.java https://github.com/graphql-java/graphql-java/pull/4564/files#diff-aa850fe4d226b7cf918bd7a0700052cfb62840a9a635f92163fc9f992cbea0c5
ValuesResolverTest.groovy https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
src/main/java/graphql/execution/ValuesResolverConversion.javahttps://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
View file https://github.com/graphql-java/graphql-java/blob/945245571153d03d2053a1e334f5c7470c6843c6/src/main/java/graphql/execution/ValuesResolverConversion.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4564/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-80b8748b24d21f6277a1e5019cd808621d276b1abb50bd87672d447f5c840ef0
src/main/java/graphql/execution/ValuesResolverOneOfValidation.javahttps://github.com/graphql-java/graphql-java/pull/4564/files#diff-aa850fe4d226b7cf918bd7a0700052cfb62840a9a635f92163fc9f992cbea0c5
View file https://github.com/graphql-java/graphql-java/blob/945245571153d03d2053a1e334f5c7470c6843c6/src/main/java/graphql/execution/ValuesResolverOneOfValidation.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4564/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-aa850fe4d226b7cf918bd7a0700052cfb62840a9a635f92163fc9f992cbea0c5
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-aa850fe4d226b7cf918bd7a0700052cfb62840a9a635f92163fc9f992cbea0c5
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-aa850fe4d226b7cf918bd7a0700052cfb62840a9a635f92163fc9f992cbea0c5
src/test/groovy/graphql/execution/ValuesResolverTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
View file https://github.com/graphql-java/graphql-java/blob/945245571153d03d2053a1e334f5c7470c6843c6/src/test/groovy/graphql/execution/ValuesResolverTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4564/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
https://github.com/graphql-java/graphql-java/pull/4564/files#diff-6df3af80107d5608b74eb17ef8f3b544ff9cf0e6c4ea06b02bf0accabf119821
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4564/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.