René's URL Explorer Experiment


Title: serialize downstream signals in CompletionStageSubscriber by nab-iha3 · Pull Request #4563 · graphql-java/graphql-java · GitHub

Open Graph Title: serialize downstream signals in CompletionStageSubscriber by nab-iha3 · Pull Request #4563 · graphql-java/graphql-java

X Title: serialize downstream signals in CompletionStageSubscriber by nab-iha3 · Pull Request #4563 · graphql-java/graphql-java

Description: subscription { ticks { name } } with default settings and an async Tick.name fetcher, two events resolving on two pool threads, subscriber counting callers inside onNext: pool-1-thread-1 onNext {ticks={name=event-0}} active=2 pool-1-thread-2 onNext {ticks={name=event-1}} active=1 max concurrent onNext calls = 2 CompletionStageSubscriber backs the default (unordered) subscription publisher and calls downstreamSubscriber.onNext from whenNextFinished on whichever thread completes each event's promise, outside its lock, so events resolving on different threads reach the subscriber at the same time (reactive streams rule 1.3). onError can overlap an in-progress onNext the same way, and a value that was already completing can still be delivered after onError. the TCK runs here skip the stochastic spec103 check and complete every promise on a single-thread executor, and CapturingSubscriber synchronizes its own onNext, so the tests never hit it. onNext and onError now reach the downstream subscriber under the existing lock, and onNext is skipped once the subscriber is terminal. CompletionStageOrderedSubscriber already delivered onNext under that lock; its drain loop now also stops once terminal. the two new CompletionStageSubscriberTest cases run against both subscribers and fail before the change (unordered: both, ordered: the onError one).

Open Graph Description: subscription { ticks { name } } with default settings and an async Tick.name fetcher, two events resolving on two pool threads, subscriber counting callers inside onNext: pool-1-thread-1 onNext {ti...

X Description: subscription { ticks { name } } with default settings and an async Tick.name fetcher, two events resolving on two pool threads, subscriber counting callers inside onNext: pool-1-thread-1 onNext {ti...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4563

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f08e3df3-5088-84d5-7f44-f5c40502624c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFD8:36A3E:215BF86:2C7D116:6B018AE7
html-safe-nonce09c88f56398701c4fb5a8767816c956b63abd70fe8ba64520957d02a8e5300d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkQ4OjM2QTNFOjIxNUJGODY6MkM3RDExNjo2QjAxOEFFNyIsInZpc2l0b3JfaWQiOiI4ODI5MjE5Mjg2NDE4NTU3NjcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac32ef23a0c4c3f1752a75216ce73a99a8be733e28f9c44042d655012050e19493
hovercard-subject-tagpull_request:5319817725
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4563/files
twitter:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
og:image:altsubscription { ticks { name } } with default settings and an async Tick.name fetcher, two events resolving on two pool threads, subscriber counting callers inside onNext: pool-1-thread-1 onNext {ti...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4563/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4563%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4563%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4563/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4563/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4563/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
nab-iha3:subscription-serialize-onnexthttps://github.com/nab-iha3/graphql-java/tree/subscription-serialize-onnext
Conversation 2 https://github.com/graphql-java/graphql-java/pull/4563
Commits 1 https://github.com/graphql-java/graphql-java/pull/4563/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4563/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4563/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4563/files
serialize downstream signals in CompletionStageSubscriber https://github.com/graphql-java/graphql-java/pull/4563/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4563/files
e0855d5 serialize downstream signals in CompletionStageSubscriber nab-iha3 Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4563/commits/e0855d5224c2944d2023d483a27d54a76d21b0f8
Clear filters https://github.com/graphql-java/graphql-java/pull/4563/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4563/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4563/files
CompletionStageOrderedSubscriber.java https://github.com/graphql-java/graphql-java/pull/4563/files#diff-065143864508e7acf6ef669079381847ba915e3dbc79ba01055e6210ead00e08
CompletionStageSubscriber.java https://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
CompletionStageSubscriberTest.groovy https://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
src/main/java/graphql/execution/reactive/CompletionStageOrderedSubscriber.javahttps://github.com/graphql-java/graphql-java/pull/4563/files#diff-065143864508e7acf6ef669079381847ba915e3dbc79ba01055e6210ead00e08
View file https://github.com/nab-iha3/graphql-java/blob/e0855d5224c2944d2023d483a27d54a76d21b0f8/src/main/java/graphql/execution/reactive/CompletionStageOrderedSubscriber.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4563/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-065143864508e7acf6ef669079381847ba915e3dbc79ba01055e6210ead00e08
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-065143864508e7acf6ef669079381847ba915e3dbc79ba01055e6210ead00e08
src/main/java/graphql/execution/reactive/CompletionStageSubscriber.javahttps://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
View file https://github.com/nab-iha3/graphql-java/blob/e0855d5224c2944d2023d483a27d54a76d21b0f8/src/main/java/graphql/execution/reactive/CompletionStageSubscriber.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4563/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-f0946f5c17ce375b221d861942d6b8091493db28c6952513e90f88bba1af0710
src/test/groovy/graphql/execution/reactive/CompletionStageSubscriberTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
View file https://github.com/nab-iha3/graphql-java/blob/e0855d5224c2944d2023d483a27d54a76d21b0f8/src/test/groovy/graphql/execution/reactive/CompletionStageSubscriberTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4563/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
https://github.com/graphql-java/graphql-java/pull/4563/files#diff-c99ecac3fbf1793cedb1ed45117627958df4520d68b07b5c4699720928ff0851
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4563/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.