René's URL Explorer Experiment


Title: Clarify what Coercing.valueToLiteral receives and when it is called by idsoke · Pull Request #4561 · graphql-java/graphql-java · GitHub

Open Graph Title: Clarify what Coercing.valueToLiteral receives and when it is called by idsoke · Pull Request #4561 · graphql-java/graphql-java

X Title: Clarify what Coercing.valueToLiteral receives and when it is called by idsoke · Pull Request #4561 · graphql-java/graphql-java

Description: Fixes #3558 The Coercing Javadoc did not say whether valueToLiteral gets an external or an internal value, or when graphql-java actually calls it, so scalar authors could not tell whether they need to implement it. This PR: Documents the three forms of an input value (external, internal, literal) with a date time example. States that valueToLiteral receives an external value (the same kind parseValue accepts), not an internal value or the result of serialize. Lists the cases that call it: printing (SchemaPrinter), introspection and validation of external-state values set via defaultValueProgrammatic(Object) or valueProgrammatic(Object) on applied directive arguments normalized variables (ValuesResolver#getNormalizedVariableValues) Notes that defaultValueLiteral(Value) and the deprecated defaultValue(Object) don't go through it, so schemas that only use those never hit the default UnsupportedOperationException. Adds a test in CoercingTest that pins this behaviour. As discussed in #3558 (comment). The earlier comment that it is only called via getNormalizedVariableValues is no longer accurate, which the new test shows. Ran ./gradlew test --tests graphql.schema.CoercingTest: 6 tests, 0 failures.

Open Graph Description: Fixes #3558 The Coercing Javadoc did not say whether valueToLiteral gets an external or an internal value, or when graphql-java actually calls it, so scalar authors could not tell whether they need...

X Description: Fixes #3558 The Coercing Javadoc did not say whether valueToLiteral gets an external or an internal value, or when graphql-java actually calls it, so scalar authors could not tell whether they need...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4561

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1181560f-5cca-5602-575b-247cd1bdd695
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BB4:213839:26F741D:31CC73B:6B0188EF
html-safe-nonce8b707450bfb0c79c72d7d6120fdff83e2759b82e00b23284164e8096edbb3d34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkI0OjIxMzgzOToyNkY3NDFEOjMxQ0M3M0I6NkIwMTg4RUYiLCJ2aXNpdG9yX2lkIjoiMTIyODYzMTc3Njg1MTc1NzI5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5b4fcefbc530f5270369fddafd664a1456c007de18468e0b050506c4593b672f
hovercard-subject-tagpull_request:5316957463
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4561/files
twitter:imagehttps://avatars.githubusercontent.com/u/15616497?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15616497?s=400&v=4
og:image:altFixes #3558 The Coercing Javadoc did not say whether valueToLiteral gets an external or an internal value, or when graphql-java actually calls it, so scalar authors could not tell whether they need...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4561/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4561%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4561%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4561/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4561/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4561/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
idsoke:coercing-valueToLiteral-docshttps://github.com/idsoke/graphql-java/tree/coercing-valueToLiteral-docs
Conversation 2 https://github.com/graphql-java/graphql-java/pull/4561
Commits 2 https://github.com/graphql-java/graphql-java/pull/4561/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4561/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4561/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4561/files
Clarify what Coercing.valueToLiteral receives and when it is called https://github.com/graphql-java/graphql-java/pull/4561/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/4561/files
932eb60 Clarify what Coercing.valueToLiteral receives and when it is called idsoke Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4561/commits/932eb601d0773c937eff8d77106cbf4a77a46f99
4ee54c1 Merge branch 'master' into coercing-valueToLiteral-docs idsoke Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4561/commits/4ee54c13d44689e356812b802be16a62564e725f
Clear filters https://github.com/graphql-java/graphql-java/pull/4561/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4561/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4561/files
Coercing.java https://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
CoercingTest.groovy https://github.com/graphql-java/graphql-java/pull/4561/files#diff-8dd3f6bf6a499dac7c194da8e7af70cad66af225aee0eded82fb1939c6907d70
src/main/java/graphql/schema/Coercing.javahttps://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
View file https://github.com/idsoke/graphql-java/blob/4ee54c13d44689e356812b802be16a62564e725f/src/main/java/graphql/schema/Coercing.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4561/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-ebe622796456d22918838d0ba131f989dc06ee9ce9a027d7ed48a4cd2688c0c3
src/test/groovy/graphql/schema/CoercingTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4561/files#diff-8dd3f6bf6a499dac7c194da8e7af70cad66af225aee0eded82fb1939c6907d70
View file https://github.com/idsoke/graphql-java/blob/4ee54c13d44689e356812b802be16a62564e725f/src/test/groovy/graphql/schema/CoercingTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4561/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-8dd3f6bf6a499dac7c194da8e7af70cad66af225aee0eded82fb1939c6907d70
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-8dd3f6bf6a499dac7c194da8e7af70cad66af225aee0eded82fb1939c6907d70
https://github.com/graphql-java/graphql-java/pull/4561/files#diff-8dd3f6bf6a499dac7c194da8e7af70cad66af225aee0eded82fb1939c6907d70
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4561/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.