René's URL Explorer Experiment


Title: Separate normalized directive computation from ordinary lookup by andimarek · Pull Request #4560 · graphql-java/graphql-java · GitHub

Open Graph Title: Separate normalized directive computation from ordinary lookup by andimarek · Pull Request #4560 · graphql-java/graphql-java

X Title: Separate normalized directive computation from ordinary lookup by andimarek · Pull Request #4560 · graphql-java/graphql-java

Description: Ordinary QueryDirectives lookups currently normalize the operation's variables and directive arguments as a side effect. A data fetcher asking for coerced directive values can therefore invoke custom scalar valueToLiteral() even though it never requests normalized values. Separate the two lazy computations. Ordinary lookups resolve and cache directives using coerced variables. getNormalizedInputValueByImmediateAppliedDirectives() uses its own thread-safe memoized computation, reuses the resolved applied-directive instances, and requests normalized variables only when needed. Fields without directives return an empty normalized map without evaluating the variable supplier. A normalized conversion failure leaves ordinary directive values available. Keep a direct applied-directive-to-AST map for later normalization, replacing the intermediate bidirectional maps. Preserve repeatable directive ordering and ordinary argument defaults. When directives are present but normalized variables are unavailable (including ENOF operations created from coerced variables), the normalized getter throws AssertException with a descriptive message instead of silently returning an empty map. This prevents the ENF-to-AST compiler from silently omitting directive arguments when normalization is unavailable. Ordinary directive lookups remain available. Correct the Javadoc that previously described normalized directive arguments as ENOF-only. Raw-variable ENOF creation itself continues to normalize variables as before. Spock coverage checks all six ordinary getters, both lookup orders, cache and instance reuse, repeatable directives across merged fields, empty fields, literal arguments with the builder’s default empty variables, conversion failure isolation, unavailable normalized variables on the coerced-variable ENOF path, and a real execution path with a custom scalar. The seven targeted ordinary-lookup regression cases fail against the original implementation; the focused directive/normalized-operation suite passes with this change. Full local Java 25 validation passed: ./gradlew assemble test testng check javadoc jacocoTestReport. The final builder test also passed in the focused suite. The assertion follow-up passed all 440 focused directive/normalized-operation tests and Javadoc. All 10 CI checks passed on the final commit, including the Java 17/21/25 test suites and per-class coverage gate. The coverage baseline is unchanged. No benchmark timing claim is made.

Open Graph Description: Ordinary QueryDirectives lookups currently normalize the operation's variables and directive arguments as a side effect. A data fetcher asking for coerced directive values can therefore invoke ...

X Description: Ordinary QueryDirectives lookups currently normalize the operation's variables and directive arguments as a side effect. A data fetcher asking for coerced directive values can therefore inv...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4560

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2664472d-77dd-54e6-f6bf-4c21e3547624
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECF6:3A4875:21BDA0D:2CF0CF2:6B0188E8
html-safe-nonced65f432be3abf868c721fa0026076edeaebcc54c83698767d87fa13c68641395
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Y2OjNBNDg3NToyMUJEQTBEOjJDRjBDRjI6NkIwMTg4RTgiLCJ2aXNpdG9yX2lkIjoiNzczMzU3NzEzMjExODQ3NzAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac973e12851bb792166e7dfa06b686c57ef7268595cb1e2121068bbf74c291bb67
hovercard-subject-tagpull_request:5316166400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4560/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altOrdinary QueryDirectives lookups currently normalize the operation's variables and directive arguments as a side effect. A data fetcher asking for coerced directive values can therefore invoke ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4560/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4560%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4560%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4560/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4560/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4560/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
codex/lazy-normalized-directive-valueshttps://github.com/graphql-java/graphql-java/tree/codex/lazy-normalized-directive-values
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4560
Commits 3 https://github.com/graphql-java/graphql-java/pull/4560/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4560/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4560/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4560/files
Separate normalized directive computation from ordinary lookup https://github.com/graphql-java/graphql-java/pull/4560/files#top
Show all changes 3 commits https://github.com/graphql-java/graphql-java/pull/4560/files
c7ccf7c Compute normalized directive arguments only when requested andimarek Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4560/commits/c7ccf7cfe85a7877caac43f230f1053bbc6c12ec
9c70f92 Cover normalized directive literals with default builder variables andimarek Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4560/commits/9c70f92675b4436d93aa995b3e1e3823a8f28762
36f2417 Assert when normalized directive variables are unavailable andimarek Nov 14, 2026 https://github.com/graphql-java/graphql-java/pull/4560/commits/36f2417365f91e86ce8f33046cee228cf65d518d
Clear filters https://github.com/graphql-java/graphql-java/pull/4560/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4560/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4560/files
QueryDirectives.java https://github.com/graphql-java/graphql-java/pull/4560/files#diff-2769213085ea7a41713b5cacbe06d0eb4b79556edc39ed98f77d9caaa04eb350
QueryDirectivesImpl.java https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
QueryDirectivesImplTest.groovy https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
QueryDirectivesIntegrationTest.groovy https://github.com/graphql-java/graphql-java/pull/4560/files#diff-8d1331a3a963cc4ad491b99667001a803b2a9f32c43b56b72c5db8a38f439cad
src/main/java/graphql/execution/directives/QueryDirectives.javahttps://github.com/graphql-java/graphql-java/pull/4560/files#diff-2769213085ea7a41713b5cacbe06d0eb4b79556edc39ed98f77d9caaa04eb350
View file https://github.com/graphql-java/graphql-java/blob/36f2417365f91e86ce8f33046cee228cf65d518d/src/main/java/graphql/execution/directives/QueryDirectives.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4560/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-2769213085ea7a41713b5cacbe06d0eb4b79556edc39ed98f77d9caaa04eb350
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-2769213085ea7a41713b5cacbe06d0eb4b79556edc39ed98f77d9caaa04eb350
src/main/java/graphql/execution/directives/QueryDirectivesImpl.javahttps://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
View file https://github.com/graphql-java/graphql-java/blob/36f2417365f91e86ce8f33046cee228cf65d518d/src/main/java/graphql/execution/directives/QueryDirectivesImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4560/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-000e5b986b832c3bce632e2e0fed5232d8abc978a9400c55ab01a684e73f677d
src/test/groovy/graphql/execution/directives/QueryDirectivesImplTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
View file https://github.com/graphql-java/graphql-java/blob/36f2417365f91e86ce8f33046cee228cf65d518d/src/test/groovy/graphql/execution/directives/QueryDirectivesImplTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4560/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
https://github.com/graphql-java/graphql-java/pull/4560/files#diff-a0b37b9c30ce910ceaa446f710a013b6afc59fa2005fad428d8f23a8296de1d6
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4560/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4560/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.