René's URL Explorer Experiment


Title: Improve lexer by andimarek · Pull Request #4551 · graphql-java/graphql-java · GitHub

Open Graph Title: Improve lexer by andimarek · Pull Request #4551 · graphql-java/graphql-java

X Title: Improve lexer by andimarek · Pull Request #4551 · graphql-java/graphql-java

Description: Oversized numeric literals are now rejected while the lexer is matching them, before it scans the entire literal or converts it to an arbitrary-precision number. The configured numeric-character limit also stops long malformed exponents. The lexer throws an internal exception carrying the start line, column, and configured limit. Parser.parseImpl translates it into the existing localized ParseCancelledTooManyNumericLiteralCharactersException, preserving source mapping and normal GraphQL error reporting. This removes the numeric-limit callback from SafeTokenSource, its fallback rethrow, and the synthetic token/text copy previously used to invoke the callback. Regression coverage checks numeric boundaries and early lexing cancellation, source locations across multiple SDL sources, localized messages, standalone value parsing, and GraphQL execution returning an InvalidSyntaxError without invoking a data fetcher. The callback-specific tests are removed because that contract no longer exists. NumericLexerBenchmark covers small valid input, many small numbers, a large integer, and a malformed exponent. Validation: 304 focused parser tests passed on Java 25. Full local Java 25 validation passed: Spock (6,279 passed, 7 skipped), TestNG (141 passed, 49 skipped), checks, Javadoc, and JaCoCo. The local per-class coverage comparison found no regressions across 992 classes. GitHub CI passed on 5bdf8e14d: Java 17/21/25 tests and TestNG, build checks, Javadoc, jcstress, file validation, and the per-class coverage gate. The coverage baseline is unchanged.

Open Graph Description: Oversized numeric literals are now rejected while the lexer is matching them, before it scans the entire literal or converts it to an arbitrary-precision number. The configured numeric-character li...

X Description: Oversized numeric literals are now rejected while the lexer is matching them, before it scans the entire literal or converts it to an arbitrary-precision number. The configured numeric-character li...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4551

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4d412617-5cf6-f19e-c48d-b026f15cca84
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE16:24A0A:1C423A9:23A7330:6B0188FF
html-safe-nonce3cf7e815dabfe4c4ade88f9344cf18049c0c1a26dcfcaeb8c0121cccedb9a2a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTE2OjI0QTBBOjFDNDIzQTk6MjNBNzMzMDo2QjAxODhGRiIsInZpc2l0b3JfaWQiOiIzNjI2MzQwNjEwMzU4NzQxMjQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35ebbe090dbf18c4ac4fd80444d504ed86631453419d7d2329cdac43cd1a4d19
hovercard-subject-tagpull_request:5267044664
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4551/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altOversized numeric literals are now rejected while the lexer is matching them, before it scans the entire literal or converts it to an arbitrary-precision number. The configured numeric-character li...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4551/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4551%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4551%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4551/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4551/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4551/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
codex/improve-lexerhttps://github.com/graphql-java/graphql-java/tree/codex/improve-lexer
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4551
Commits 5 https://github.com/graphql-java/graphql-java/pull/4551/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4551/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4551/files
Improve lexer https://github.com/graphql-java/graphql-java/pull/4551/files#top
Show all changes 5 commits https://github.com/graphql-java/graphql-java/pull/4551/files
e4deed8 Improve lexer andimarek Nov 11, 2026 https://github.com/graphql-java/graphql-java/pull/4551/commits/e4deed836a7101e826abd76ea1ed54003695ace3
8931681 Refine lexer handling andimarek Nov 11, 2026 https://github.com/graphql-java/graphql-java/pull/4551/commits/8931681c88b3f2c278b10a621ff0cb535cfde4f5
3707be7 Simplify lexer handling andimarek Nov 11, 2026 https://github.com/graphql-java/graphql-java/pull/4551/commits/3707be749b10b653bcf0f8ebe56dd1d800ce451b
393eaea Test lexer limit when callback returns andimarek Nov 11, 2026 https://github.com/graphql-java/graphql-java/pull/4551/commits/393eaeaa8dbaab699e01c470e99a65f935c3b0b8
5bdf8e1 Translate numeric lexer limits at the parser boundary andimarek Nov 11, 2026 https://github.com/graphql-java/graphql-java/pull/4551/commits/5bdf8e14d48e6c868f829a75b1b92e140774a869
Clear filters https://github.com/graphql-java/graphql-java/pull/4551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4551/files
NumericLexerBenchmark.java https://github.com/graphql-java/graphql-java/pull/4551/files#diff-344fdf5f734cfb101cbdc436a83aa11a5b1b8c5d6ddb0dc43adc4afb9564c6c0
Graphql.g4 https://github.com/graphql-java/graphql-java/pull/4551/files#diff-14c455350150cb18f1c90123c66a63f66cca98d0c45bf5463bf641cf9e340165
GraphqlCommon.g4 https://github.com/graphql-java/graphql-java/pull/4551/files#diff-00f431f0386a21fe1249cf98b8722bf66c6f8df043c65136246d157ee5d64cc1
Parser.java https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
ParserOptions.java https://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
SafeTokenSource.java https://github.com/graphql-java/graphql-java/pull/4551/files#diff-f9fc01d56c3bffa9c70fee9c9b3ad888d6890b84d774c20a99b2526b31500ab8
NumericLiteralTooLongException.java https://github.com/graphql-java/graphql-java/pull/4551/files#diff-6e8b8cee887469f55f2e5e784115dedd2f11efb871d76bedc261c58691835ca2
ParserExceptionTest.groovy https://github.com/graphql-java/graphql-java/pull/4551/files#diff-a29df7e8bda9b94f312fbb45b59eac2ad908cc13e19b5ca8cecfe14df7b8d694
ParserStressTest.groovy https://github.com/graphql-java/graphql-java/pull/4551/files#diff-4043a7e78c088aeef9a19fc11ca6875fdf79fb86ef4b77c21f3d6a74a031333f
SafeTokenSourceTest.groovy https://github.com/graphql-java/graphql-java/pull/4551/files#diff-8f3b440bcebda9dab75e5c192e71b0b7de05ddbcbe6b8eab9d53e936fb8edff3
src/jmh/java/benchmark/NumericLexerBenchmark.javahttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-344fdf5f734cfb101cbdc436a83aa11a5b1b8c5d6ddb0dc43adc4afb9564c6c0
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/jmh/java/benchmark/NumericLexerBenchmark.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
src/main/antlr/Graphql.g4https://github.com/graphql-java/graphql-java/pull/4551/files#diff-14c455350150cb18f1c90123c66a63f66cca98d0c45bf5463bf641cf9e340165
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/antlr/Graphql.g4
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-14c455350150cb18f1c90123c66a63f66cca98d0c45bf5463bf641cf9e340165
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-14c455350150cb18f1c90123c66a63f66cca98d0c45bf5463bf641cf9e340165
src/main/antlr/GraphqlCommon.g4https://github.com/graphql-java/graphql-java/pull/4551/files#diff-00f431f0386a21fe1249cf98b8722bf66c6f8df043c65136246d157ee5d64cc1
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/antlr/GraphqlCommon.g4
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-00f431f0386a21fe1249cf98b8722bf66c6f8df043c65136246d157ee5d64cc1
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-00f431f0386a21fe1249cf98b8722bf66c6f8df043c65136246d157ee5d64cc1
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-00f431f0386a21fe1249cf98b8722bf66c6f8df043c65136246d157ee5d64cc1
src/main/java/graphql/parser/Parser.javahttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/java/graphql/parser/Parser.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-24ba77f7c181cfd66deb300610d9d36d8ad43a42defd2d8d899da88a8c77f989
src/main/java/graphql/parser/ParserOptions.javahttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/java/graphql/parser/ParserOptions.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-cc1fab9887f0cf77d8caf9afdf45a006206cf0a572a09b1c4992af7c06ce53f6
src/main/java/graphql/parser/SafeTokenSource.javahttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-f9fc01d56c3bffa9c70fee9c9b3ad888d6890b84d774c20a99b2526b31500ab8
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/java/graphql/parser/SafeTokenSource.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-f9fc01d56c3bffa9c70fee9c9b3ad888d6890b84d774c20a99b2526b31500ab8
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-f9fc01d56c3bffa9c70fee9c9b3ad888d6890b84d774c20a99b2526b31500ab8
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-f9fc01d56c3bffa9c70fee9c9b3ad888d6890b84d774c20a99b2526b31500ab8
src/main/java/graphql/parser/antlr/NumericLiteralTooLongException.javahttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-6e8b8cee887469f55f2e5e784115dedd2f11efb871d76bedc261c58691835ca2
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/main/java/graphql/parser/antlr/NumericLiteralTooLongException.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
src/test/groovy/graphql/parser/ParserExceptionTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-a29df7e8bda9b94f312fbb45b59eac2ad908cc13e19b5ca8cecfe14df7b8d694
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/test/groovy/graphql/parser/ParserExceptionTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-a29df7e8bda9b94f312fbb45b59eac2ad908cc13e19b5ca8cecfe14df7b8d694
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-a29df7e8bda9b94f312fbb45b59eac2ad908cc13e19b5ca8cecfe14df7b8d694
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-a29df7e8bda9b94f312fbb45b59eac2ad908cc13e19b5ca8cecfe14df7b8d694
src/test/groovy/graphql/parser/ParserStressTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4551/files#diff-4043a7e78c088aeef9a19fc11ca6875fdf79fb86ef4b77c21f3d6a74a031333f
View file https://github.com/graphql-java/graphql-java/blob/5bdf8e14d48e6c868f829a75b1b92e140774a869/src/test/groovy/graphql/parser/ParserStressTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4551/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-4043a7e78c088aeef9a19fc11ca6875fdf79fb86ef4b77c21f3d6a74a031333f
https://github.com/graphql-java/graphql-java/pull/4551/files#diff-4043a7e78c088aeef9a19fc11ca6875fdf79fb86ef4b77c21f3d6a74a031333f
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4551/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4551/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.