René's URL Explorer Experiment


Title: stop copying the error list on every add in ExecutionContext by nab-iha3 · Pull Request #4532 · graphql-java/graphql-java · GitHub

Open Graph Title: stop copying the error list on every add in ExecutionContext by nab-iha3 · Pull Request #4532 · graphql-java/graphql-java

X Title: stop copying the error list on every add in ExecutionContext by nab-iha3 · Pull Request #4532 · graphql-java/graphql-java

Description: { items(n: N) { b0: bad b1: bad ... b999: bad } }, 9.9 KB, where the Item.bad fetcher throws (JDK 25, -Xmx4g): field errors before after 160,000 9,017 ms 2,361 ms 320,000 154,313 ms 3,808 ms ExecutionContext.addError and addErrors append by building a new ImmutableList from the old one plus the new error, so collecting N field errors costs N^2/2 element copies into freshly allocated arrays. the error count is set by the request: aliases of any field that errors (an auth check rejecting an anonymous caller, a fetcher rejecting its arguments) times the length of the list above it, so a ~10 KB query can keep an executor thread busy for minutes. a plain loop of 200,000 addError calls takes 75 s before and 0.56 s after on a 1 GB heap. errors now go into an ArrayList guarded by the existing errorsLock, and getErrors() returns an ImmutableList copy taken under the same lock. it is only read when results are assembled, and callers still get an immutable snapshot. the new ExecutionContextTest case adds 200,000 errors under @Timeout(10): it times out before the change (84 s) and passes in 1.5 s after.

Open Graph Description: { items(n: N) { b0: bad b1: bad ... b999: bad } }, 9.9 KB, where the Item.bad fetcher throws (JDK 25, -Xmx4g): field errors before after 160,000 9,017 ms 2,361 ms 320,0...

X Description: { items(n: N) { b0: bad b1: bad ... b999: bad } }, 9.9 KB, where the Item.bad fetcher throws (JDK 25, -Xmx4g): field errors before after 160,000 9,017 ms 2,361 ms 320,0...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4532

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b6d9f4c3-987e-2297-11c9-5d6328c35054
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB11A:928E2:217B623:2CAFA00:6B0188E0
html-safe-noncee5283e5529acde1dd729b2f6731e803e43fcbc57e16c5863837af7bcd3341587
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTFBOjkyOEUyOjIxN0I2MjM6MkNBRkEwMDo2QjAxODhFMCIsInZpc2l0b3JfaWQiOiI0MDMxNDAzMTI0OTgyOTA5MTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac457f88b39cdf7fd70698b1ebcd399ba01ee99b339ce4938d9fb28a62330cbdeb
hovercard-subject-tagpull_request:5133317195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4532/files
twitter:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
og:image:alt{ items(n: N) { b0: bad b1: bad ... b999: bad } }, 9.9 KB, where the Item.bad fetcher throws (JDK 25, -Xmx4g): field errors before after 160,000 9,017 ms 2,361 ms 320,0...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4532/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4532%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4532%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4532/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4532/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4532/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
nab-iha3:execution-context-error-listhttps://github.com/nab-iha3/graphql-java/tree/execution-context-error-list
Conversation 2 https://github.com/graphql-java/graphql-java/pull/4532
Commits 1 https://github.com/graphql-java/graphql-java/pull/4532/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4532/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4532/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4532/files
stop copying the error list on every add in ExecutionContext https://github.com/graphql-java/graphql-java/pull/4532/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4532/files
86b5186 stop copying the error list on every add in ExecutionContext nab-iha3 Nov 2, 2026 https://github.com/graphql-java/graphql-java/pull/4532/commits/86b518645ee36bea8fd7b8016a14d6583883de22
Clear filters https://github.com/graphql-java/graphql-java/pull/4532/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4532/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4532/files
ExecutionContext.java https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
ExecutionContextTest.groovy https://github.com/graphql-java/graphql-java/pull/4532/files#diff-30945c8cbe2f3a17d0958847ed0834b9efb1ca44d4c884e41a3e395da750a582
src/main/java/graphql/execution/ExecutionContext.javahttps://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
View file https://github.com/nab-iha3/graphql-java/blob/86b518645ee36bea8fd7b8016a14d6583883de22/src/main/java/graphql/execution/ExecutionContext.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4532/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
https://github.com/graphql-java/graphql-java/pull/4532/files#diff-494b2e14b6ff313b065fdfa8af71cee8d31709e3b8bc12049fed22bf7c34476f
src/test/groovy/graphql/execution/ExecutionContextTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4532/files#diff-30945c8cbe2f3a17d0958847ed0834b9efb1ca44d4c884e41a3e395da750a582
View file https://github.com/nab-iha3/graphql-java/blob/86b518645ee36bea8fd7b8016a14d6583883de22/src/test/groovy/graphql/execution/ExecutionContextTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4532/{{ revealButtonHref }}
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4532/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.