René's URL Explorer Experiment


Title: Performance improvements to checkTypeRegistry (isSubTypeOf) by xuorig · Pull Request #4528 · graphql-java/graphql-java · GitHub

Open Graph Title: Performance improvements to checkTypeRegistry (isSubTypeOf) by xuorig · Pull Request #4528 · graphql-java/graphql-java

X Title: Performance improvements to checkTypeRegistry (isSubTypeOf) by xuorig · Pull Request #4528 · graphql-java/graphql-java

Description: TypeDefinitionRegistry.isSubTypeOf is called for every field an implementing type shares with each of its interfaces, as part of SchemaTypeChecker.checkTypeRegistry, which both SchemaGenerator and FastSchemaGenerator run. On large schemas it is a very slow procedure. Each call allocated two TypeInfos (each with an ArrayDeque), plus another two per level of NonNull/List unwrapping. In the abstract-type case it looked up each type definition twice, once in isInterfaceOrUnion/isObjectTypeOrInterface and again in isPossibleType. It also used streams in implementsInterface and isUnionMember which similar to recent improvements to graphql-java, are changed into regular loops. Bug fix While working on this I also found a potential bug? The "equivalent type is a valid subtype" shortcut used TypeInfo.equals, which only compares the outermost wrapper and the innermost type name. So it returned true for: [String] <: [String!] [[String]] <: [String] [String] <: [[String]] As a result, the SDL type checker didn't report InterfaceFieldRedefinitionError for e.g. interface I { f: [String!] } / type T implements I { f: [String] }. With schema validation on, SchemaValidator still rejected these later. With validation off (withValidation(false), which could happen with FastSchemaGenerator), they were accepted. The name comparison now happens only once both sides are unwrapped to a named type. The recursion already handled the wrappers. TypeInfo.equals/hashCode are also fixed to compare the full wrapper chain, for anyone relying on them.

Open Graph Description: TypeDefinitionRegistry.isSubTypeOf is called for every field an implementing type shares with each of its interfaces, as part of SchemaTypeChecker.checkTypeRegistry, which both SchemaGenerator and ...

X Description: TypeDefinitionRegistry.isSubTypeOf is called for every field an implementing type shares with each of its interfaces, as part of SchemaTypeChecker.checkTypeRegistry, which both SchemaGenerator and ...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4528

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb94b2af-1b4e-dac8-8c21-6fb105c8e0ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9F2:2E124E:23834FA:2D50B27:6B018B09
html-safe-nonce790fa9674a46121bd1d415fc22b6d873af7ce6ff0db57be45d12839416d2e4a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUYyOjJFMTI0RToyMzgzNEZBOjJENTBCMjc6NkIwMThCMDkiLCJ2aXNpdG9yX2lkIjoiNDg3MTU4MDkzMjczMjA1NTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca18a65f6e5d61a531008d07d808a0025069973b3c7015274127f70cab619db85
hovercard-subject-tagpull_request:5122760659
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4528/files
twitter:imagehttps://avatars.githubusercontent.com/u/1919498?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1919498?s=400&v=4
og:image:altTypeDefinitionRegistry.isSubTypeOf is called for every field an implementing type shares with each of its interfaces, as part of SchemaTypeChecker.checkTypeRegistry, which both SchemaGenerator and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4528/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4528%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4528%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4528/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4528/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4528/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
xuorig:perf/allocation-free-is-subtype-ofhttps://github.com/xuorig/graphql-java/tree/perf/allocation-free-is-subtype-of
Conversation 3 https://github.com/graphql-java/graphql-java/pull/4528
Commits 2 https://github.com/graphql-java/graphql-java/pull/4528/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4528/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4528/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4528/files
Performance improvements to checkTypeRegistry (isSubTypeOf) https://github.com/graphql-java/graphql-java/pull/4528/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/4528/files
6f28612 Avoid TypeInfo allocations and repeated lookups in isSubTypeOf Nov 1, 2026 https://github.com/graphql-java/graphql-java/pull/4528/commits/6f286122cd055add1e5867cb92ea199b76581f52
912ed91 Fix isSubTypeOf treating types with different inner wrapping as equiv… Nov 2, 2026 https://github.com/graphql-java/graphql-java/pull/4528/commits/912ed916d614894241098cc239c0366f113da6ef
Clear filters https://github.com/graphql-java/graphql-java/pull/4528/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4528/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4528/files
TypeDefinitionRegistry.java https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
TypeInfo.java https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
SchemaTypeCheckerTest.groovy https://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
TypeDefinitionRegistryTest.groovy https://github.com/graphql-java/graphql-java/pull/4528/files#diff-03a8a4122fc2a5fba94e218baeeb1a5a91066aaff99fe46d1dcd78e10f1409d0
TypeInfoTest.groovy https://github.com/graphql-java/graphql-java/pull/4528/files#diff-cb37fdc525524cfa7598935a53bbeadecec3f7c0122efdd2d09dac8ad0cb1c22
src/main/java/graphql/schema/idl/TypeDefinitionRegistry.javahttps://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
View file https://github.com/xuorig/graphql-java/blob/912ed916d614894241098cc239c0366f113da6ef/src/main/java/graphql/schema/idl/TypeDefinitionRegistry.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4528/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f2b085da7be44e4e56c128961fb9b70c29da1f04a5f10c14aa1b9726f3b15f67
src/main/java/graphql/schema/idl/TypeInfo.javahttps://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
View file https://github.com/xuorig/graphql-java/blob/912ed916d614894241098cc239c0366f113da6ef/src/main/java/graphql/schema/idl/TypeInfo.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4528/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-f14d43ab3d3b6432091e73b4e944812074c01bc146c50d2094c8e4fc4b815d5c
src/test/groovy/graphql/schema/idl/SchemaTypeCheckerTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
View file https://github.com/xuorig/graphql-java/blob/912ed916d614894241098cc239c0366f113da6ef/src/test/groovy/graphql/schema/idl/SchemaTypeCheckerTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4528/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-3a8881a5dde20f458dc2e12b5f21584948277d1745ab67d4585871405da60ca1
src/test/groovy/graphql/schema/idl/TypeDefinitionRegistryTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4528/files#diff-03a8a4122fc2a5fba94e218baeeb1a5a91066aaff99fe46d1dcd78e10f1409d0
View file https://github.com/xuorig/graphql-java/blob/912ed916d614894241098cc239c0366f113da6ef/src/test/groovy/graphql/schema/idl/TypeDefinitionRegistryTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4528/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-03a8a4122fc2a5fba94e218baeeb1a5a91066aaff99fe46d1dcd78e10f1409d0
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-03a8a4122fc2a5fba94e218baeeb1a5a91066aaff99fe46d1dcd78e10f1409d0
src/test/groovy/graphql/schema/idl/TypeInfoTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4528/files#diff-cb37fdc525524cfa7598935a53bbeadecec3f7c0122efdd2d09dac8ad0cb1c22
View file https://github.com/xuorig/graphql-java/blob/912ed916d614894241098cc239c0366f113da6ef/src/test/groovy/graphql/schema/idl/TypeInfoTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4528/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-cb37fdc525524cfa7598935a53bbeadecec3f7c0122efdd2d09dac8ad0cb1c22
https://github.com/graphql-java/graphql-java/pull/4528/files#diff-cb37fdc525524cfa7598935a53bbeadecec3f7c0122efdd2d09dac8ad0cb1c22
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4528/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.