René's URL Explorer Experiment


Title: Rework query complexity limits with merged fields and occurrence budgets by andimarek · Pull Request #4523 · graphql-java/graphql-java · GitHub

Open Graph Title: Rework query complexity limits with merged fields and occurrence budgets by andimarek · Pull Request #4523 · graphql-java/graphql-java

X Title: Rework query complexity limits with merged fields and occurrence budgets by andimarek · Pull Request #4523 · graphql-java/graphql-java

Description: GraphQL Java implementation. Contribute to graphql-java/graphql-java development by creating an account on GitHub.

Open Graph Description: This PR reworks validation complexity protection to use merged fields, while retaining a separate budget for field occurrences after fragment expansion. It also replaces QueryComplexityLimits.newLi...

X Description: This PR reworks validation complexity protection to use merged fields, while retaining a separate budget for field occurrences after fragment expansion. It also replaces QueryComplexityLimits.newLi...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4523

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:86fed5a0-c7ba-704d-bc87-ebfa837f9bcb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7CC:1DC4CC:1CC682:267F9F:6B018914
html-safe-nonced597ba1eb4901c5aeb7f533df940e074324883e8f04df190a9fea80aed759655
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0NDOjFEQzRDQzoxQ0M2ODI6MjY3RjlGOjZCMDE4OTE0IiwidmlzaXRvcl9pZCI6IjczNDc2MTE1MTk1NjEwNzQ5NjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace32dfd10c78b0fefb0fcd8059e4afedef4358c671520079d8ac0a4ade7e818ab
hovercard-subject-tagpull_request:5105878967
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4523/commits
twitter:imagehttps://opengraph.githubassets.com/147b4e31f98e71c1757d87cd647c581c63a18f43aa916b78657e03df870c27ea/graphql-java/graphql-java/pull/4523
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/147b4e31f98e71c1757d87cd647c581c63a18f43aa916b78657e03df870c27ea/graphql-java/graphql-java/pull/4523
og:image:altThis PR reworks validation complexity protection to use merged fields, while retaining a separate budget for field occurrences after fragment expansion. It also replaces QueryComplexityLimits.newLi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameandimarek
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4523/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4523%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4523%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4523/commits
Reloadhttps://github.com/graphql-java/graphql-java/pull/4523/commits
Reloadhttps://github.com/graphql-java/graphql-java/pull/4523/commits
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
https://github.com/graphql-java/graphql-java
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
codex/general-dos-protectionhttps://github.com/graphql-java/graphql-java/tree/codex/general-dos-protection
Conversationhttps://github.com/graphql-java/graphql-java/pull/4523
Commits20 (20)https://github.com/graphql-java/graphql-java/pull/4523/commits
Checkshttps://github.com/graphql-java/graphql-java/pull/4523/checks
Files changedhttps://github.com/graphql-java/graphql-java/pull/4523/files
Rework query complexity limits with merged fields and occurrence budgetshttps://github.com/graphql-java/graphql-java/pull/4523/commits#top
andimarekhttps://github.com/andimarek
masterhttps://github.com/graphql-java/graphql-java/tree/master
codex/general-dos-protectionhttps://github.com/graphql-java/graphql-java/tree/codex/general-dos-protection
Add validation complexity benchmark workloadshttps://github.com/graphql-java/graphql-java/pull/4523/commits/78115f835a95f486b7739b8b8fa9b9dfb7432c2f
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
78115f8https://github.com/graphql-java/graphql-java/pull/4523/commits/78115f835a95f486b7739b8b8fa9b9dfb7432c2f
https://github.com/graphql-java/graphql-java/tree/78115f835a95f486b7739b8b8fa9b9dfb7432c2f
Use merged validation selections for general complexity limitshttps://github.com/graphql-java/graphql-java/pull/4523/commits/7b7adebd8315f7fee061081685c2c2828592616d
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
7b7adebhttps://github.com/graphql-java/graphql-java/pull/4523/commits/7b7adebd8315f7fee061081685c2c2828592616d
https://github.com/graphql-java/graphql-java/tree/7b7adebd8315f7fee061081685c2c2828592616d
Clarify shared limits and cover disabled-rule configurationshttps://github.com/graphql-java/graphql-java/pull/4523/commits/d48090d580cd91c4c19efbd8c269c2ca57421ef2
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
d48090dhttps://github.com/graphql-java/graphql-java/pull/4523/commits/d48090d580cd91c4c19efbd8c269c2ca57421ef2
https://github.com/graphql-java/graphql-java/tree/d48090d580cd91c4c19efbd8c269c2ca57421ef2
Reuse singleton field sets when grouping common parentshttps://github.com/graphql-java/graphql-java/pull/4523/commits/2e696c9bdd4a9bd81c0e2eaed35c99c521a8c990
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
2e696c9https://github.com/graphql-java/graphql-java/pull/4523/commits/2e696c9bdd4a9bd81c0e2eaed35c99c521a8c990
https://github.com/graphql-java/graphql-java/tree/2e696c9bdd4a9bd81c0e2eaed35c99c521a8c990
Key complexity summaries by shared validation statehttps://github.com/graphql-java/graphql-java/pull/4523/commits/155087b2acb907c0cf5374fcebfc12e63265698f
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
155087bhttps://github.com/graphql-java/graphql-java/pull/4523/commits/155087b2acb907c0cf5374fcebfc12e63265698f
https://github.com/graphql-java/graphql-java/tree/155087b2acb907c0cf5374fcebfc12e63265698f
Reduce traversal and count-cache allocation during validationhttps://github.com/graphql-java/graphql-java/pull/4523/commits/64720524bcd07ad13ba4c484ac486fdf0fe22b71
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
6472052https://github.com/graphql-java/graphql-java/pull/4523/commits/64720524bcd07ad13ba4c484ac486fdf0fe22b71
https://github.com/graphql-java/graphql-java/tree/64720524bcd07ad13ba4c484ac486fdf0fe22b71
Count leaf selections directly during complexity validationhttps://github.com/graphql-java/graphql-java/pull/4523/commits/f3ff7b59e9bac0206845cde193ed5641ff516b24
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
f3ff7b5https://github.com/graphql-java/graphql-java/pull/4523/commits/f3ff7b59e9bac0206845cde193ed5641ff516b24
https://github.com/graphql-java/graphql-java/tree/f3ff7b59e9bac0206845cde193ed5641ff516b24
Extract repeated coordinate lookup from the hot validation methodhttps://github.com/graphql-java/graphql-java/pull/4523/commits/f73299f0efe601e6eab82734df3a06c339d4de80
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
f73299fhttps://github.com/graphql-java/graphql-java/pull/4523/commits/f73299f0efe601e6eab82734df3a06c339d4de80
https://github.com/graphql-java/graphql-java/tree/f73299f0efe601e6eab82734df3a06c339d4de80
Identify leaves from merged selections without a separate AST scanhttps://github.com/graphql-java/graphql-java/pull/4523/commits/b8749afaefae43e3103f31a09fde8217f55c9d2b
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
b8749afhttps://github.com/graphql-java/graphql-java/pull/4523/commits/b8749afaefae43e3103f31a09fde8217f55c9d2b
https://github.com/graphql-java/graphql-java/tree/b8749afaefae43e3103f31a09fde8217f55c9d2b
Remove the empty-child branch after direct leaf countinghttps://github.com/graphql-java/graphql-java/pull/4523/commits/16ede762208b38e415c6aec59ab6099390f281e7
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
16ede76https://github.com/graphql-java/graphql-java/pull/4523/commits/16ede762208b38e415c6aec59ab6099390f281e7
https://github.com/graphql-java/graphql-java/tree/16ede762208b38e415c6aec59ab6099390f281e7
Limit expanded field occurrences during validationhttps://github.com/graphql-java/graphql-java/pull/4523/commits/f2480f14bbda2209ac4ed67f8376c098a94b6f51
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
f2480f1https://github.com/graphql-java/graphql-java/pull/4523/commits/f2480f14bbda2209ac4ed67f8376c098a94b6f51
https://github.com/graphql-java/graphql-java/tree/f2480f14bbda2209ac4ed67f8376c098a94b6f51
Clarify merged-field complexity count nameshttps://github.com/graphql-java/graphql-java/pull/4523/commits/d21b0d00c0b77756f3f864e1c3ec7311f0c5abe4
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
d21b0d0https://github.com/graphql-java/graphql-java/pull/4523/commits/d21b0d00c0b77756f3f864e1c3ec7311f0c5abe4
https://github.com/graphql-java/graphql-java/tree/d21b0d00c0b77756f3f864e1c3ec7311f0c5abe4
Rename validation field limit to maxMergedFieldCounthttps://github.com/graphql-java/graphql-java/pull/4523/commits/435b2d0035926d1132f40dfca88e40248c371335
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
435b2d0https://github.com/graphql-java/graphql-java/pull/4523/commits/435b2d0035926d1132f40dfca88e40248c371335
https://github.com/graphql-java/graphql-java/tree/435b2d0035926d1132f40dfca88e40248c371335
Add large schema fixture and query complexity measurementshttps://github.com/graphql-java/graphql-java/pull/4523/commits/c5e3ceca646156a4f65df3b737ef831252650735
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
c5e3cechttps://github.com/graphql-java/graphql-java/pull/4523/commits/c5e3ceca646156a4f65df3b737ef831252650735
https://github.com/graphql-java/graphql-java/tree/c5e3ceca646156a4f65df3b737ef831252650735
Merge latest master into merged-field complexity limitshttps://github.com/graphql-java/graphql-java/pull/4523/commits/5defbdd5813ff75cd515230fe7cb0e8322b60c5e
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
5defbddhttps://github.com/graphql-java/graphql-java/pull/4523/commits/5defbdd5813ff75cd515230fe7cb0e8322b60c5e
https://github.com/graphql-java/graphql-java/tree/5defbdd5813ff75cd515230fe7cb0e8322b60c5e
Reduce peak memory when loading the large schema fixturehttps://github.com/graphql-java/graphql-java/pull/4523/commits/0a2016df8c817a3694ab79354a7314962083607e
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
0a2016dhttps://github.com/graphql-java/graphql-java/pull/4523/commits/0a2016df8c817a3694ab79354a7314962083607e
https://github.com/graphql-java/graphql-java/tree/0a2016df8c817a3694ab79354a7314962083607e
Keep default protections in custom query complexity limitshttps://github.com/graphql-java/graphql-java/pull/4523/commits/8f60f23e212ba571d18a3d595d9e06db4c4cb909
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
8f60f23https://github.com/graphql-java/graphql-java/pull/4523/commits/8f60f23e212ba571d18a3d595d9e06db4c4cb909
https://github.com/graphql-java/graphql-java/tree/8f60f23e212ba571d18a3d595d9e06db4c4cb909
Initialize query complexity builders from JVM-wide defaultshttps://github.com/graphql-java/graphql-java/pull/4523/commits/750405a20e50fbdd546999c60e4e8cfe95ea73b1
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
750405ahttps://github.com/graphql-java/graphql-java/pull/4523/commits/750405a20e50fbdd546999c60e4e8cfe95ea73b1
https://github.com/graphql-java/graphql-java/tree/750405a20e50fbdd546999c60e4e8cfe95ea73b1
Rename query complexity factory to newLimitsWithDefaultshttps://github.com/graphql-java/graphql-java/pull/4523/commits/87f7128dd08bfc07d13a44a6656c715cdcdf55dd
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
87f7128https://github.com/graphql-java/graphql-java/pull/4523/commits/87f7128dd08bfc07d13a44a6656c715cdcdf55dd
https://github.com/graphql-java/graphql-java/tree/87f7128dd08bfc07d13a44a6656c715cdcdf55dd
Cover nested fragment expansion complexity with explicit exampleshttps://github.com/graphql-java/graphql-java/pull/4523/commits/49b6e71e0fbc85b9b806ac425ad610941bf73f2b
https://github.com/andimarek
andimarekhttps://github.com/graphql-java/graphql-java/commits?author=andimarek
49b6e71https://github.com/graphql-java/graphql-java/pull/4523/commits/49b6e71e0fbc85b9b806ac425ad610941bf73f2b
https://github.com/graphql-java/graphql-java/tree/49b6e71e0fbc85b9b806ac425ad610941bf73f2b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.