René's URL Explorer Experiment


Title: Coerce field arguments before invoking data fetchers by andimarek · Pull Request #4522 · graphql-java/graphql-java · GitHub

Open Graph Title: Coerce field arguments before invoking data fetchers by andimarek · Pull Request #4522 · graphql-java/graphql-java

X Title: Coerce field arguments before invoking data fetchers by andimarek · Pull Request #4522 · graphql-java/graphql-java

Description: Argument coercion currently runs only when something reads a field's arguments. A data fetcher that ignores them can therefore return a result for invalid inputs; one that reads them can perform side effects before coercion fails. For example, query($v: String = "default") { f(arg: [$v]) } with {"v": null} passes document and variable validation against f(arg: [String!]!): String, but argument coercion must fail before calling f. This complements #4507, which added the non-null checks themselves. Force the existing memoized argument supplier before invoking either a regular or lightweight data fetcher, inside the existing exception-handling boundary. This preserves field-error handling, null propagation, instrumentation, and DataLoader dispatch. Fields without argument definitions keep lazy environment construction. Adds 45 Spock cases covering queries, mutation side effects and ordering, subscriptions, nested inputs, property/lightweight fetchers, aliases and list paths, skipped/unreached fields, deferred results, scalar coercion/memoization, exception handlers, and all three DataLoader dispatch modes. On master, 36 of these cases fail; with this change, all 45 pass. Validation: ./gradlew test testng jacocoTestReport on Java 25 passed (6,223 tests, zero failures, 57 existing skips). The local per-class coverage comparison against the committed baseline found no regressions. Exploratory local JMH comparison with master (Java 25, 2 forks, 3 × 1s warmup, 5 × 1s measurement): a 100-item query took 15.1 → 15.7 µs without arguments, 57.9 → 57.8 µs when fetchers read literal arguments, and 15.8 → 53.8 µs when property fetchers ignored literal arguments. The latter now performs the required coercion. The existing ExecutionBenchmark measured 269 → 262 µs, within measurement uncertainty. The no-argument path retains its allocation savings but does add the argument-definition check.

Open Graph Description: Argument coercion currently runs only when something reads a field's arguments. A data fetcher that ignores them can therefore return a result for invalid inputs; one that reads them can perfor...

X Description: Argument coercion currently runs only when something reads a field's arguments. A data fetcher that ignores them can therefore return a result for invalid inputs; one that reads them can pe...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4522

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9542ba8e-afa3-8c2f-7f53-12625d424bf3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97F6:17FB7:1B106FB:2245261:6B018B0D
html-safe-nonced66e5f6534686824bc92080b8d1e057407b8fc8f7ae5111756ceb1296ee5fac7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0Y2OjE3RkI3OjFCMTA2RkI6MjI0NTI2MTo2QjAxOEIwRCIsInZpc2l0b3JfaWQiOiIyOTE5OTI3NDAxOTQ3NDMzNzQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac102f1c353517a474cca33966e28d81506add09577a6ecdcf541d7662c2a51945
hovercard-subject-tagpull_request:5104715094
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4522/files
twitter:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1706744?s=400&v=4
og:image:altArgument coercion currently runs only when something reads a field's arguments. A data fetcher that ignores them can therefore return a result for invalid inputs; one that reads them can perfor...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4522/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4522%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4522%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4522/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4522/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4522/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
masterhttps://github.com/graphql-java/graphql-java/tree/master
codex/fix-lazy-argument-coercionhttps://github.com/graphql-java/graphql-java/tree/codex/fix-lazy-argument-coercion
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4522
Commits 2 https://github.com/graphql-java/graphql-java/pull/4522/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4522/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4522/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4522/files
Coerce field arguments before invoking data fetchers https://github.com/graphql-java/graphql-java/pull/4522/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/4522/files
2a32fc3 Coerce field arguments before invoking data fetchers andimarek Nov 1, 2026 https://github.com/graphql-java/graphql-java/pull/4522/commits/2a32fc31617c3ee42e6d9d86c3b66f3a3044cbf8
b2fadc6 Merge branch 'master' into codex/fix-lazy-argument-coercion andimarek Nov 1, 2026 https://github.com/graphql-java/graphql-java/pull/4522/commits/b2fadc64a0247e2a6000fe56475e89ad1d5f27df
Clear filters https://github.com/graphql-java/graphql-java/pull/4522/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4522/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4522/files
ExecutionStrategy.java https://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
ArgumentCoercionExecutionTest.groovy https://github.com/graphql-java/graphql-java/pull/4522/files#diff-792d2611be684867e2456c9e8c8f77a1e006f749461c215637c7680b36c11b8d
src/main/java/graphql/execution/ExecutionStrategy.javahttps://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
View file https://github.com/graphql-java/graphql-java/blob/b2fadc64a0247e2a6000fe56475e89ad1d5f27df/src/main/java/graphql/execution/ExecutionStrategy.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4522/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
https://github.com/graphql-java/graphql-java/pull/4522/files#diff-2ece51452808f5a3fd08db50de534a12806aa6cd4e236c549dff9759884e43ff
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4522/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4522/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.