René's URL Explorer Experiment


Title: verify the query text against the persisted query id on cache hits by nab-iha3 · Pull Request #4512 · graphql-java/graphql-java · GitHub

Open Graph Title: verify the query text against the persisted query id on cache hits by nab-iha3 · Pull Request #4512 · graphql-java/graphql-java

X Title: verify the query text against the persisted query id on cache hits by nab-iha3 · Pull Request #4512 · graphql-java/graphql-java

Description: Spock, ApolloPersistedQuerySupportTest on master: will have error if the query text does not match a query hash that is already cached FAILED er.data == null | | | | | false | [secret:secret] PersistedQuerySupport.getDocumentAsync only calls persistedQueryIdIsInvalid from the cache-miss callback. Once a hash is cached, any request carrying it runs the cached document whatever query text it sends: { public } sent with sha256 of { secret } executes { secret } with no error, while ExecutionInput.getQuery() (what instrumentation, logging and the execution id provider see) still says { public }. Apollo's server rejects this case with "provided sha does not match query", and #2395 asked for the same error whenever both a hash and a query are present. The check now runs before the cache lookup when real query text is sent (not blank, not PERSISTED_QUERY_MARKER). The base persistedQueryIdIsInvalid still returns false, so only ApolloPersistedQuerySupport behaves differently. The existing "hash in preference to query text" test asserted the old behaviour, so it now sends matching text, and new cases cover the mismatch at the unit level and end to end through GraphQL.

Open Graph Description: Spock, ApolloPersistedQuerySupportTest on master: will have error if the query text does not match a query hash that is already cached FAILED er.data == null | | | | | false ...

X Description: Spock, ApolloPersistedQuerySupportTest on master: will have error if the query text does not match a query hash that is already cached FAILED er.data == null | | | | | false ...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4512

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7edec6eb-c0e6-c5d5-39bd-c6363ca0f284
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD04:20AA01:2661320:30B7AE9:6B017C6D
html-safe-nonceef82bc898a5fdc08eaad1a30e1e268399f35f69df15561525e68973436ca0a63
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDA0OjIwQUEwMToyNjYxMzIwOjMwQjdBRTk6NkIwMTdDNkQiLCJ2aXNpdG9yX2lkIjoiNTk0NDY2NzI5NDIwNTU3NDI1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac421b2b56eb0b1756c18b8f2ad1d0b2746a7a2af64bac346351346de51753cd41
hovercard-subject-tagpull_request:5018500784
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4512/files
twitter:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/330788315?s=400&v=4
og:image:altSpock, ApolloPersistedQuerySupportTest on master: will have error if the query text does not match a query hash that is already cached FAILED er.data == null | | | | | false ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4512/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4512%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4512%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4512/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4512/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4512/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
nab-iha3https://github.com/nab-iha3
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
nab-iha3:persisted-query-hash-check-on-hithttps://github.com/nab-iha3/graphql-java/tree/persisted-query-hash-check-on-hit
Conversation 1 https://github.com/graphql-java/graphql-java/pull/4512
Commits 1 https://github.com/graphql-java/graphql-java/pull/4512/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4512/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4512/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4512/files
verify the query text against the persisted query id on cache hits https://github.com/graphql-java/graphql-java/pull/4512/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4512/files
74d7e5b verify persisted query id against query text on cache hits nab-iha3 Oct 26, 2026 https://github.com/graphql-java/graphql-java/pull/4512/commits/74d7e5b9965eccf43e818fb41dca265b744e4ded
Clear filters https://github.com/graphql-java/graphql-java/pull/4512/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4512/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4512/files
PersistedQuerySupport.java https://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
ApolloPersistedQuerySupportTest.groovy https://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
src/main/java/graphql/execution/preparsed/persisted/PersistedQuerySupport.javahttps://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
View file https://github.com/graphql-java/graphql-java/blob/74d7e5b9965eccf43e818fb41dca265b744e4ded/src/main/java/graphql/execution/preparsed/persisted/PersistedQuerySupport.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4512/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-c48b518bdc9f4fc7e82b00f606a5a2cdcb9e8b00a56625e2faf404345f9c410b
src/test/groovy/graphql/execution/preparsed/persisted/ApolloPersistedQuerySupportTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
View file https://github.com/graphql-java/graphql-java/blob/74d7e5b9965eccf43e818fb41dca265b744e4ded/src/test/groovy/graphql/execution/preparsed/persisted/ApolloPersistedQuerySupportTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4512/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
https://github.com/graphql-java/graphql-java/pull/4512/files#diff-5926af203b6a63ff10e4dbf71869e31f9c1f840e50a8c54df5f09ac7a79075c0
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4512/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.