René's URL Explorer Experiment


Title: Reduce PerLevelDataLoaderDispatchStrategy bookkeeping: pack per-level counters into one AtomicLong by Meemaw · Pull Request #4502 · graphql-java/graphql-java · GitHub

Open Graph Title: Reduce PerLevelDataLoaderDispatchStrategy bookkeeping: pack per-level counters into one AtomicLong by Meemaw · Pull Request #4502 · graphql-java/graphql-java

X Title: Reduce PerLevelDataLoaderDispatchStrategy bookkeeping: pack per-level counters into one AtomicLong by Meemaw · Pull Request #4502 · graphql-java/graphql-java

Description: What PerLevelDataLoaderDispatchStrategy.CallStack keeps two counters per level (happenedExecuteObjectCalls, happenedCompletionFinishedCount). Today they live in an immutable StateForLevel behind ConcurrentHashMap>, so every executeObject and every object completion: does a computeIfAbsent lookup on the map, allocates a new StateForLevel, retries a compare-and-set until it wins, which under concurrent completions on the same level means repeated allocation and retries. The readiness check (isLevelReady) also reads the two counters with separate get() calls. This PR stores each level's counters in one AtomicLong: the completion count in the high 32 bits and the execute-object calls in the low 32 bits. The levels sit in an array indexed by level, which grows on demand; query depth bounds its size. Increments: a single getAndIncrement / getAndAdd, with no allocation and no retry loop. Readiness: allExecuteObjectCallsCompleted(level) reads both counters from one snapshot. Hot path: a volatile array read. Only creating a new level, or growing the array, is synchronized. Compatibility: get(level) and tryUpdateLevel(...) keep their signatures, so the existing tests and the subscription/defer paths that use them work unchanged. No public API changes. Benchmark PerLevelDispatchOverheadPerformance (new) isolates the strategy's cost. It runs the same wide query (items(250) { a b c d e child { x y grand(5) { v w } } }) with the same data fetchers, none of which use a DataLoader, in two modes: none: no DataLoaderRegistry, so the engine uses the no-op dispatch strategy; perLevel: a registry holding one unused loader, which switches the engine to PerLevelDataLoaderDispatchStrategy. The difference between the two modes is everything the strategy costs. With async = true, a scalar field on every item completes on a 4-thread pool, so completions for the same level race on the per-level state. That matches servers whose fetchers resume on worker threads. Results with 5 forks, in µs/op (./gradlew jmh -PjmhInclude=PerLevelDispatchOverheadPerformance, JDK 25, Apple M-series): fetchers strategy master this PR async none 795.9 791.8 async perLevel 879.9 ± 9.9 785.8 ± 26.8 async overhead +84.0 (+10.6%) −6.0 (noise) sync none 582.6 562.1 sync perLevel 601.1 577.3 sync overhead +18.5 +15.2 (unchanged within noise) With async completion the strategy's overhead disappears; with synchronous fetchers there is no measurable change. Allocation per op is unchanged within noise. PerLevelDispatchPerformance (also new) is the same query shape with a real DataLoader-backed child field, for an end-to-end view. Its timings were within noise before and after, because the DataLoader dispatch itself dominates there. I'd welcome a run on your isolated performance environment, since these numbers come from a laptop. Tests New Spock cases in PerLevelDataLoaderDispatchStrategyTest: level counters beyond the initial array capacity (level 40), the single-snapshot readiness check, and clear(); 8 threads × 10k increments across 20 levels with no lost updates. Full suite: ./gradlew test passed locally (5,792 tests). 🤖 Generated with Claude Code

Open Graph Description: What PerLevelDataLoaderDispatchStrategy.CallStack keeps two counters per level (happenedExecuteObjectCalls, happenedCompletionFinishedCount). Today they live in an immutable StateForLevel behind Co...

X Description: What PerLevelDataLoaderDispatchStrategy.CallStack keeps two counters per level (happenedExecuteObjectCalls, happenedCompletionFinishedCount). Today they live in an immutable StateForLevel behind Co...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4502

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:441f1633-26d4-3290-6809-5e718691314c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1A0:3A4875:1FF1465:2A82702:6B017C6B
html-safe-noncee5741dcf3d9cc6f952e6e4e123fbdb9e50cf4670b11e0f662aa09e08df76cce9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUEwOjNBNDg3NToxRkYxNDY1OjJBODI3MDI6NkIwMTdDNkIiLCJ2aXNpdG9yX2lkIjoiNjg0NzY1NDk2MjQxMTk2MTQ1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc3b6d97acbeed56d37b56807fd18c8119431c33a2b9e17fe7f4fa6583b543134
hovercard-subject-tagpull_request:4923356829
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4502/files
twitter:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
og:image:altWhat PerLevelDataLoaderDispatchStrategy.CallStack keeps two counters per level (happenedExecuteObjectCalls, happenedCompletionFinishedCount). Today they live in an immutable StateForLevel behind Co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4502/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4502%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4502%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4502/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4502/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4502/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
Meemawhttps://github.com/Meemaw
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
Meemaw:perf/per-level-dispatch-packed-countershttps://github.com/Meemaw/graphql-java/tree/perf/per-level-dispatch-packed-counters
Conversation 3 https://github.com/graphql-java/graphql-java/pull/4502
Commits 2 https://github.com/graphql-java/graphql-java/pull/4502/commits
Checks 10 https://github.com/graphql-java/graphql-java/pull/4502/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4502/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4502/files
Reduce PerLevelDataLoaderDispatchStrategy bookkeeping: pack per-level counters into one AtomicLong https://github.com/graphql-java/graphql-java/pull/4502/files#top
Show all changes 2 commits https://github.com/graphql-java/graphql-java/pull/4502/files
3f43882 Pack PerLevelDataLoaderDispatchStrategy per-level counters into one A… Meemaw Oct 19, 2026 https://github.com/graphql-java/graphql-java/pull/4502/commits/3f4388256aac3f75b585b21a0a24c071a8fb7c96
94b212d Test PerLevelDataLoaderDispatchStrategy CallStack level growth and co… Meemaw Oct 19, 2026 https://github.com/graphql-java/graphql-java/pull/4502/commits/94b212d6d0b16caf386e76ed628e9a8432b1808e
Clear filters https://github.com/graphql-java/graphql-java/pull/4502/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4502/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4502/files
PerLevelDispatchOverheadPerformance.java https://github.com/graphql-java/graphql-java/pull/4502/files#diff-f9d789ec0fc44b71004e4c68523382a6c3c71c16571d1949b7bb5381c888de1a
PerLevelDispatchPerformance.java https://github.com/graphql-java/graphql-java/pull/4502/files#diff-8adfee559c42fc2cc2ab57baf0d79df653550a83b07b7621eb991a8f6a1c2597
PerLevelDataLoaderDispatchStrategy.java https://github.com/graphql-java/graphql-java/pull/4502/files#diff-b98f8b367ae08a43d8274ee6718e816c190bee95f2ffa82300b661fe6699bac2
PerLevelDataLoaderDispatchStrategyTest.groovy https://github.com/graphql-java/graphql-java/pull/4502/files#diff-4b5c038c7db3075b1cc6568e050df80cd3946c2b530e712133e57dc7f03042b1
src/jmh/java/performance/PerLevelDispatchOverheadPerformance.javahttps://github.com/graphql-java/graphql-java/pull/4502/files#diff-f9d789ec0fc44b71004e4c68523382a6c3c71c16571d1949b7bb5381c888de1a
View file https://github.com/graphql-java/graphql-java/blob/94b212d6d0b16caf386e76ed628e9a8432b1808e/src/jmh/java/performance/PerLevelDispatchOverheadPerformance.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4502/{{ revealButtonHref }}
src/jmh/java/performance/PerLevelDispatchPerformance.javahttps://github.com/graphql-java/graphql-java/pull/4502/files#diff-8adfee559c42fc2cc2ab57baf0d79df653550a83b07b7621eb991a8f6a1c2597
View file https://github.com/graphql-java/graphql-java/blob/94b212d6d0b16caf386e76ed628e9a8432b1808e/src/jmh/java/performance/PerLevelDispatchPerformance.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4502/{{ revealButtonHref }}
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4502/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4502/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.