René's URL Explorer Experiment


Title: Format i18n message arguments with the message locale by Meemaw · Pull Request #4500 · graphql-java/graphql-java · GitHub

Open Graph Title: Format i18n message arguments with the message locale by Meemaw · Pull Request #4500 · graphql-java/graphql-java

X Title: Format i18n message arguments with the message locale by Meemaw · Pull Request #4500 · graphql-java/graphql-java

Description: Problem I18n.msgImpl creates its formatter with new MessageFormat(msgPattern), which uses the JVM default (format) locale. So the message text comes from the requested locale's bundle, but the arguments (line/column numbers, counts, etc.) are formatted with whatever locale the JVM happens to run in. For example, with a JVM default locale of sl_SI, an English parser error renders as: ... Offending token '\uD83D' at line −1 column −1 (U+2212 minus sign) ... Offending token at line −1 column 1.234 instead of line -1 column -1 / column 1,234. A side effect is that StringValueParsingUnicodeTest (which explicitly requests Locale.ENGLISH) fails 14 tests on machines with such a default locale. Fix Pass the I18n instance's locale to the MessageFormat, so arguments are formatted consistently with the message. This is the only MessageFormat usage in src/main. Note: for a JVM whose default locale already matches the requested locale (the common case) the output is unchanged. Verification Added I18nTest case that sets the JVM default to sl-SI and checks that an English message formats -1 / 1,234 and a German message formats 1.234. Without the fix it fails with line −1 column 1.234. The 14 previously failing StringValueParsingUnicodeTest tests now pass on a sl_SI machine. Full test suite passes (5773 tests, JDK 25, LANG=sl_SI.UTF-8). 🤖 Generated with Claude Code

Open Graph Description: Problem I18n.msgImpl creates its formatter with new MessageFormat(msgPattern), which uses the JVM default (format) locale. So the message text comes from the requested locale's bundle, but the ...

X Description: Problem I18n.msgImpl creates its formatter with new MessageFormat(msgPattern), which uses the JVM default (format) locale. So the message text comes from the requested locale's bundle, but ...

Opengraph URL: https://github.com/graphql-java/graphql-java/pull/4500

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b4bd5e2a-3dc9-ce44-6700-ba13aee4173b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BD6:3F4253:21DEA92:2D126B7:6B018B15
html-safe-nonce8cd815a39b80e36b1d1d512ce8f9bd9c03e2a4f4ba7c9c8eff15f6dadb7e1868
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkQ2OjNGNDI1MzoyMURFQTkyOjJEMTI2Qjc6NkIwMThCMTUiLCJ2aXNpdG9yX2lkIjoiNTY2NTE5ODg0MDMxNjI2NzI4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5bdf48eee8cf840e4c8f5690750d29e5e53361c6c69f505c78c1e25f31c07609
hovercard-subject-tagpull_request:4903461530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/graphql-java/graphql-java/pull/4500/files
twitter:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8524109?s=400&v=4
og:image:altProblem I18n.msgImpl creates its formatter with new MessageFormat(msgPattern), which uses the JVM default (format) locale. So the message text comes from the requested locale's bundle, but the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/graphql-java/graphql-java git https://github.com/graphql-java/graphql-java.git
octolytics-dimension-user_id14289921
octolytics-dimension-user_logingraphql-java
octolytics-dimension-repository_id38602457
octolytics-dimension-repository_nwographql-java/graphql-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38602457
octolytics-dimension-repository_network_root_nwographql-java/graphql-java
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/graphql-java/graphql-java/pull/4500/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4500%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgraphql-java%2Fgraphql-java%2Fpull%2F4500%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=graphql-java%2Fgraphql-java
Reloadhttps://github.com/graphql-java/graphql-java/pull/4500/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4500/files
Reloadhttps://github.com/graphql-java/graphql-java/pull/4500/files
graphql-javahttps://github.com/graphql-java
graphql-javahttps://github.com/graphql-java/graphql-java
Codehttps://github.com/graphql-java/graphql-java
Issues27 (27)https://github.com/graphql-java/graphql-java/issues
Pull requests35 (35)https://github.com/graphql-java/graphql-java/pulls
Discussionshttps://github.com/graphql-java/graphql-java/discussions
Actionshttps://github.com/graphql-java/graphql-java/actions
Projectshttps://github.com/graphql-java/graphql-java/projects
Wikihttps://github.com/graphql-java/graphql-java/wiki
Security and qualityhttps://github.com/graphql-java/graphql-java/security
Insightshttps://github.com/graphql-java/graphql-java/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fgraphql-java%2Fgraphql-java%2Fissues%2Fnew%2Fchoose
bbakermanhttps://github.com/bbakerman
graphql-java:masterhttps://github.com/graphql-java/graphql-java/tree/master
Meemaw:fix/i18n-message-format-localehttps://github.com/Meemaw/graphql-java/tree/fix/i18n-message-format-locale
Conversation 2 https://github.com/graphql-java/graphql-java/pull/4500
Commits 1 https://github.com/graphql-java/graphql-java/pull/4500/commits
Checks 11 https://github.com/graphql-java/graphql-java/pull/4500/checks
Files changed https://github.com/graphql-java/graphql-java/pull/4500/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4500/files
Format i18n message arguments with the message locale https://github.com/graphql-java/graphql-java/pull/4500/files#top
Show all changes 1 commit https://github.com/graphql-java/graphql-java/pull/4500/files
3d47ff6 Format i18n message arguments with the message locale Meemaw Oct 17, 2026 https://github.com/graphql-java/graphql-java/pull/4500/commits/3d47ff607d0e5e61a5fe4f48cbc7d0c95872d76d
Clear filters https://github.com/graphql-java/graphql-java/pull/4500/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4500/files
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4500/files
I18n.java https://github.com/graphql-java/graphql-java/pull/4500/files#diff-79f19d670695399cc68e515f15bdca828955586e55c1e16869fb10ad216f77b1
I18nTest.groovy https://github.com/graphql-java/graphql-java/pull/4500/files#diff-f300c2e0e583f45e8ec30ad4d297562e02d60d59c31e13e7e43786a5471d469b
src/main/java/graphql/i18n/I18n.javahttps://github.com/graphql-java/graphql-java/pull/4500/files#diff-79f19d670695399cc68e515f15bdca828955586e55c1e16869fb10ad216f77b1
View file https://github.com/Meemaw/graphql-java/blob/3d47ff607d0e5e61a5fe4f48cbc7d0c95872d76d/src/main/java/graphql/i18n/I18n.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4500/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4500/files#diff-79f19d670695399cc68e515f15bdca828955586e55c1e16869fb10ad216f77b1
src/test/groovy/graphql/i18n/I18nTest.groovyhttps://github.com/graphql-java/graphql-java/pull/4500/files#diff-f300c2e0e583f45e8ec30ad4d297562e02d60d59c31e13e7e43786a5471d469b
View file https://github.com/Meemaw/graphql-java/blob/3d47ff607d0e5e61a5fe4f48cbc7d0c95872d76d/src/test/groovy/graphql/i18n/I18nTest.groovy
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/graphql-java/graphql-java/pull/4500/{{ revealButtonHref }}
https://github.com/graphql-java/graphql-java/pull/4500/files#diff-f300c2e0e583f45e8ec30ad4d297562e02d60d59c31e13e7e43786a5471d469b
https://github.com/graphql-java/graphql-java/pull/4500/files#diff-f300c2e0e583f45e8ec30ad4d297562e02d60d59c31e13e7e43786a5471d469b
Please reload this pagehttps://github.com/graphql-java/graphql-java/pull/4500/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.